Bug 2401804 - Review Request: python-sqlite-utils - Python CLI utility and library for manipulating SQLite databases
Summary: Review Request: python-sqlite-utils - Python CLI utility and library for mani...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Benson Muite
QA Contact: Fedora Extras Quality Assurance
URL: https://pypi.python.org/project/sqlit...
Whiteboard:
Depends On:
Blocks: 2376478
TreeView+ depends on / blocked
 
Reported: 2025-10-06 09:16 UTC by Terje Rosten
Modified: 2025-10-23 01:57 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-10-09 08:27:36 UTC
Type: ---
Embargoed:
benson_muite: fedora-review+


Attachments (Terms of Use)

Description Terje Rosten 2025-10-06 09:16:02 UTC
spec: https://terjeros.fedorapeople.org/python-sqlite-utils/python-sqlite-utils.spec
srpm: https://terjeros.fedorapeople.org/python-sqlite-utils/python-sqlite-utils-3.38-1.fc42.src.rpm
user: terjeros
koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=137834315
Description:
Python CLI utility and library for manipulating SQLite databases.
Some features: 
- Pipe JSON (or CSV or TSV) directly into a new SQLite database file,
  automatically creating a table with the appropriate schema 

- Run in-memory SQL queries, including joins, directly against data in
  CSV, TSV or JSON files and view the results

- Configure SQLite full-text search against your database tables and run
  search queries against them, ordered by relevance

- Run transformations against your tables to make schema changes that
  SQLite ALTER TABLE does not directly support, such as changing the type of a column

- Extract columns into separate tables to better normalize your existing data

- Install plugins to add custom SQL functions and additional features

Comment 1 Fedora Review Service 2025-10-06 09:18:00 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9647578
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2401804-python-sqlite-utils/fedora-rawhide-x86_64/09647578-python-sqlite-utils/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Benson Muite 2025-10-08 20:14:30 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "*No copyright* Apache License 2.0", "Unknown or generated",
     "*No copyright* Apache License". 71 files have unknown license.
     Detailed output of licensecheck in /home/fedora-
     packaging/reviews/python-sqlite-utils/2401804-python-sqlite-
     utils/licensecheck.txt
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib/python3.14/site-
     packages, /usr/lib/python3.14
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 5188 bytes in 1 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[-]: Python eggs must not download any dependencies during the build
     process.
[-]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python3-sqlite-utils-3.38-1.fc44.noarch.rpm
          python-sqlite-utils-3.38-1.fc44.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.7.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp5j7d6k48')]
checks: 32, packages: 2

python3-sqlite-utils.noarch: W: no-manual-page-for-binary sqlite-utils
python-sqlite-utils.src: E: description-line-too-long   SQLite ALTER TABLE does not directly support, such as changing the type of a column
python3-sqlite-utils.noarch: E: description-line-too-long   SQLite ALTER TABLE does not directly support, such as changing the type of a column
 2 packages and 0 specfiles checked; 2 errors, 1 warnings, 7 filtered, 2 badness; has taken 0.6 s 




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.7.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

python3-sqlite-utils.noarch: W: no-manual-page-for-binary sqlite-utils
python3-sqlite-utils.noarch: E: description-line-too-long   SQLite ALTER TABLE does not directly support, such as changing the type of a column
 1 packages and 0 specfiles checked; 1 errors, 1 warnings, 3 filtered, 1 badness; has taken 0.1 s 



Source checksums
----------------
https://files.pythonhosted.org/packages/source/s/sqlite_utils/sqlite_utils-3.38.tar.gz :
  CHECKSUM(SHA256) this package     : 1ae77b931384052205a15478d429464f6c67a3ac3b4eafd3c674ac900f623aab
  CHECKSUM(SHA256) upstream package : 1ae77b931384052205a15478d429464f6c67a3ac3b4eafd3c674ac900f623aab


Requires
--------
python3-sqlite-utils (rpmlib, GLIBC filtered):
    /usr/bin/python3
    python(abi)
    python3.14dist(click)
    python3.14dist(click-default-group)
    python3.14dist(pluggy)
    python3.14dist(python-dateutil)
    python3.14dist(sqlite-fts4)
    python3.14dist(tabulate)



Provides
--------
python3-sqlite-utils:
    python-sqlite-utils
    python3-sqlite-utils
    python3.14-sqlite-utils
    python3.14dist(sqlite-utils)
    python3dist(sqlite-utils)



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2401804
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Python, Shell-api
Disabled plugins: R, Haskell, Ocaml, fonts, Perl, PHP, SugarActivity, Java, C/C++
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Comments:
a) Koji build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=137917858
b) python-beanbag-docutils seems to be needed to build documentation, but packaging seems
troublesome:
https://koji.fedoraproject.org/koji/taskinfo?taskID=137923119
python-pygments-csv-lexer also needs to be packaged.
Perhaps see if upstream can provide a way to build documentation with fewer dependencies?

c) Warnings during build may want to let upstream know about:
tests/test_insert_files.py: 12 warnings
  /builddir/build/BUILD/python-sqlite-utils-3.38-build/sqlite_utils-3.38/sqlite_utils/cli.py:3206: DeprecationWarning: datetime.date
time.utcfromtimestamp() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetim
es in UTC: datetime.datetime.fromtimestamp(timestamp, datetime.UTC).
    "mtime_iso": lambda p: datetime.utcfromtimestamp(p.stat().st_mtime).isoformat(),
tests/test_insert_files.py: 12 warnings
  /builddir/build/BUILD/python-sqlite-utils-3.38-build/sqlite_utils-3.38/sqlite_utils/cli.py:3207: DeprecationWarning: datetime.date
time.utcfromtimestamp() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetim
es in UTC: datetime.datetime.fromtimestamp(timestamp, datetime.UTC).
    "ctime_iso": lambda p: datetime.utcfromtimestamp(p.stat().st_ctime).isoformat(),
tests/test_recipes.py::test_dateparse_errors[None-parsedate]
  /usr/lib/python3.14/site-packages/_pytest/unraisableexception.py:85: PytestUnraisableExceptionWarning: Exception ignored on sqlite
3 callback <function Table.convert.<locals>.convert_value at 0x7fde5f4c2090>: None
  
  Traceback (most recent call last):
    File "/builddir/build/BUILD/python-sqlite-utils-3.38-build/sqlite_utils-3.38/sqlite_utils/db.py", line 2886, in convert_value
      return jsonify_if_needed(fn(v))
                               ~~^^^
    File "/builddir/build/BUILD/python-sqlite-utils-3.38-build/sqlite_utils-3.38/tests/test_recipes.py", line 77, in <lambda>
      fresh_db["example"].convert("dt", lambda value: getattr(recipes, fn)(value))
                                                      ~~~~~~~~~~~~~~~~~~~~^^^^^^^
    File "/builddir/build/BUILD/python-sqlite-utils-3.38-build/sqlite_utils-3.38/sqlite_utils/recipes.py", line 19, in parsedate
      parser.parse(value, dayfirst=dayfirst, yearfirst=yearfirst)
      ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/usr/lib/python3.14/site-packages/dateutil/parser/_parser.py", line 1368, in parse
      return DEFAULTPARSER.parse(timestr, **kwargs)
             ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
    File "/usr/lib/python3.14/site-packages/dateutil/parser/_parser.py", line 643, in parse
      raise ParserError("Unknown string format: %s", timestr)
  dateutil.parser._parser.ParserError: Unknown string format: invalid
  
    warnings.warn(pytest.PytestUnraisableExceptionWarning(msg))
tests/test_recipes.py::test_dateparse_errors[None-parsedatetime]
  /usr/lib/python3.14/site-packages/_pytest/unraisableexception.py:85: PytestUnraisableExceptionWarning: Exception ignored on sqlite
3 callback <function Table.convert.<locals>.convert_value at 0x7fde5f4c2b90>: None
  
  Traceback (most recent call last):
    File "/builddir/build/BUILD/python-sqlite-utils-3.38-build/sqlite_utils-3.38/sqlite_utils/db.py", line 2886, in convert_value
      return jsonify_if_needed(fn(v))
                               ~~^^^
    File "/builddir/build/BUILD/python-sqlite-utils-3.38-build/sqlite_utils-3.38/tests/test_recipes.py", line 77, in <lambda>
      fresh_db["example"].convert("dt", lambda value: getattr(recipes, fn)(value))
                                                      ~~~~~~~~~~~~~~~~~~~~^^^^^^^
    File "/builddir/build/BUILD/python-sqlite-utils-3.38-build/sqlite_utils-3.38/sqlite_utils/recipes.py", line 42, in parsedatetime
      return parser.parse(value, dayfirst=dayfirst, yearfirst=yearfirst).isoformat()
             ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/usr/lib/python3.14/site-packages/dateutil/parser/_parser.py", line 1368, in parse
      return DEFAULTPARSER.parse(timestr, **kwargs)
             ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
    File "/usr/lib/python3.14/site-packages/dateutil/parser/_parser.py", line 643, in parse
      raise ParserError("Unknown string format: %s", timestr)
  dateutil.parser._parser.ParserError: Unknown string format: invalid
  
    warnings.warn(pytest.PytestUnraisableExceptionWarning(msg))
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

d) Approved
e) Review of one of:
https://bugzilla.redhat.com/show_bug.cgi?id=2399984
https://bugzilla.redhat.com/show_bug.cgi?id=2401972
https://bugzilla.redhat.com/show_bug.cgi?id=2399993
https://bugzilla.redhat.com/show_bug.cgi?id=2386164
would be appreciated if time allows.

Comment 3 Fedora Admin user for bugzilla script actions 2025-10-09 07:55:57 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-sqlite-utils

Comment 4 Fedora Update System 2025-10-09 08:24:02 UTC
FEDORA-2025-3d2cc1a4ce (python-sqlite-utils-3.38-1.fc44) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-3d2cc1a4ce

Comment 5 Fedora Update System 2025-10-09 08:27:36 UTC
FEDORA-2025-3d2cc1a4ce (python-sqlite-utils-3.38-1.fc44) has been pushed to the Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 6 Fedora Update System 2025-10-14 07:32:09 UTC
FEDORA-2025-a08c776e28 (python-sqlite-utils-3.38-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-a08c776e28

Comment 7 Fedora Update System 2025-10-14 07:32:09 UTC
FEDORA-2025-1f8fee5676 (python-sqlite-utils-3.38-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-1f8fee5676

Comment 8 Fedora Update System 2025-10-15 01:35:56 UTC
FEDORA-2025-1f8fee5676 has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-1f8fee5676`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-1f8fee5676

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2025-10-15 02:02:16 UTC
FEDORA-2025-a08c776e28 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-a08c776e28`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-a08c776e28

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2025-10-23 01:03:19 UTC
FEDORA-2025-1f8fee5676 (python-sqlite-utils-3.38-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2025-10-23 01:57:08 UTC
FEDORA-2025-a08c776e28 (python-sqlite-utils-3.38-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.