Spec URL: https://download.copr.fedorainfracloud.org/results/dchen/to-be-reviewed/fedora-rawhide-x86_64/09649938-fasttext/fasttext.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/dchen/to-be-reviewed/fedora-rawhide-x86_64/09649938-fasttext/fasttext-0.9.2-2.fc44.src.rpm Description: The fastText is a library for efficient learning of word representations and sentence classification. Fedora Account System Username: dchen
This is a re-review of retired package fasttext. I package this as a dependency of language-tools
Copr build: https://copr.fedorainfracloud.org/coprs/build/9671167 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2402620-fasttext/fedora-rawhide-x86_64/09671167-fasttext/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/fasttext Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Upstream archived the software in 2024 - maybe there is an active maintained fork?
Maybe https://github.com/munlicode/fasttext-community is a better choice? Can the python bindings also be built? See for example: https://build.opensuse.org/projects/openSUSE:Factory/packages/python-fasttext/files/python-fasttext.spec?expand=1 Perhaps the trained model should be a separate package? It seems to have been trained on data with known licenses.
### https://github.com/munlicode/fasttext-community is a better choice? Do you think it is better rename the package as fasttext-community? ### Can the python bindings also be built? S Sure, after the package name is settled ### Perhaps the trained model should be a separate package? So far I put the lid.176.bin as sub-package fasttext-data. We can work out a better naming convention.
(In reply to Ding-Yi Chen from comment #5) > ### https://github.com/munlicode/fasttext-community is a better choice? > > Do you think it is better rename the package as fasttext-community? If this package would work for you it seems better to import it instead. > > > ### Can the python bindings also be built? S > > Sure, after the package name is settled > Ok > ### Perhaps the trained model should be a separate package? > > So far I put the lid.176.bin as sub-package fasttext-data. > We can work out a better naming convention. Perhaps fasttext-models is an appropriate name for the package. Would open another bugzilla ticket.
### If this package would work for you it seems better to import it instead. Perhaps not. I believe the community change project for a purpose. I suppose the package name should match the upstream package name to avoid confusion and acknowledge the work of community.
0.9.2-3: - Rename the data subpackage as model-lid-176-bin - Add model-lid-176-ftz - Add python3 subpackage https://download.copr.fedorainfracloud.org/results/dchen/to-be-reviewed/fedora-rawhide-x86_64/09704896-fasttext/fasttext.spec https://download.copr.fedorainfracloud.org/results/dchen/to-be-reviewed/fedora-rawhide-x86_64/09704896-fasttext/fasttext-0.9.2-3.fc44.src.rpm
Hi, @Benson Muite, do you got time to continue review?