Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://farchord.fedorapeople.org/reviews/kretro/kretro.spec SRPM URL: https://farchord.fedorapeople.org/reviews/kretro/kretro-0.0.1-1.fc43.src.rpm Description: Play your favorite games across Plasma platforms. Fedora Account System Username: farchord
Hello, I do realize that this is possibly an old ticket. I am sorry that it hasn't been reviewed yet. Let me trigger the Fedora Review Service to see if the package builds successfully. Hopefully, a green check mark will attract some reviewer. If I am resurrecting an old ticket that you are not interested in anymore, my apologies, feel free to close it. [fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/9820257 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2403330-kretro/fedora-rawhide-x86_64/09820257-kretro/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> License: FSFAP AND GPL-3.0-or-later AND MIT AND CC0-1.0 AND LGPL-3.0-only AND Unlicense AND LGPL-2.0-or-later AND LGPL-2.1-only AND BSD-3-Clause AND CC-BY-SA-4.0 AND GPL-2.0-or-later Please add a comment describing the licensing breakdown. > desktop-file-validate %{buildroot}/%{_datadir}/applications/org.kde.kretro.desktop > appstream-util validate-relax --nonet %{buildroot}%{_metainfodir}/*.metainfo.xml Arguably, this should be moved from %install to %check. Also, rpmlint says: > E: incorrect-fsf-address /usr/share/licenses/kretro/GPL-2.0-or-later.txt > E: incorrect-fsf-address /usr/share/licenses/kretro/LGPL-2.0-or-later.txt > E: incorrect-fsf-address /usr/share/licenses/kretro/LGPL-2.1-only.txt Might be good to report this upstream.
(In reply to Artur Frenszek-Iwicki from comment #3) > > License: FSFAP AND GPL-3.0-or-later AND MIT AND CC0-1.0 AND LGPL-3.0-only AND Unlicense AND LGPL-2.0-or-later AND LGPL-2.1-only AND BSD-3-Clause AND CC-BY-SA-4.0 AND GPL-2.0-or-later > Please add a comment describing the licensing breakdown. So I should include the breakdown/output from reuse? I can, but it can be quite lengthy and, as it's a brand new piece of software it is subject to changes (It's highly likely)... > > desktop-file-validate %{buildroot}/%{_datadir}/applications/org.kde.kretro.desktop > > appstream-util validate-relax --nonet %{buildroot}%{_metainfodir}/*.metainfo.xml > Arguably, this should be moved from %install to %check. Yeah it can be in either. > Also, rpmlint says: > > E: incorrect-fsf-address /usr/share/licenses/kretro/GPL-2.0-or-later.txt > > E: incorrect-fsf-address /usr/share/licenses/kretro/LGPL-2.0-or-later.txt > > E: incorrect-fsf-address /usr/share/licenses/kretro/LGPL-2.1-only.txt > Might be good to report this upstream. Regarding this one... I downloaded fresh licenses using reuse, and the licenses were identical. Guessing the lint errors are wrong?
> So I should include the breakdown/output from reuse? I can, but it can be quite lengthy and, as it's a brand new piece of software it is subject to changes (It's highly likely)... I don't think the full output is needed, but some abbreviated breakdown from REUSE or licensecheck should be ok. Speaking of licensecheck - it claims that BSD-3-Clause applies only to Android-specific files, so you could consider removing it from the License tag (and possibly remove said files in %prep). Also, looking at the source archive, it contains some pre-compiled "cores" for x86_64 and amd64. Reading through the build log, it seems these are unused, but it might still be a good idea to remove them in %prep as to ensure you don't use any pre-compiled binaries.