Bug 240389 - Default handlers don't work anymore with 1.20
Summary: Default handlers don't work anymore with 1.20
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: gpm
Version: 5
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Tomas Janousek
QA Contact: David Lawrence
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-05-16 23:29 UTC by Samuel Thibault
Modified: 2007-11-30 22:12 UTC (History)
0 users

(edit)
Clone Of:
(edit)
Last Closed: 2007-06-04 21:27:11 UTC

Attachments (Terms of Use)
revert to good old behavior (1.04 KB, patch)
2007-05-16 23:29 UTC, Samuel Thibault 		no flags Details | Diff
patch for version 1.20.1 (953 bytes, patch)
2007-05-16 23:48 UTC, Samuel Thibault 		no flags Details | Diff
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Description Samuel Thibault 2007-05-16 23:29:08 UTC 
Description of problem:
Default handlers (like the brltty daemon) don't work anymore with version 1.20 of gpm.

Version-Release number of selected component (if applicable):
1.20

How reproducible:
Always


Steps to Reproduce:
1. run brltty -b no -l 7 -n -e -x lx

Actual results:
notice the GPM errors about "Inappropriate ioctl for device"

Expected results:
There shouldn't be such error

Additional info:
This is because in Gpm_Open(), the flag<0 case isn't even treated in any particular way any more since version 1.20. The attached patch should fix that.
Comment 1 Samuel Thibault 2007-05-16 23:29:08 UTC 
Created attachment 154882 [details]
revert to good old behavior
Comment 2 Samuel Thibault 2007-05-16 23:48:58 UTC 
Created attachment 154885 [details]
patch for version 1.20.1

Oops, sorry, the attached patch was for version 1.20.2-broken. This one is for
1.20.1.
Comment 3 Tomas Janousek 2007-05-23 13:26:57 UTC 
Ok, applied. I have the builds ready for f5/6/7/8, but will wait with the update
for the release of F7 and availability of the update system.
Comment 4 Fedora Update System 2007-06-04 21:27:09 UTC 
gpm-1.20.1-84.fc7 has been pushed to the Fedora 7 stable repository.  If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.