Spec URL: https://trix.fedorapeople.org/python-amd-debug-tools.spec SRPM URL: https://trix.fedorapeople.org/python-amd-debug-tools-0.2.8-1.fc44.src.rpm Reproducible: Always
Copr build: https://copr.fedorainfracloud.org/coprs/build/9696701 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2404638-python-amd-debug-tools/fedora-rawhide-x86_64/09696701-python-amd-debug-tools/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I am seeing positive result in Fedora Rawhide. I installed the package and ran amd-s2idle & then compared it with the output from running the script directly from https://web.git.kernel.org/pub/scm/linux/kernel/git/superm1/amd-debug-tools.git . The only issue I noticed was that the Firefox browser will not open the html result a new tab, if it's already opened. It will throw an error popup. If the Firefox browser window is not open, a mew Firefox window will be launched with html output. But, Fedora 42 build has failed, because the package "git" is required. From the build log..... Processing /builddir/build/BUILD/python-amd-debug-tools-0.2.8-build/amd-debug-tools-0.2.8 Preparing metadata (pyproject.toml): started Running command Preparing metadata (pyproject.toml) /bin/sh: line 1: git: command not found /bin/sh: line 1: git: command not found
I think git error is a false positive. the building is from a tarball and disconnected from the network.
How should the other requirements for running the commands be handled? I tried to run amd-s2idle on a test machine but had to install v4l-utils, ethtool and acpica-tools before it would try to run. Should those be requires?
Spec URL: https://trix.fedorapeople.org/python-amd-debug-tools.spec SRPM URL: https://trix.fedorapeople.org/python-amd-debug-tools-0.2.8-1.fc44.src.rpm Yes! Thanks for trying it out, the package has been updated. Also, here is a docker for trying it out. https://github.com/trixirt/rocm-distro-containers/blob/main/fedora/rawhide/python-amd-debug-tools/Dockerfile
Created attachment 2111661 [details] The .spec file difference from Copr build 9696701 to 9753344
Copr build: https://copr.fedorainfracloud.org/coprs/build/9753344 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2404638-python-amd-debug-tools/fedora-rawhide-x86_64/09753344-python-amd-debug-tools/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Created attachment 2114995 [details] Suggested changes to specfile Please add the license in the %license section. Also, afaik we don't need the pip buildrequires. It could also be easier to generate the BuildRequires from pyproject.toml by using %generate_buildrequires and %pyproject_buildrequires instead of rewriting them manually manually, but this part is up to your preference.
There is test suite available, can you please try to add: %pytest line in %check section (might need to add some more buildreqs)?
Spec URL: https://trix.fedorapeople.org/python-amd-debug-tools.spec SRPM URL: https://trix.fedorapeople.org/python-amd-debug-tools-0.2.10-1.fc44.src.rpm For an update to the latest upstream. changed to generate requires. >> Please add the license in the %license section. Not need, i use -l in the pyproject_install https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#pyproject_install %check is not practical it requires amd hardware.
Created attachment 2115068 [details] The .spec file difference from Copr build 9753344 to 9808755
Copr build: https://copr.fedorainfracloud.org/coprs/build/9808755 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2404638-python-amd-debug-tools/fedora-rawhide-x86_64/09808755-python-amd-debug-tools/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.