Red Hat Bugzilla – Bug 240594
Review Request: cmigemo - C interface of Ruby/Migemo Japanese incremental search tool
Last modified: 2007-11-30 17:12:04 EST
Spec URL: http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SPECS/cmigemo.spec SRPM URL: http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SRPMS/cmigemo-1.3-0.1.c_MIT.fc7.src.rpm Mock build log on FC-devel i386: http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/LOGS/MOCK-cmigemo.log Description: C/Migemo is a C interface of Ruby/Migemo, a Japanese incremental search tool by Romaji.
http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SPECS/cmigemo.spec http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SRPMS/cmigemo-1.3-0.2.c_MIT.fc7.src.rpm ---------------------------------------------------- * Sun May 19 2007 Mamoru Tasaka <mtasaka@ioa.s.u-tokyo.ac.jp> - 1.3-0.2.c_MIT - 64 bits fix
MUST: ===== * rpmlint output is: W: cmigemo-devel no-documentation * Package and spec file named appropriately * Packaged according to packaging guidelines * License ok * spec file is legible and in Am. English. * Source matches upstream (as explained in the comment) * Compiles and builds on devel x86_64 * BR: ok * No locales * ldconfig run for shared libraries * Not relocatable * Package owns / or requires all dirs * No duplicate files & Permissions * %clean & macro usage OK * Contains code and permissable content * %doc does not affect runtime, and isn't large enough to warrent a sub package * -devel package as needed * no .desktop file needed Must FIX ======== * Don't add tools/migemo.vim.dir sed command backup file to %doc
Thank you for initial comments. (In reply to comment #2) > Must FIX > ======== > * Don't add tools/migemo.vim.dir sed command backup file to %doc Okay. http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SPECS/cmigemo.spec http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SRPMS/cmigemo-1.3-0.3.c_MIT.fc7.src.rpm http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SPECS/cmigemo-1.3-0.2-0.3.diff ------------------------------------------------------- * Sun May 20 2007 Mamoru Tasaka <mtasaka@ioa.s.u-tokyo.ac.jp> - 1.3-0.3.c_MIT - Don't create unnecessary document backup
All Must fix items fixed: approved!
Thank you! Request to CVS admin ---------------------------------------------- New Package CVS Request ======================= Package Name: cmigemo Short Description: C interface of Ruby/Migemo Japanese incremental search tool Owners: mtasaka@ioa.s.u-tokyo.ac.jp Branches: devel F-7 FC-6 FC-5 InitialCC: (nobody) ----------------------------------------------
Rebuilt for all branch, closing. Thank you for your review!!