Bug 240594 - Review Request: cmigemo - C interface of Ruby/Migemo Japanese incremental search tool
Summary: Review Request: cmigemo - C interface of Ruby/Migemo Japanese incremental sea...
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review   
(Show other bugs)
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Hans de Goede
QA Contact: Fedora Package Reviews List
Depends On:
TreeView+ depends on / blocked
Reported: 2007-05-18 17:26 UTC by Mamoru TASAKA
Modified: 2007-11-30 22:12 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-05-22 02:55:03 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
hdegoede: fedora-review+
wtogami: fedora-cvs+

Attachments (Terms of Use)

Description Mamoru TASAKA 2007-05-18 17:26:29 UTC
Spec URL: http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SPECS/cmigemo.spec
SRPM URL: http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SRPMS/cmigemo-1.3-0.1.c_MIT.fc7.src.rpm
Mock build log on FC-devel i386: http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/LOGS/MOCK-cmigemo.log
C/Migemo is a C interface of Ruby/Migemo, a Japanese incremental search tool
by Romaji.

Comment 1 Mamoru TASAKA 2007-05-20 06:00:02 UTC

* Sun May 19 2007 Mamoru Tasaka <mtasaka@ioa.s.u-tokyo.ac.jp> - 1.3-0.2.c_MIT
- 64 bits fix

Comment 2 Hans de Goede 2007-05-20 13:20:21 UTC
* rpmlint output is:
W: cmigemo-devel no-documentation
* Package and spec file named appropriately
* Packaged according to packaging guidelines
* License ok
* spec file is legible and in Am. English.
* Source matches upstream (as explained in the comment)
* Compiles and builds on devel x86_64
* BR: ok
* No locales
* ldconfig run for shared libraries
* Not relocatable
* Package owns / or requires all dirs
* No duplicate files & Permissions
* %clean & macro usage OK
* Contains code and permissable content
* %doc does not affect runtime, and isn't large enough to warrent a sub package
* -devel package as needed
* no .desktop file needed

Must FIX
* Don't add tools/migemo.vim.dir sed command backup file to %doc

Comment 3 Mamoru TASAKA 2007-05-20 13:37:02 UTC
Thank you for initial comments.

(In reply to comment #2)
> Must FIX
> ========
> * Don't add tools/migemo.vim.dir sed command backup file to %doc



* Sun May 20 2007 Mamoru Tasaka <mtasaka@ioa.s.u-tokyo.ac.jp> - 1.3-0.3.c_MIT
- Don't create unnecessary document backup

Comment 4 Hans de Goede 2007-05-20 14:25:04 UTC
All Must fix items fixed: approved!

Comment 5 Mamoru TASAKA 2007-05-20 14:42:04 UTC
Thank you!

Request to CVS admin
New Package CVS Request
Package Name:         cmigemo
Short Description:    C interface of Ruby/Migemo Japanese incremental search tool
Owners:               mtasaka@ioa.s.u-tokyo.ac.jp
Branches:             devel F-7 FC-6 FC-5
InitialCC:            (nobody)

Comment 6 Mamoru TASAKA 2007-05-22 02:55:03 UTC
Rebuilt for all branch, closing.

Thank you for your review!!

Note You need to log in before you can comment on or make changes to this bug.