Spec URL: https://www.flyn.org/SRPMS/python-ana.spec SRPM URL: https://www.flyn.org/SRPMS/python-ana-0.06-23.fc43.src.rpm Description: Python module to provide easy distributed data storage Fedora Account System Username: mikep Maxwell G retired this package in August. My python-cooldict requires python-ana, so I am willing to maintain python-ana. I updated the earlier .spec file so that it makes use of the new Python macros.
Copr build: https://copr.fedorainfracloud.org/coprs/build/9725229 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2406063-python-ana/fedora-rawhide-x86_64/09725229-python-ana/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/python-ana Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> License: MIT License seems to be some BSD variant, not MIT? > URL: https://pypi.org/project/ana/ Use github url https://github.com/zardus/ana here, seems more useful. > BuildRequires: python3-devel > BuildRequires: python3-setuptools Move these to top level package (below BuildArch: noarch line) and consider to remove python3-setuptools, likely not needed. > %{?python_provide:%python_provide python3-%{pypi_name}} This is legacy cruft and should be removed now I think > Patch: https://github.com/zardus/ana/pull/17.patch Add line about what the patch does.
Spec URL: https://www.flyn.org/SRPMS/python-ana.spec SRPM URL: https://www.flyn.org/SRPMS/python-ana-0.06-23.fc43.src.rpm Description: Python module to provide easy distributed data storage Fedora Account System Username: mikep - Fix license, which seems to have been wrong for pre-retirement package. - Use GitHub URL. - Move BuildRequires, and remove unnecessary one. - Remove obsolete line. - Add comment to patch.
Created attachment 2111050 [details] The .spec file difference from Copr build 9725229 to 9737684
Copr build: https://copr.fedorainfracloud.org/coprs/build/9737684 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2406063-python-ana/fedora-rawhide-x86_64/09737684-python-ana/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/python-ana Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: Package must own all directories that it creates. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 5522 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate x file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [?]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-ana-0.06-23.fc44.noarch.rpm python-ana-0.06-23.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp_ddskdzz')] checks: 32, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 8 filtered, 0 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 4 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://files.pythonhosted.org/packages/source/a/ana/ana-0.06.tar.gz : CHECKSUM(SHA256) this package : 5fa16e511773a0efc6ac9294f93eee583612ffb580859737eed07e703947d6f8 CHECKSUM(SHA256) upstream package : 5fa16e511773a0efc6ac9294f93eee583612ffb580859737eed07e703947d6f8 Requires -------- python3-ana (rpmlib, GLIBC filtered): python(abi) Provides -------- python3-ana: python-ana python3-ana python3.14-ana python3.14dist(ana) python3dist(ana) Summary: Please consider to download from github site (using commit hash) to get the tests included in source tarball and perform them in %check section.
Spec URL: https://www.flyn.org/SRPMS/python-ana.spec SRPM URL: https://www.flyn.org/SRPMS/python-ana-0.06-23.20230801git7f3c0dd.fc43.src.rpm Description: Python module to provide easy distributed data storage Fedora Account System Username: mikep - Use newer commit to get tests. - Run tests. - Drop patch, which is included in newer commit.
Created attachment 2111067 [details] The .spec file difference from Copr build 9737684 to 9738205
Copr build: https://copr.fedorainfracloud.org/coprs/build/9738205 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2406063-python-ana/fedora-rawhide-x86_64/09738205-python-ana/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/python-ana Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Thanks, all good now, package is APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-ana