Spec URL: https://dcavalca.fedorapeople.org/review/crosswords-puzzle-sets-technopol/crosswords-puzzle-sets-technopol.spec SRPM URL: https://dcavalca.fedorapeople.org/review/crosswords-puzzle-sets-technopol/crosswords-puzzle-sets-technopol-0.1.0-1.fc44.src.rpm Description: This repo contains Polish puzzle set downloaders for GNOME Crosswords. The puzzles are pulled from TECHNOPOL and converted to ipuz format supported by Crosswords. Fedora Account System Username: dcavalca
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=138382180
There seems to be some problem with the following file. SRPM URL: https://dcavalca.fedorapeople.org/review/crosswords-puzzle-sets-technopol/crosswords-puzzle-sets-technopol-0.1.0-1.fc44.src.rpm Fetching it results in a 403 Forbidden error. Please make sure the URL is correct and publicly available. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
[fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/9725334 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2406066-crosswords-puzzle-sets-technopol/fedora-rawhide-x86_64/09725334-crosswords-puzzle-sets-technopol/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
LGTM, approved. Only issue seems to be that fedora-review's attempt to verify the source got thwarted by Anubis Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /home/michel/src/fedora/reviews/2406066-crosswords-puzzle-sets- technopol/diff.txt See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 15 files have unknown license. Detailed output of licensecheck in /home/michel/src/fedora/reviews/2406066-crosswords-puzzle-sets- technopol/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1090 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Bad spec filename: /home/michel/src/fedora/reviews/2406066-crosswords-puzzle-sets- technopol/srpm-unpacked/crosswords-puzzle-sets-technopol.spec See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: crosswords-puzzle-sets-technopol-0.1.0-1.fc44.noarch.rpm crosswords-puzzle-sets-technopol-0.1.0-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpyc1wwba4')] checks: 32, packages: 2 crosswords-puzzle-sets-technopol.noarch: E: spelling-error ('downloader', 'Summary(en_US) downloader -> downloaded, down loader, down-loader') crosswords-puzzle-sets-technopol.noarch: E: spelling-error repo', '%description -l en_US repo -> rope, rep, reps') crosswords-puzzle-sets-technopol.noarch: E: spelling-error ('downloaders', '%description -l en_US downloaders -> down loaders, down-loaders, downloads') crosswords-puzzle-sets-technopol.noarch: E: spelling-error ('ipuz', '%description -l en_US ipuz -> puzzle') crosswords-puzzle-sets-technopol.src: E: spelling-error ('downloader', 'Summary(en_US) downloader -> downloaded, down loader, down-loader') crosswords-puzzle-sets-technopol.src: E: spelling-error ('repo', '%description -l en_US repo -> rope, rep, reps') crosswords-puzzle-sets-technopol.src: E: spelling-error ('downloaders', '%description -l en_US downloaders -> down loaders, down-loaders, downloads') crosswords-puzzle-sets-technopol.src: E: spelling-error ('ipuz', '%description -l en_US ipuz -> puzzle') crosswords-puzzle-sets-technopol.noarch: W: no-manual-page-for-binary technopol-downloader 2 packages and 0 specfiles checked; 8 errors, 1 warnings, 7 filtered, 8 badness; has taken 0.1 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 crosswords-puzzle-sets-technopol.noarch: E: spelling-error ('downloader', 'Summary(en_US) downloader -> downloaded, down loader, down-loader') crosswords-puzzle-sets-technopol.noarch: E: spelling-error ('repo', '%description -l en_US repo -> rope, rep, reps') crosswords-puzzle-sets-technopol.noarch: E: spelling-error ('downloaders', '%description -l en_US downloaders -> down loaders, down-loaders, downloads') crosswords-puzzle-sets-technopol.noarch: E: spelling-error ('ipuz', '%description -l en_US ipuz -> puzzle') crosswords-puzzle-sets-technopol.noarch: W: no-manual-page-for-binary technopol-downloader 1 packages and 0 specfiles checked; 4 errors, 1 warnings, 3 filtered, 4 badness; has taken 0.0 s Source checksums ---------------- https://gitlab.gnome.org/miku/puzzle-sets-technopol/-/archive/0.1.0/puzzle-sets-technopol-0.1.0.tar.gz : CHECKSUM(SHA256) this package : e5701b164bf4f8fdf31c901bcbe5840c0628d1c009e664041411f7ea270558e9 CHECKSUM(SHA256) upstream package : e406d0bc029fb799db88d38fee8d945cc594423d0f889ec5221215399c3faaf7 diff -r also reports differences Requires -------- crosswords-puzzle-sets-technopol (rpmlib, GLIBC filtered): /usr/bin/python3 crosswords python3 python3dist(beautifulsoup4) python3dist(requests) Provides -------- crosswords-puzzle-sets-technopol: crosswords-puzzle-sets-technopol metainfo() metainfo(org.gnome.Crosswords.PuzzleSets.technopol.metainfo.xml) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2406066 Buildroot used: fedora-rawhide-aarch64 Active plugins: Shell-api, Generic Disabled plugins: Java, C/C++, Python, SugarActivity, Haskell, Perl, PHP, fonts, R, Ocaml Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
The Pagure repository was created at https://src.fedoraproject.org/rpms/crosswords-puzzle-sets-technopol
FEDORA-2025-ac21e1356c (crosswords-puzzle-sets-technopol-0.1.0-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2025-ac21e1356c
FEDORA-2025-16b249b108 (crosswords-puzzle-sets-technopol-0.1.0-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-16b249b108
FEDORA-2025-ac21e1356c (crosswords-puzzle-sets-technopol-0.1.0-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-318abbab44 (crosswords-puzzle-sets-technopol-0.1.0-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-318abbab44
FEDORA-2025-318abbab44 has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-318abbab44 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-318abbab44 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-16b249b108 has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-16b249b108 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-16b249b108 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-318abbab44 (crosswords-puzzle-sets-technopol-0.1.0-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-16b249b108 (crosswords-puzzle-sets-technopol-0.1.0-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.