SRPM URL: http://home.comcast.net/~ckweyl/perl-URI-Fetch-0.08-1.fc6.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-URI-Fetch.spec Description: URI::Fetch is a smart client for fetching HTTP pages, notably syndication feeds (RSS, Atom, and others), in an intelligent, bandwidth and time saving way.
Did you mean for t/ to be included in %doc?
Yep -- I'm finding tests make useful documentation (among other things), and generally think it's nice to be able to run the same test suite post-installation that a package was built with. This is a recent change of direction for me...
I think you also need a build dependency on Test::More, although I guess the tests are disabled by default so perhaps there's no point in that. I've no idea if you could have a conditional build dependency. I ran the tests manually and they ran fine. Review: * source files match upstream: e395289713e509a323fd1d44cfc58785a45e661a64ca3f9c7ff9a046105012a8 URI-Fetch-0.08.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper (perhaps Test::More if the tests were enabled) * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: perl(URI::Fetch) = 0.08 perl(URI::Fetch::Response) perl-URI-Fetch = 0.08-1.fc7 = perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Class::ErrorHandler) perl(Compress::Zlib) perl(LWP::UserAgent) perl(URI) perl(URI::Fetch::Response) perl(base) perl(constant) perl(strict) * %check is present, but tests are necessarily disabled. All tests pass when run manually: All tests successful. Files=3, Tests=88, 8 wallclock secs ( 0.30 cusr + 0.06 csys = 0.36 CPU) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED
I also packaged that locally and this is better than my packaging.
I'll add Test::More in wrapped in a conditional construct. It works if you're very careful with spacing, e.g. %{?foo:BuildRequires... not %{?foo: BuildRequires...
New Package CVS Request ======================= Package Name: perl-URI-Fetch Short Description: Smart URI fetching/caching Owners: cweyl.edu Branches: FC-5, FC-6, devel InitialCC: fedora-perl-devel-list
added FC-6 and F-7 branches (fc5 is now in maintenance mode)
Imported and building. Thanks for the review!