Fedora Account System
Red Hat Associate
Red Hat Customer
SPEC: https://pbrobinson.fedorapeople.org/python-pytest-json-report.spec SRPM: https://pbrobinson.fedorapeople.org/python-pytest-json-report-1.5.0-1.fc43.src.rpm Description: This pytest plugin creates test reports as JSON. This makes it easy to process test results in other applications. It can report a summary, test details, captured output, logs, exception tracebacks and more. Additionally, you can use the available fixtures and hooks to add metadata and customize the report as you like. FAS: pbrobinson Reproducible: Always
Copr build: https://copr.fedorainfracloud.org/coprs/build/9749100 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2407372-python-pytest-json-report/fedora-rawhide-x86_64/09749100-python-pytest-json-report/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Sources cannot be downloaded. Consider using: Source0: %url/archive/v%{version}/%{pypi_name}-v%{version}.tar.gz or get them from PyPI It seems that only the following requirments are needed to build: BuildRequires: python3-devel # Test requirements BuildRequires: python3dist(flaky) BuildRequires: python3dist(pytest-xdist) Some tests fail: https://koji.fedoraproject.org/koji/taskinfo?taskID=142796074
Updated: SPEC: https://pbrobinson.fedorapeople.org/python-pytest-json-report.spec SRPM: https://pbrobinson.fedorapeople.org/python-pytest-json-report-1.5.0-1.fc43.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=142942716
Copr build: https://copr.fedorainfracloud.org/coprs/build/10185524 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2407372-python-pytest-json-report/fedora-rawhide-x86_64/10185524-python-pytest-json-report/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Hey Benson, anything else needed here?
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License". 11 files have unknown license. Detailed output of licensecheck in /home/fedora-packaging-local/reviews/python-pytest-json- report/2407372-python-pytest-json-report/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.15/site- packages, /usr/lib/python3.15 [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 14716 bytes in 1 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-pytest-json-report-1.5.0-1.fc46.noarch.rpm python-pytest-json-report-1.5.0-1.fc46.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpydpx_kqc')] checks: 32, packages: 2 python-pytest-json-report.src: E: spelling-error ('tracebacks', '%description -l en_US tracebacks -> trace backs, trace-backs, racetracks') python3-pytest-json-report.noarch: E: spelling-error ('tracebacks', '%description -l en_US tracebacks -> trace backs, trace-backs, racetracks') 2 packages and 0 specfiles checked; 2 errors, 0 warnings, 7 filtered, 2 badness; has taken 0.6 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.10.0 configuration: /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 33, packages: 1 python3-pytest-json-report.noarch: E: spelling-error ('tracebacks', '%description -l en_US tracebacks -> trace backs, trace-backs, racetracks') 1 packages and 0 specfiles checked; 1 errors, 0 warnings, 3 filtered, 1 badness; has taken 0.1 s Source checksums ---------------- https://github.com/numirias/pytest-json-report/archive/v1.5.0/pytest-json-report-1.5.0.tar.gz : CHECKSUM(SHA256) this package : 8933f634c094e709e08c381796322e88b3cb699c4c63c3d9d789ad638d8d7cdb CHECKSUM(SHA256) upstream package : 8933f634c094e709e08c381796322e88b3cb699c4c63c3d9d789ad638d8d7cdb Requires -------- python3-pytest-json-report (rpmlib, GLIBC filtered): python(abi) python3.15dist(pytest) python3.15dist(pytest-metadata) Provides -------- python3-pytest-json-report: python-pytest-json-report python3-pytest-json-report python3.15-pytest-json-report python3.15dist(pytest-json-report) python3dist(pytest-json-report) Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -b 2407372 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Shell-api, Generic Disabled plugins: Ocaml, Java, Perl, R, PHP, C/C++, Haskell, fonts, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) License is duplicated: rpm -qL python3-pytest-json-report-1.5.0-1.fc46.noarch.rpm /usr/lib/python3.15/site-packages/pytest_json_report-1.5.0.dist-info/licenses/LICENSE /usr/share/licenses/python3-pytest-json-report/LICENSE Please remove %license LICENSE from the spec file. Please change %pyproject_save_files pytest_jsonreport to %pyproject_save_files -L pytest_jsonreport so that an error is raised if the license file is missing. b) Consider skipping the failing tests using: %if 0%{?with_tests} %check k="${k-}${k+ and }not test_report_keys[0]" k="${k-}${k+ and }not test_report_keys[1]" k="${k-}${k+ and }not test_report_keys[4]" k="${k-}${k+ and }not test_report_collectors[0]" k="${k-}${k+ and }not test_report_crash_and_traceback[0]" k="${k-}${k+ and }not test_report_crash_and_traceback[1]" k="${k-}${k+ and }not test_report_crash_and_traceback[4]" k="${k-}${k+ and }not test_record_property[0]" k="${k-}${k+ and }not test_json_metadata[0]" k="${k-}${k+ and }not test_json_metadata[1]" k="${k-}${k+ and }not test_json_metadata[4]" k="${k-}${k+ and }not test_environment_via_metadata_plugin[0]" k="${k-}${k+ and }not test_environment_via_metadata_plugin[1]" k="${k-}${k+ and }not test_environment_via_metadata_plugin[4]" k="${k-}${k+ and }not test_warnings[0]" k="${k-}${k+ and }not test_warnings[1]" k="${k-}${k+ and }not test_warnings[4]" %pytest -k "${k-}" %endif perhaps also report these upstream. c) Please implement (a) before import. Consider implementing (b). Approved.
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pytest-json-report Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`
FEDORA-2026-13bf8c8db1 (python-pytest-json-report-1.5.0-1.fc45) has been submitted as an update to Fedora 45. https://bodhi.fedoraproject.org/updates/FEDORA-2026-13bf8c8db1
Thanks Benson, Just a note, these comments should be at the top of the review where they're easy to see, I missed them in the first pass in among the generated output. > Comments: > a) License is duplicated: > rpm -qL python3-pytest-json-report-1.5.0-1.fc46.noarch.rpm > /usr/lib/python3.15/site-packages/pytest_json_report-1.5.0.dist-info/ > licenses/LICENSE > /usr/share/licenses/python3-pytest-json-report/LICENSE > > Please remove > %license LICENSE > > from the spec file. > > Please change > %pyproject_save_files pytest_jsonreport > > to > > %pyproject_save_files -L pytest_jsonreport > > so that an error is raised if the license file is missing. I've never seen that before. Will update > b) Consider skipping the failing tests using: > > %if 0%{?with_tests} > %check > k="${k-}${k+ and }not test_report_keys[0]" > k="${k-}${k+ and }not test_report_keys[1]" > k="${k-}${k+ and }not test_report_keys[4]" > k="${k-}${k+ and }not test_report_collectors[0]" > k="${k-}${k+ and }not test_report_crash_and_traceback[0]" > k="${k-}${k+ and }not test_report_crash_and_traceback[1]" > k="${k-}${k+ and }not test_report_crash_and_traceback[4]" > k="${k-}${k+ and }not test_record_property[0]" > k="${k-}${k+ and }not test_json_metadata[0]" > k="${k-}${k+ and }not test_json_metadata[1]" > k="${k-}${k+ and }not test_json_metadata[4]" > k="${k-}${k+ and }not test_environment_via_metadata_plugin[0]" > k="${k-}${k+ and }not test_environment_via_metadata_plugin[1]" > k="${k-}${k+ and }not test_environment_via_metadata_plugin[4]" > k="${k-}${k+ and }not test_warnings[0]" > k="${k-}${k+ and }not test_warnings[1]" > k="${k-}${k+ and }not test_warnings[4]" > %pytest -k "${k-}" > %endif > > perhaps also report these upstream. > > c) Please implement (a) before import. Consider implementing (b). Approved.
> %pyproject_save_files -L pytest_jsonreport > > so that an error is raised if the license file is missing. AFAICT from the docs the above statement is incorrect, it should be a lower case l, to copy paste from https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_build_macros: The macro has these options: -l: Declare that a missing license should terminate the build. Packagers are encouraged to use this flag when the %license file is not manually listed in %files to avoid accidentally losing the file in a future version. -L: Explicitly disable the check for a missing license file. When the %license file is manually listed in %files, packagers can use this flag to ensure future compatibility in case the -l behavior eventually becomes a default.
FEDORA-2026-398d43a280 has been pushed to the Fedora 45 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-398d43a280` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-398d43a280 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-398d43a280 (python-pytest-json-report-1.5.0-2.fc45) has been pushed to the Fedora 45 stable repository. If problem still persists, please make note of it in this bug report.