Spec URL: https://github.com/ykshek/dlib-copr-specs/raw/refs/heads/main/dlib.spec SRPM URL: https://github.com/ykshek/dlib-copr-specs/raw/refs/heads/main/dlib-20.0-1.fc43.src.rpm Description: Dlib is a modern C++ toolkit containing machine learning algorithms and tools for creating complex software in C++ to solve real world problems. See http://dlib.net for the main project documentation and API reference. Fedora Account System Username: starfish A build is done in the COPR https://copr.fedorainfracloud.org/coprs/starfish/howdy-beta/package/dlib/
Cannot find any valid SRPM URL for this ticket. Common causes are: - You didn't specify `SRPM URL: ...` in the ticket description or any of your comments - The URL schema isn't HTTP or HTTPS - The SRPM package linked in your URL doesn't match the package name specified in the ticket summary --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Note that this packages was previously included in Fedora but was retired due to lack of maintenance (failed to build): https://src.fedoraproject.org/rpms/dlib
[fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/9762673 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2408803-dlib/fedora-rawhide-x86_64/09762673-dlib/fedora-review/review.txt Found issues: - dlib-doc : /usr/share/doc/dlib-doc/examples/dnn_instance_segmentation_ex.h dlib-doc : /usr/share/doc/dlib-doc/examples/dnn_semantic_segmentation_ex.h dlib-doc : /usr/share/doc/dlib-doc/examples/pascal_voc_2012.h dlib-doc : /usr/share/doc/dlib-doc/examples/resnet.h dlib-doc : /usr/share/doc/dlib-doc/examples/slm_data.h dlib-doc : /usr/share/doc/dlib-doc/examples/slm_defs.h Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages - License file license.xml is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/dlib Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Header files in -devel subpackage, if present. Note: dlib-doc : /usr/share/doc/dlib- doc/examples/dnn_instance_segmentation_ex.h dlib-doc : /usr/share/doc/dlib-doc/examples/dnn_semantic_segmentation_ex.h dlib-doc : /usr/share/doc/dlib-doc/examples/pascal_voc_2012.h dlib-doc : /usr/share/doc/dlib-doc/examples/resnet.h dlib-doc : /usr/share/doc/dlib- doc/examples/slm_data.h dlib-doc : /usr/share/doc/dlib- doc/examples/slm_defs.h See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages - Package contains BR: python2-devel or python3-devel - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file license.xml is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/dlib See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Boost Software License 1.0", "*No copyright* Boost Software License and/or Public domain", "*No copyright* Boost Software License", "Boost Software License", "Boost Software License 1.0", "BSD 3-Clause License", "Boost Software License and/or Public domain", "Boost Software License and/or NTP License", "NTP License", "libpng License", "zlib License". 930 files have unknown license. Detailed output of licensecheck in /home/fedora-packaging/reviews/dlib/2408803-dlib/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/python3.14/site- packages, /usr/lib64/python3.14 [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 3384 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-dlib [ ]: Package functions as described. [x]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: dlib-20.0-1.fc44.x86_64.rpm dlib-devel-20.0-1.fc44.x86_64.rpm python3-dlib-20.0-1.fc44.x86_64.rpm dlib-doc-20.0-1.fc44.noarch.rpm dlib-20.0-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpqezyesaq')] checks: 32, packages: 5 dlib.x86_64: W: no-documentation dlib-devel.x86_64: W: no-documentation dlib-doc.noarch: W: files-duplicate /usr/share/doc/dlib-doc/examples/johns/John_Shimkus/000378_03227610.jpg /usr/share/doc/dlib-doc/examples/johns/John_Shimkus/000378_02340151.jpg dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/string/cassert /usr/include/dlib/bits/c++config.h dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/string/iomanip /usr/include/dlib/bits/c++config.h dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/string/iosfwd /usr/include/dlib/bits/c++config.h dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/string/iostream /usr/include/dlib/bits/c++config.h dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/string/locale /usr/include/dlib/bits/c++config.h dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/examples/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/CMakeFiles/CMakeDirectoryInformation.cmake dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/examples/examples_build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/gui/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/CMakeFiles/CMakeDirectoryInformation.cmake dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/gui/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/examples/CMakeFiles/CMakeDirectoryInformation.cmake dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/gui/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/gui/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/examples/examples_build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/tools/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/CMakeFiles/CMakeDirectoryInformation.cmake dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/tools/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/examples/CMakeFiles/CMakeDirectoryInformation.cmake dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/tools/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/gui/CMakeFiles/CMakeDirectoryInformation.cmake dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/tools/convert_dlib_nets_to_caffe_build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/tools/convert_dlib_nets_to_caffe_build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/examples/examples_build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/tools/convert_dlib_nets_to_caffe_build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/gui/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/tools/htmlify_build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/tools/htmlify_build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/examples/examples_build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/tools/htmlify_build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/gui/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/tools/htmlify_build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/tools/convert_dlib_nets_to_caffe_build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/tools/imglab_build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/tools/imglab_build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/examples/examples_build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/tools/imglab_build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/gui/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/tools/imglab_build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/tools/convert_dlib_nets_to_caffe_build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/tools/imglab_build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/tools/htmlify_build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake 5 packages and 0 specfiles checked; 0 errors, 29 warnings, 26 filtered, 0 badness; has taken 5.5 s Rpmlint (debuginfo) ------------------- Checking: dlib-debuginfo-20.0-1.fc44.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpdrx_frmt')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 1.1 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 5 dlib-devel.x86_64: W: no-documentation dlib.x86_64: W: no-documentation dlib-doc.noarch: W: files-duplicate /usr/share/doc/dlib-doc/examples/johns/John_Shimkus/000378_03227610.jpg /usr/share/doc/dlib-doc/examples/johns/John_Shimkus/000378_02340151.jpg dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/string/cassert /usr/include/dlib/bits/c++config.h dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/string/iomanip /usr/include/dlib/bits/c++config.h dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/string/iosfwd /usr/include/dlib/bits/c++config.h dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/string/iostream /usr/include/dlib/bits/c++config.h dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/string/locale /usr/include/dlib/bits/c++config.h dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/examples/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/CMakeFiles/CMakeDirectoryInformation.cmake dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/examples/examples_build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/gui/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/CMakeFiles/CMakeDirectoryInformation.cmake dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/gui/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/examples/CMakeFiles/CMakeDirectoryInformation.cmake dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/gui/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/gui/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/examples/examples_build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/tools/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/CMakeFiles/CMakeDirectoryInformation.cmake dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/tools/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/examples/CMakeFiles/CMakeDirectoryInformation.cmake dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/tools/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/gui/CMakeFiles/CMakeDirectoryInformation.cmake dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/tools/convert_dlib_nets_to_caffe_build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/tools/convert_dlib_nets_to_caffe_build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/examples/examples_build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/tools/convert_dlib_nets_to_caffe_build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/gui/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/tools/htmlify_build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/tools/htmlify_build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/examples/examples_build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/tools/htmlify_build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/gui/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/tools/htmlify_build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/tools/convert_dlib_nets_to_caffe_build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/tools/imglab_build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/tools/imglab_build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/examples/examples_build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/tools/imglab_build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/gui/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/tools/imglab_build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/tools/convert_dlib_nets_to_caffe_build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake dlib-devel.x86_64: W: cross-directory-hard-link /usr/include/dlib/test/redhat-linux-build/tools/imglab_build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake /usr/include/dlib/test/redhat-linux-build/tools/htmlify_build/dlib_build/CMakeFiles/CMakeDirectoryInformation.cmake 5 packages and 0 specfiles checked; 0 errors, 29 warnings, 28 filtered, 0 badness; has taken 3.3 s Unversioned so-files -------------------- python3-dlib: /usr/lib64/python3.14/site-packages/_dlib_pybind11.cpython-314-x86_64-linux-gnu.so Source checksums ---------------- https://github.com/davisking/dlib/archive/v20.0/dlib-20.0.tar.gz : CHECKSUM(SHA256) this package : 705749801c7896f5c19c253b6be639f4cef2c1831a9606955f01b600b3d86d80 CHECKSUM(SHA256) upstream package : 705749801c7896f5c19c253b6be639f4cef2c1831a9606955f01b600b3d86d80 Requires -------- dlib (rpmlib, GLIBC filtered): libX11.so.6()(64bit) libc.so.6()(64bit) libflexiblas.so.3()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgcc_s.so.1(GCC_4.0.0)(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEGTURBO_6.2)(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) libjxl.so.0.11()(64bit) libjxl.so.0.11(JXL_0)(64bit) libjxl_threads.so.0.11()(64bit) libjxl_threads.so.0.11(JXL_0)(64bit) libm.so.6()(64bit) libpng16.so.16()(64bit) libpng16.so.16(PNG16_0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libwebp.so.7()(64bit) rtld(GNU_HASH) dlib-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config cmake-filesystem(x86-64) dlib(x86-64) libdlib.so.20.0.0()(64bit) python3-dlib (rpmlib, GLIBC filtered): libX11.so.6()(64bit) libc.so.6()(64bit) libflexiblas.so.3()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgcc_s.so.1(GCC_4.0.0)(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) libjxl.so.0.11()(64bit) libjxl.so.0.11(JXL_0)(64bit) libjxl_threads.so.0.11()(64bit) libjxl_threads.so.0.11(JXL_0)(64bit) libm.so.6()(64bit) libpng16.so.16()(64bit) libpng16.so.16(PNG16_0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libwebp.so.7()(64bit) python(abi) rtld(GNU_HASH) dlib-doc (rpmlib, GLIBC filtered): dlib Provides -------- dlib: dlib dlib(x86-64) libdlib.so.20.0.0()(64bit) dlib-devel: cmake(dlib) dlib-devel dlib-devel(x86-64) pkgconfig(dlib-1) python3-dlib: python-dlib python3-dlib python3-dlib(x86-64) python3.14-dlib python3.14dist(dlib) python3dist(dlib) dlib-doc: dlib-doc Diff spec file in url and in SRPM --------------------------------- --- /home/fedora-packaging/reviews/dlib/2408803-dlib/srpm/dlib.spec 2025-11-07 15:29:23.735240462 +0300 +++ /home/fedora-packaging/reviews/dlib/2408803-dlib/srpm-unpacked/dlib.spec 2025-10-31 03:00:00.000000000 +0300 @@ -13,6 +13,8 @@ URL: http://dlib.net Source: %forgesource +# Fix build issue with GCC 15 +Patch1: https://github.com/davisking/dlib/pull/3067.patch # Fix build issue with Python 3.14 -Patch: https://github.com/davisking/dlib/pull/3098.patch +Patch2: https://github.com/davisking/dlib/pull/3098.patch BuildRequires: boost-devel @@ -92,5 +94,11 @@ %prep -%forgeautosetup -p1 +%forgeautosetup -N +# Add patches +%if 0%{?fedora} < 43 +%autopatch 1 -vp1 +%else +%autopatch 2 -vp1 +%endif find docs -type f -exec chmod 644 {} + @@ -116,4 +124,5 @@ + %build # dlib requires `libjxl_cms` provided by libjxl >= 0.10` currently only Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2408803 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, C/C++, Generic, Shell-api Disabled plugins: Perl, R, Haskell, fonts, Ocaml, PHP, SugarActivity, Java Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Please list additional license from: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2408803-dlib/fedora-rawhide-x86_64/09762673-dlib/fedora-review/licensecheck.txt if bundled and used in the final output. If none of Kiss_fft, libjpeg, libpng, zlib are used in the build, can they be removed in the prep stage? If they are used, could what is packaged in Fedora be used instead? b) Please use Pybind11 from Fedora repositories c) Please remove external/cblas in prep stage to ensure it is not accidentally used in the build d) Please add: Requires: python3-libs to the Python package to ensure all directories are owned e) Can the Python GUI be built? f) Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=140447946 g) Can you file a bug report upstream about test failures on s390x - it should be possible to do a build on copr h) The Python build seems to rebuild the entire dlib library rather than linking to the already built shared library. Is it possible to just make the bindings and link to the already built shared library?
Hi, thank you for the package review! Regarding the comments: e) There is a test for the GUI during the build, so I guess it can be assumed to be built if it passes? It does seem to pass, at least on non s390x. g) The s390x issue used to be tracked here(https://github.com/davisking/dlib/issues/2947) and the fix is merged. It seems that the previous maintainer decided to just disable s390x and probably never got around to fixing it, and upstream seems to be saying they are unable to debug it? Unfortunately I don't really know how to fix it, and I doubt upstream wants to do that given the project owner says "But I don't know if anyone is using it on s390x. Maybe the tests are just overly tight numerically?" (https://github.com/davisking/dlib/issues/2947#issuecomment-2081475292). h) I don't know how to do this. I assume this isn't something I can just add to the spec file? The rest of the corrections are done in the updated spec file and srpm here: Spec URL: https://github.com/ykshek/dlib-copr-specs/raw/refs/heads/fedora-review/dlib.spec SRPM URL: https://github.com/ykshek/dlib-copr-specs/raw/refs/heads/fedora-review/dlib-20.0-1.fc43.src.rpm A test build is done here: https://copr.fedorainfracloud.org/coprs/starfish/dlib/build/9957347/
Created attachment 2120395 [details] The .spec file difference from Copr build 9762673 to 9957586
Copr build: https://copr.fedorainfracloud.org/coprs/build/9957586 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2408803-dlib/fedora-rawhide-x86_64/09957586-dlib/fedora-review/review.txt Found issues: - dlib-doc : /usr/share/doc/dlib-doc/examples/dnn_instance_segmentation_ex.h dlib-doc : /usr/share/doc/dlib-doc/examples/dnn_semantic_segmentation_ex.h dlib-doc : /usr/share/doc/dlib-doc/examples/pascal_voc_2012.h dlib-doc : /usr/share/doc/dlib-doc/examples/resnet.h dlib-doc : /usr/share/doc/dlib-doc/examples/slm_data.h dlib-doc : /usr/share/doc/dlib-doc/examples/slm_defs.h Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages - License file license.xml is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text - Not a valid SPDX expression 'BSL-1.0 AND Zlib AND libpng AND NTP'. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/dlib Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.