Bug 2411848 - Missing '{' in /etc/profile.d/atuin.sh affecting non-bash users (FIX)
Summary: Missing '{' in /etc/profile.d/atuin.sh affecting non-bash users (FIX)
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: atuin
Version: 43
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
Assignee: Cristian Le
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2025-11-02 13:24 UTC by Bruce Jerrick
Modified: 2025-11-07 17:03 UTC (History)
3 users (show)

Fixed In Version: atuin-18.6.1-5.fc44
Clone Of:
Environment:
Last Closed: 2025-11-07 17:03:43 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Bruce Jerrick 2025-11-02 13:24:14 UTC
Description of problem:
A missing '{' in /etc/profile.d/atuin.sh will cause the zsh-specific section
to run for any non-bash shell.

Version-Release number of selected component:
atuin-all-users-18.6.1-2.fc43.noarch.rpm
Bug also exists in other releases.

How reproducible:
100% for non-bash users.
Not hit for bash users.

The bug can be seen by inspection of line 12 of /etc/profile.d/atuin.sh :

      ...
   3  # Check for bash environment
   4  if [ -n "${BASH_VERSION-}" ]; then
      ...
  11  # Check for zsh environment
  12  elif [ -n "$ZSH_VERSION-}" ]; then    ### should be "${ZSH_VERSION-}"
      ...

Actual results:
That expansion on line 12 will always result in "-}", and the test will
always evaluate to true.

Expected results:
For non-zsh, the expansion should be blank, the test should be false.
For zsh, the expansion should be "5.9", the test should be true.

Additional info:
Note that the 'elif' is reached only in a non-bash shell.

Comment 1 Cristian Le 2025-11-03 09:55:58 UTC
This is embarrassing, I did fix it previously, but I accidentally reverted it when I updated it, I'll get a fix asap

Comment 2 Fedora Update System 2025-11-07 13:54:11 UTC
FEDORA-2025-d8887a60b5 (atuin-18.6.1-5.fc44) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-d8887a60b5

Comment 3 Fedora Update System 2025-11-07 17:03:43 UTC
FEDORA-2025-d8887a60b5 (atuin-18.6.1-5.fc44) has been pushed to the Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.