Spec URL: https://farchord.fedorapeople.org/reviews/JKQtPlotter/JKQtPlotter.spec SRPM URL: https://farchord.fedorapeople.org/reviews/JKQtPlotter/JKQtPlotter-4.0.3^20251013.050100.d243218-1.fc43.src.rpm Description: An extensive Qt5 & Qt6 Plotter framework (including a feature-rich plotter widget, a speed-optimized, but limited variant and a LaTeX equation renderer!), written fully in C/C++ and without external dependencies. Fedora Account System Username: farchord
This is a pre-release of 5.0.0 and Version/Release/Source tags are not correct, you are not using rpmautospec (https://fedora-infra.github.io/rpmautospec-docs/) code --> %global gitcommit d243218119b1632987df26baea0d4bc6ccdee533 %global gitdate 20251013 %global shortcommit %(c=%{gitcommit}; echo ${c:0:7}) ... Version: 5.0.0 Release: %autorelease -p -s %{gitdate}git%{shortcommit} ... Source0: %{url}/archive/%{gitcommit}/JKQtPlotter-%{gitcommit}.tar.gz ... %changelog %autochangelog <--- code BuildRequires against gcc, gcc-c++ are missing. There is a license not listed: $ licensecheck ./lib/jkqtmathtext/resources/firaMath/LICENSE ./lib/jkqtmathtext/resources/firaMath/LICENSE: SIL Open Font License 1.1 Looks like build flags are not used; add %set_build_flags before %cmake There are still many rpaths defined, try to use `-DCMAKE_SKIP_RPATH:BOOL=ON` with %cmake
Spec URL: https://farchord.fedorapeople.org/reviews/JKQtPlotter/JKQtPlotter.spec SRPM URL: https://farchord.fedorapeople.org/reviews/JKQtPlotter/JKQtPlotter-5.0.0~20251013.050100.d243218-1.fc43.src.rpm Fixed versioning, licensing
Also added gcc and gcc-c++ The spec doesn't have rpmautospec, not sure why you are seeing it? as far as %set_build_flags that's no longer necessary and is already added by default since F36. Oh and I forgot the extra build flag, gonna fix that now.
Spec URL: https://farchord.fedorapeople.org/reviews/JKQtPlotter/JKQtPlotter.spec SRPM URL: https://farchord.fedorapeople.org/reviews/JKQtPlotter/JKQtPlotter-5.0.0~20251013.050100.d243218-1.fc43.src.rpm Added additional build flag
Copr build: https://copr.fedorainfracloud.org/coprs/build/9788419 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2413958-jkqtplotter/fedora-rawhide-x86_64/09788419-JKQtPlotter/fedora-review/review.txt Found issues: - License file JKQTMathText6_FIRAMATH_LICENSE is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Created attachment 2114022 [details] The .spec file difference from Copr build 9788419 to 9788421
Copr build: https://copr.fedorainfracloud.org/coprs/build/9788421 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2413958-jkqtplotter/fedora-rawhide-x86_64/09788421-JKQtPlotter/fedora-review/review.txt Found issues: - License file JKQTMathText6_FIRAMATH_LICENSE is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Yeah that license is a duplicate from the other one I added.
(In reply to Steve Cossette from comment #3) > Also added gcc and gcc-c++ > > The spec doesn't have rpmautospec, not sure why you are seeing it? Don't you want to use rpmautospec? Why? You are still using not correct release tag (pre-release must be numbered with the form "0.N" where N is an integer beginning with 1) See https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_prerelease_versions I advise you to use the form "<date>git<revision>" where <revision> is a shortcommit number to avoid overly long version numbers;
Sorry, I've been busy in the last couple days. I'll look into this asap. As far as the beta versioning goes, I guess we do those versions differently for KDE packages then but ya ill modify it to fit.
Spec URL: https://farchord.fedorapeople.org/reviews/JKQtPlotter/JKQtPlotter.spec SRPM URL: https://farchord.fedorapeople.org/reviews/JKQtPlotter/JKQtPlotter-5.0.0~20251013gitd243218-0.1.fc43.src.rpm Updated versioning scheme (Hopefully properly)
Hopefully this is done properly. I'm not used to doing it this way, let me know!
Created attachment 2114631 [details] The .spec file difference from Copr build 9788421 to 9801947
Copr build: https://copr.fedorainfracloud.org/coprs/build/9801947 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2413958-jkqtplotter/fedora-rawhide-x86_64/09801947-JKQtPlotter/fedora-review/review.txt Found issues: - License file JKQTMathText6_FIRAMATH_LICENSE is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Please, mark JKQTMathText6_FIRAMATH_LICENSE file with %license tag and move lib/jkqtmathtext/resources/firaMath/LICENSE in main package Version and Release are still not correct. "Version" is the 5.0.0 "Release" indicates the pre-release commit of the future 5.0.0 version See https://bugzilla.redhat.com/show_bug.cgi?id=2413958#c1 %check section is missing: %check export LD_LIBRARY_PATH=%{buildroot}%{_libdir} %ctest As you can see, all libraries are named as *_Debug.so*; use `-DCMAKE_BUILD_TYPE:STRING=Release` to get no-debug files. Please, move %{_bindir}/test_jkqtpdatastore in devel sub-package Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file JKQTMathText6_FIRAMATH_LICENSE is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Lesser General Public License, Version 2.1", "GNU Lesser General Public License v2.1 or later", "GNU Lesser General Public License v3.0 or later", "SIL Open Font License 1.1", "GNU General Public License", "SIL Open Font License", "*No copyright* SIL Open Font License 1.1 with Reserved Font Name", "*No copyright* SIL Open Font License". 2859 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/JKQtPlotter/licensecheck.txt [!]: License file installed when any subpackage combination is installed. [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 12264 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: JKQtPlotter-5.0.0~20251013gitd243218-0.1.fc44.x86_64.rpm JKQtPlotter-devel-5.0.0~20251013gitd243218-0.1.fc44.x86_64.rpm JKQtPlotter-doc-5.0.0~20251013gitd243218-0.1.fc44.x86_64.rpm JKQtPlotter-5.0.0~20251013gitd243218-0.1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp8oe9k2ab')] checks: 32, packages: 4 JKQtPlotter.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/JKQtPlotter/README.md JKQtPlotter.src: E: spelling-error ('renderer', '%description -l en_US renderer -> tenderer, rendered, render') JKQtPlotter.x86_64: E: spelling-error ('renderer', '%description -l en_US renderer -> tenderer, rendered, render') JKQtPlotter.spec: W: specfile-warning sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory JKQtPlotter.x86_64: W: no-manual-page-for-binary JKQTPCSSParser_test JKQtPlotter.x86_64: W: no-manual-page-for-binary JKQTPDataCache_benchmark JKQtPlotter.x86_64: W: no-manual-page-for-binary JKQTPDataCache_test JKQtPlotter.x86_64: W: no-manual-page-for-binary JKQTPStringTools_test JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtmathtext_render JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtplot_test JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtplotter_doc_imagegenerator JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtpstatisticstools_test JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_advplotstyling JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_barchart JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_barchart_customdrawfunctor JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_barchart_errorbars JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_barchart_functorfill JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_barchart_twocolor JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_boxplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_contourplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_datastore JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_datastore_groupedstat JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_datastore_iterators JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_datastore_regression JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_datastore_statistics JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_datastore_statistics_2d JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_dateaxes JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_distributionplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_errorbarstyles JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_evalcurve JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_filledgraphs JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_filledgraphs_errors JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_financialgraphs JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_functionplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_geo_arrows JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_geo_bezier JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_geo_coordinateaxis0 JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_geo_simple JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_geometric JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_graphlabels JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_imageplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_imageplot_cimg JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_imageplot_modifier JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_imageplot_nodatastore JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_imageplot_opencv JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_imageplot_userpal JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_impulsesplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_jkqtfastplotter_test JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_jkqtmathtext_simpletest JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_jkqtmathtext_test JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_logaxes JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_mandelbrot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_multiplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_multithreaded JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_parametriccurve JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_paramscatterplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_paramscatterplot_customsymbol JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_paramscatterplot_image JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_paramvectorfield JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_parsedfunctionplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_rgbimageplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_rgbimageplot_cimg JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_rgbimageplot_opencv JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_rgbimageplot_qt JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_scatter JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_scatter_customsymbol JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_second_axis JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_simpletest JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_speed JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_stackedbars JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_stepplots JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_styledboxplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_styling JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_symbols_and_errors JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_symbols_and_styles JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_ui JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_ui_bind_scrollbar JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_user_interaction JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_vectorfield JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_violinplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_wiggleplots JKQtPlotter.x86_64: W: no-manual-page-for-binary test_jkqtpdatastore JKQtPlotter-devel.x86_64: W: no-documentation JKQtPlotter-doc.x86_64: E: no-binary JKQtPlotter.spec: W: no-%check-section JKQtPlotter.x86_64: E: incorrect-fsf-address /usr/share/licenses/JKQtPlotter/LICENSE JKQtPlotter-doc.x86_64: E: incorrect-fsf-address /usr/share/doc/JKQTPlotter/LICENSE JKQtPlotter-doc.x86_64: W: files-duplicate /usr/share/licenses/JKQtPlotter-doc/LICENSE /usr/share/doc/JKQTPlotter/JKQTMathText6_FIRAMATH_LICENSE 4 packages and 0 specfiles checked; 5 errors, 83 warnings, 125 filtered, 5 badness; has taken 4.5 s Rpmlint (debuginfo) ------------------- Checking: JKQtPlotter-debuginfo-5.0.0~20251013gitd243218-0.1.fc44.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpsng5dm63')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 174 filtered, 0 badness; has taken 5.7 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "JKQtPlotter-doc". (none): E: there is no installed rpm "JKQtPlotter-debuginfo". (none): E: there is no installed rpm "JKQtPlotter-devel". (none): E: there is no installed rpm "JKQtPlotter". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/jkriege2/JKQtPlotter/archive/d243218119b1632987df26baea0d4bc6ccdee533.tar.gz : CHECKSUM(SHA256) this package : 1a5cd3e84493f969bfaea5e761e28b128b978cb8a18df8c83240f39922e82825 CHECKSUM(SHA256) upstream package : 1a5cd3e84493f969bfaea5e761e28b128b978cb8a18df8c83240f39922e82825 Requires -------- JKQtPlotter (rpmlib, GLIBC filtered): glibc libJKQTCommon6_Debug.so.5.0.0()(64bit) libJKQTFastPlotter6_Debug.so.5.0.0()(64bit) libJKQTMath6_Debug.so.5.0.0()(64bit) libJKQTMathText6_Debug.so.5.0.0()(64bit) libJKQTPlotter6_Debug.so.5.0.0()(64bit) libQt6Core.so.6()(64bit) libQt6Core.so.6(Qt_6)(64bit) libQt6Core.so.6(Qt_6.10)(64bit) libQt6Gui.so.6()(64bit) libQt6Gui.so.6(Qt_6)(64bit) libQt6OpenGLWidgets.so.6()(64bit) libQt6OpenGLWidgets.so.6(Qt_6)(64bit) libQt6PrintSupport.so.6()(64bit) libQt6PrintSupport.so.6(Qt_6)(64bit) libQt6Svg.so.6()(64bit) libQt6Svg.so.6(Qt_6)(64bit) libQt6Test.so.6()(64bit) libQt6Test.so.6(Qt_6)(64bit) libQt6Widgets.so.6()(64bit) libQt6Widgets.so.6(Qt_6)(64bit) libQt6Xml.so.6()(64bit) libQt6Xml.so.6(Qt_6)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libopencv_core.so.411()(64bit) libopencv_imgcodecs.so.411()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.7)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) JKQtPlotter-devel (rpmlib, GLIBC filtered): JKQtPlotter(x86-64) cmake-filesystem(x86-64) libJKQTCommon6_Debug.so.5.0.0()(64bit) libJKQTFastPlotter6_Debug.so.5.0.0()(64bit) libJKQTMath6_Debug.so.5.0.0()(64bit) libJKQTMathText6_Debug.so.5.0.0()(64bit) libJKQTPlotter6_Debug.so.5.0.0()(64bit) JKQtPlotter-doc (rpmlib, GLIBC filtered): Provides -------- JKQtPlotter: JKQtPlotter JKQtPlotter(x86-64) libJKQTCommon6_Debug.so.5.0.0()(64bit) libJKQTFastPlotter6_Debug.so.5.0.0()(64bit) libJKQTMath6_Debug.so.5.0.0()(64bit) libJKQTMathText6_Debug.so.5.0.0()(64bit) libJKQTPlotter6_Debug.so.5.0.0()(64bit) JKQtPlotter-devel: JKQtPlotter-devel JKQtPlotter-devel(x86-64) cmake(JKQTCommon6) cmake(JKQTFastPlotter6) cmake(JKQTMath6) cmake(JKQTMathText6) cmake(JKQTPlotter6) cmake(jkqtcommon6) cmake(jkqtfastplotter6) cmake(jkqtmath6) cmake(jkqtmathtext6) cmake(jkqtplotter6) JKQtPlotter-doc: JKQtPlotter-doc JKQtPlotter-doc(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name JKQtPlotter --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: fonts, SugarActivity, Java, Perl, Haskell, R, Ocaml, PHP, Python Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Spec URL: https://farchord.fedorapeople.org/reviews/JKQtPlotter/JKQtPlotter.spec SRPM URL: https://farchord.fedorapeople.org/reviews/JKQtPlotter/JKQtPlotter-5.0.0-0.1.20251013gitd243218.fc44.src.rpm Ended up converting to rpmautospec, mainly to speed up this review. Seems that fbrnch does not like rpmautospec, along with a couple other things not working the same with rpmautospec *sigh* But anyway, that's done. Also tagged extra licenses, one of which wasn't found by the script, but I added it anyway. I added tests, and set the build to release. Disabled one test that crashes on execution.
Package approved. Please, see the reported issue Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Lesser General Public License, Version 2.1", "GNU Lesser General Public License v2.1 or later", "GNU Lesser General Public License v3.0 or later", "SIL Open Font License 1.1", "GNU General Public License", "SIL Open Font License", "*No copyright* SIL Open Font License 1.1 with Reserved Font Name", "*No copyright* SIL Open Font License". 2859 files have unknown license. Detailed output of licensecheck in /home/sagitter/2413958-JKQtPlotter/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 12264 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: JKQtPlotter-5.0.0-0.1.20251013gitd243218.fc44.x86_64.rpm JKQtPlotter-devel-5.0.0-0.1.20251013gitd243218.fc44.x86_64.rpm JKQtPlotter-doc-5.0.0-0.1.20251013gitd243218.fc44.x86_64.rpm JKQtPlotter-5.0.0-0.1.20251013gitd243218.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp8z26c2ad')] checks: 32, packages: 4 JKQtPlotter.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/JKQtPlotter/README.md JKQtPlotter.src: E: spelling-error ('renderer', '%description -l en_US renderer -> tenderer, rendered, render er') JKQtPlotter.x86_64: E: spelling-error ('renderer', '%description -l en_US renderer -> tenderer, rendered, render er') JKQtPlotter.x86_64: W: no-manual-page-for-binary JKQTPCSSParser_test JKQtPlotter.x86_64: W: no-manual-page-for-binary JKQTPDataCache_benchmark JKQtPlotter.x86_64: W: no-manual-page-for-binary JKQTPDataCache_test JKQtPlotter.x86_64: W: no-manual-page-for-binary JKQTPStringTools_test JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtmathtext_render JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtplot_test JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtplotter_doc_imagegenerator JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtpstatisticstools_test JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_advplotstyling JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_barchart JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_barchart_customdrawfunctor JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_barchart_errorbars JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_barchart_functorfill JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_barchart_twocolor JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_boxplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_contourplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_datastore JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_datastore_groupedstat JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_datastore_iterators JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_datastore_regression JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_datastore_statistics JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_datastore_statistics_2d JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_dateaxes JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_distributionplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_errorbarstyles JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_evalcurve JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_filledgraphs JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_filledgraphs_errors JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_financialgraphs JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_functionplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_geo_arrows JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_geo_bezier JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_geo_coordinateaxis0 JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_geo_simple JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_geometric JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_graphlabels JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_imageplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_imageplot_cimg JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_imageplot_modifier JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_imageplot_nodatastore JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_imageplot_opencv JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_imageplot_userpal JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_impulsesplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_jkqtfastplotter_test JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_jkqtmathtext_simpletest JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_jkqtmathtext_test JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_logaxes JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_mandelbrot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_multiplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_multithreaded JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_parametriccurve JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_paramscatterplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_paramscatterplot_customsymbol JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_paramscatterplot_image JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_paramvectorfield JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_parsedfunctionplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_rgbimageplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_rgbimageplot_cimg JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_rgbimageplot_opencv JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_rgbimageplot_qt JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_scatter JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_scatter_customsymbol JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_second_axis JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_simpletest JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_speed JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_stackedbars JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_stepplots JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_styledboxplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_styling JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_symbols_and_errors JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_symbols_and_styles JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_ui JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_ui_bind_scrollbar JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_user_interaction JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_vectorfield JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_violinplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_wiggleplots JKQtPlotter-devel.x86_64: W: no-manual-page-for-binary test_jkqtpdatastore JKQtPlotter-devel.x86_64: W: no-documentation JKQtPlotter-doc.x86_64: E: no-binary JKQtPlotter-doc.x86_64: E: incorrect-fsf-address /usr/share/doc/JKQTPlotter/LICENSE 4 packages and 0 specfiles checked; 4 errors, 80 warnings, 125 filtered, 4 badness; has taken 5.0 s Rpmlint (debuginfo) ------------------- Checking: JKQtPlotter-devel-debuginfo-5.0.0-0.1.20251013gitd243218.fc44.x86_64.rpm JKQtPlotter-debuginfo-5.0.0-0.1.20251013gitd243218.fc44.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmplejlekq_')] checks: 32, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 178 filtered, 0 badness; has taken 5.7 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 5 JKQtPlotter.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/JKQtPlotter/README.md JKQtPlotter.x86_64: E: spelling-error ('renderer', '%description -l en_US renderer -> tenderer, rendered, render') JKQtPlotter-devel.x86_64: W: no-manual-page-for-binary test_jkqtpdatastore JKQtPlotter.x86_64: W: no-manual-page-for-binary JKQTPCSSParser_test JKQtPlotter.x86_64: W: no-manual-page-for-binary JKQTPDataCache_benchmark JKQtPlotter.x86_64: W: no-manual-page-for-binary JKQTPDataCache_test JKQtPlotter.x86_64: W: no-manual-page-for-binary JKQTPStringTools_test JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtmathtext_render JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtplot_test JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtplotter_doc_imagegenerator JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtpstatisticstools_test JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_advplotstyling JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_barchart JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_barchart_customdrawfunctor JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_barchart_errorbars JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_barchart_functorfill JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_barchart_twocolor JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_boxplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_contourplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_datastore JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_datastore_groupedstat JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_datastore_iterators JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_datastore_regression JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_datastore_statistics JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_datastore_statistics_2d JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_dateaxes JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_distributionplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_errorbarstyles JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_evalcurve JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_filledgraphs JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_filledgraphs_errors JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_financialgraphs JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_functionplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_geo_arrows JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_geo_bezier JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_geo_coordinateaxis0 JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_geo_simple JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_geometric JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_graphlabels JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_imageplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_imageplot_cimg JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_imageplot_modifier JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_imageplot_nodatastore JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_imageplot_opencv JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_imageplot_userpal JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_impulsesplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_jkqtfastplotter_test JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_jkqtmathtext_simpletest JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_jkqtmathtext_test JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_logaxes JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_mandelbrot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_multiplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_multithreaded JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_parametriccurve JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_paramscatterplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_paramscatterplot_customsymbol JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_paramscatterplot_image JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_paramvectorfield JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_parsedfunctionplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_rgbimageplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_rgbimageplot_cimg JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_rgbimageplot_opencv JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_rgbimageplot_qt JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_scatter JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_scatter_customsymbol JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_second_axis JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_simpletest JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_speed JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_stackedbars JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_stepplots JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_styledboxplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_styling JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_symbols_and_errors JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_symbols_and_styles JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_ui JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_ui_bind_scrollbar JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_user_interaction JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_vectorfield JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_violinplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_wiggleplots JKQtPlotter-devel.x86_64: W: no-documentation JKQtPlotter-doc.x86_64: E: no-binary JKQtPlotter-doc.x86_64: E: incorrect-fsf-address /usr/share/doc/JKQTPlotter/LICENSE 5 packages and 0 specfiles checked; 3 errors, 80 warnings, 382 filtered, 3 badness; has taken 14.3 s Source checksums ---------------- https://github.com/jkriege2/JKQtPlotter/archive/d243218119b1632987df26baea0d4bc6ccdee533.tar.gz : CHECKSUM(SHA256) this package : 1a5cd3e84493f969bfaea5e761e28b128b978cb8a18df8c83240f39922e82825 CHECKSUM(SHA256) upstream package : 1a5cd3e84493f969bfaea5e761e28b128b978cb8a18df8c83240f39922e82825 Requires -------- JKQtPlotter (rpmlib, GLIBC filtered): glibc libJKQTCommon6_Release.so.5.0.0()(64bit) libJKQTFastPlotter6_Release.so.5.0.0()(64bit) libJKQTMath6_Release.so.5.0.0()(64bit) libJKQTMathText6_Release.so.5.0.0()(64bit) libJKQTPlotter6_Release.so.5.0.0()(64bit) libQt6Core.so.6()(64bit) libQt6Core.so.6(Qt_6)(64bit) libQt6Core.so.6(Qt_6.10)(64bit) libQt6Gui.so.6()(64bit) libQt6Gui.so.6(Qt_6)(64bit) libQt6OpenGLWidgets.so.6()(64bit) libQt6OpenGLWidgets.so.6(Qt_6)(64bit) libQt6PrintSupport.so.6()(64bit) libQt6PrintSupport.so.6(Qt_6)(64bit) libQt6Svg.so.6()(64bit) libQt6Svg.so.6(Qt_6)(64bit) libQt6Test.so.6()(64bit) libQt6Test.so.6(Qt_6)(64bit) libQt6Widgets.so.6()(64bit) libQt6Widgets.so.6(Qt_6)(64bit) libQt6Xml.so.6()(64bit) libQt6Xml.so.6(Qt_6)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libopencv_core.so.411()(64bit) libopencv_imgcodecs.so.411()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.7)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) JKQtPlotter-devel (rpmlib, GLIBC filtered): JKQtPlotter(x86-64) cmake-filesystem(x86-64) libJKQTCommon6_Release.so.5.0.0()(64bit) libJKQTFastPlotter6_Release.so.5.0.0()(64bit) libJKQTMath6_Release.so.5.0.0()(64bit) libJKQTMathText6_Release.so.5.0.0()(64bit) libJKQTPlotter6_Release.so.5.0.0()(64bit) libQt6Core.so.6()(64bit) libQt6Core.so.6(Qt_6)(64bit) libQt6Core.so.6(Qt_6.10)(64bit) libQt6Test.so.6()(64bit) libQt6Test.so.6(Qt_6)(64bit) libQt6Widgets.so.6()(64bit) libQt6Widgets.so.6(Qt_6)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) JKQtPlotter-doc (rpmlib, GLIBC filtered): Provides -------- JKQtPlotter: JKQtPlotter JKQtPlotter(x86-64) libJKQTCommon6_Release.so.5.0.0()(64bit) libJKQTFastPlotter6_Release.so.5.0.0()(64bit) libJKQTMath6_Release.so.5.0.0()(64bit) libJKQTMathText6_Release.so.5.0.0()(64bit) libJKQTPlotter6_Release.so.5.0.0()(64bit) JKQtPlotter-devel: JKQtPlotter-devel JKQtPlotter-devel(x86-64) cmake(JKQTCommon6) cmake(JKQTFastPlotter6) cmake(JKQTMath6) cmake(JKQTMathText6) cmake(JKQTPlotter6) cmake(jkqtcommon6) cmake(jkqtfastplotter6) cmake(jkqtmath6) cmake(jkqtmathtext6) cmake(jkqtplotter6) JKQtPlotter-doc: JKQtPlotter-doc JKQtPlotter-doc(x86-64) Diff spec file in url and in SRPM --------------------------------- --- /home/sagitter/2413958-JKQtPlotter/srpm/JKQtPlotter.spec 2025-11-17 21:53:39.354689087 +0100 +++ /home/sagitter/2413958-JKQtPlotter/srpm-unpacked/JKQtPlotter.spec 2025-11-17 01:00:00.000000000 +0100 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.8.3) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + %global gitcommit d243218119b1632987df26baea0d4bc6ccdee533 %global gitdate 20251013 @@ -89,3 +99,6 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Mon Nov 17 2025 John Doe <packager> - 5.0.0-0.1.20251013gitd243218 +- Uncommitted changes +## END: Generated by rpmautospec Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 2413958 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: Perl, Python, Haskell, fonts, PHP, Java, Ocaml, R, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Yeah that error is "normal" -- that happens when you use rpmautospec with reviews. When you srpm it, it adds some stuff in the spec. I had this issue happen in the past, one of the reasons why I don't like rpmautospec. But thanks for the review!
Thank you for the review, Antonio
The Pagure repository was created at https://src.fedoraproject.org/rpms/JKQtPlotter
FEDORA-2025-5e5602b192 (JKQtPlotter-5.0.0-0.1.20251013gitd243218.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2025-5e5602b192
FEDORA-2025-5e5602b192 (JKQtPlotter-5.0.0-0.1.20251013gitd243218.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.