Spec URL: https://decathorpe.fedorapeople.org/cargo-rpm-macros.spec SRPM URL: https://decathorpe.fedorapeople.org/cargo-rpm-macros-28.0-1.fc43.src.rpm Description: RPM macros and generators for building Rust packages with cargo. Fedora Account System Username: decathorpe
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=138846425
Note: This is a rename-request for "rust-packaging". This follows the upstream project being renamed, which I did to avoid conflicting with the Rust packaging guidelines, which reserve the "rust-" prefix for source package names for Rust crates from crates.io (which this project is not, it's just RPM macros and generators). Also, the name change only affects the *source package*, the actual built packages have *not* changed, so no Obsoletes and Provides are necessary (the built packages were, and still are, cargo-rpm-macros and rust-srpm-macros).
Copr build: https://copr.fedorainfracloud.org/coprs/build/9793041 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2414530-cargo-rpm-macros/fedora-rawhide-x86_64/09793041-cargo-rpm-macros/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
(In reply to Fabio Valentini from comment #2) > Note: This is a rename-request for "rust-packaging". > > This follows the upstream project being renamed, which I did to avoid > conflicting with the Rust packaging guidelines, which reserve the "rust-" > prefix for source package names for Rust crates from crates.io (which this > project is not, it's just RPM macros and generators). > For what it's worth, this *was* intentional. But it's probably fine. > Also, the name change only affects the *source package*, the actual built > packages have *not* changed, so no Obsoletes and Provides are necessary (the > built packages were, and still are, cargo-rpm-macros and rust-srpm-macros). We need "Provides: rust-packaging" or we're going to have a problem even between RHEL and Fedora.
Sorry, I mean we cannot ever remove the "Provides: rust-packaging" because of RHEL.
> For what it's worth, this *was* intentional. But it's probably fine. I am not aware of the history here, but I don't see a reason for it *now*? > We need "Provides: rust-packaging" or we're going to have a problem even between RHEL and Fedora. > Sorry, I mean we cannot ever remove the "Provides: rust-packaging" because of RHEL. I'm not sure this is the case? The RPM tooling for Rust packages is in "rust-toolset" in RHEL, which is built from the "rust" source package. Neither are related to the "rust-packaging" name. There are still hundreds of Fedora packages that use "BuildRequires: rust-packaging" though, just because they were generated by a version of rust2rpm that didn't yet use the new package name. So the Provides won't go away until all those are regenerated with recent rust2rpm and use "BR: cargo-rpm-macros" instead. So for both your points, I would need actionable information before I can adapt this package.
(In reply to Fabio Valentini from comment #6) > > For what it's worth, this *was* intentional. But it's probably fine. > > I am not aware of the history here, but I don't see a reason for it *now*? > It was intentionally named specifically so that it would always be co-owned by the Rust SIG. > > We need "Provides: rust-packaging" or we're going to have a problem even between RHEL and Fedora. > > Sorry, I mean we cannot ever remove the "Provides: rust-packaging" because of RHEL. > > I'm not sure this is the case? The RPM tooling for Rust packages is in > "rust-toolset" in RHEL, which is built from the "rust" source package. > Neither are related to the "rust-packaging" name. > > There are still hundreds of Fedora packages that use "BuildRequires: > rust-packaging" though, just because they were generated by a version of > rust2rpm that didn't yet use the new package name. So the Provides won't go > away until all those are regenerated with recent rust2rpm and use "BR: > cargo-rpm-macros" instead. > > So for both your points, I would need actionable information before I can > adapt this package. Mmm. I just think it's probably not worth dropping the Provides until after at least EL9 is EOL.
> It was intentionally named specifically so that it would always be co-owned by the Rust SIG. I intend to give @rust-sig the same control over the new package that it currently has over rust-packaging. > Mmm. I just think it's probably not worth dropping the Provides until after at least EL9 is EOL. Probably.
Review notes: * Package builds and installs * Package follows Fedora packaging guidelines * Package licensing is correct and license data is installed * No serious issues from rpmlint PACKAGE APPROVED.
Thank you for the review!
The Pagure repository was created at https://src.fedoraproject.org/rpms/cargo-rpm-macros
FEDORA-2025-214a17a055 (cargo2rpm-0.3.0-1.fc44, cargo-rpm-macros-28.0-1.fc44, and 1 more) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2025-214a17a055
FEDORA-2025-214a17a055 (cargo2rpm-0.3.0-1.fc44, cargo-rpm-macros-28.0-1.fc44, and 1 more) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.