Created attachment 2114505 [details] Configuration file for rust2rpm Spec URL: https://music.fedorapeople.org/rust-astral-reqwest-middleware.spec SRPM URL: https://music.fedorapeople.org/rust-astral-reqwest-middleware-0.7.0-1.fc43.src.rpm Description: Wrapper around reqwest to allow for client middleware chains. Fedora Account System Username: music Astral has published their fork of reqwest-middleware to crates.io. This will soon be a dependency for uv. This package is almost identical to https://src.fedoraproject.org/rpms/rust-reqwest-middleware; see https://diff.rs/reqwest-middleware/0.7.0/astral-reqwest-middleware/0.7.0/Cargo.toml/. The spec file was generated by rust2rpm with no modifications and with the attached config file.
Correction for copy-pasting errors: Spec URL: https://music.fedorapeople.org/rust-astral-reqwest-middleware.spec SRPM URL: https://music.fedorapeople.org/rust-astral-reqwest-middleware-0.4.2-1.fc43.src.rpm https://diff.rs/reqwest-middleware/0.4.2/astral-reqwest-middleware/0.4.2/Cargo.toml/
There seems to be some problem with the following file. SRPM URL: https://music.fedorapeople.org/rust-astral-reqwest-middleware-0.7.0-1.fc43.src.rpm Fetching it results in a 404 Not Found error. Please make sure the URL is correct and publicly available. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/9801935 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2415168-rust-astral-reqwest-middleware/fedora-rawhide-x86_64/09801935-rust-astral-reqwest-middleware/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
fedora-review stops at: --> SRPM url: https://music.fedorapeople.org/rust-astral-reqwest-middleware-0.7.0-1.fc43.src.rpm INFO: --> Spec url: https://music.fedorapeople.org/rust-astral-reqwest-middleware.spec INFO: Using review directory: /export/home/trosten/fedora/review/2415168-rust-astral-reqwest-middleware INFO: Downloading .spec and .srpm files ERROR: 'Error HTTP Error 404: Not Found downloading https://music.fedorapeople.org/rust-astral-reqwest-middleware-0.7.0-1.fc43.src.rpm' Confused by comments of Fedora Review service? Can you repost spec and srpm urls?
The original URLs are wrong, but those from https://bugzilla.redhat.com/show_bug.cgi?id=2415168#c1 should be correct: Spec URL: https://music.fedorapeople.org/rust-astral-reqwest-middleware.spec SRPM URL: https://music.fedorapeople.org/rust-astral-reqwest-middleware-0.4.2-1.fc43.src.rpm The fedora-review service therefore did succeed in https://bugzilla.redhat.com/show_bug.cgi?id=2415168#c4. I can reproduce "fedora-review -b 2415168" picking up the wrong SPRM URL, though. Maybe this comment will fix that.
Yes, now "fedora-review -b 2415168" does the right thing. Weird.
Copr build: https://copr.fedorainfracloud.org/coprs/build/9826887 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2415168-rust-astral-reqwest-middleware/fedora-rawhide-x86_64/09826887-rust-astral-reqwest-middleware/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/astral- reqwest-middleware-0.4.2/CHANGELOG.md See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files Harmless, ignored ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rust-astral-reqwest-middleware-devel-0.4.2-1.fc44.noarch.rpm rust-astral-reqwest-middleware+default-devel-0.4.2-1.fc44.noarch.rpm rust-astral-reqwest-middleware+charset-devel-0.4.2-1.fc44.noarch.rpm rust-astral-reqwest-middleware+http2-devel-0.4.2-1.fc44.noarch.rpm rust-astral-reqwest-middleware+json-devel-0.4.2-1.fc44.noarch.rpm rust-astral-reqwest-middleware+multipart-devel-0.4.2-1.fc44.noarch.rpm rust-astral-reqwest-middleware+rustls-tls-devel-0.4.2-1.fc44.noarch.rpm rust-astral-reqwest-middleware-0.4.2-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 8 8 packages and 0 specfiles checked; 0 errors, 0 warnings, 43 filtered, 0 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 7 7 packages and 0 specfiles checked; 0 errors, 0 warnings, 39 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://crates.io/api/v1/crates/astral-reqwest-middleware/0.4.2/download#/astral-reqwest-middleware-0.4.2.crate : CHECKSUM(SHA256) this package : 638d02e24aeb92f9537897cd1ff82e2bc98fd9ac9575a503e27bb07cdf64d4d7 CHECKSUM(SHA256) upstream package : 638d02e24aeb92f9537897cd1ff82e2bc98fd9ac9575a503e27bb07cdf64d4d7 Requires -------- rust-astral-reqwest-middleware-devel (rpmlib, GLIBC filtered): (crate(anyhow/default) >= 1.0.0 with crate(anyhow/default) < 2.0.0~) (crate(async-trait/default) >= 0.1.51 with crate(async-trait/default) < 0.2.0~) (crate(http/default) >= 1.0.0 with crate(http/default) < 2.0.0~) (crate(reqwest) >= 0.12.0 with crate(reqwest) < 0.13.0~) (crate(serde/default) >= 1.0.106 with crate(serde/default) < 2.0.0~) (crate(thiserror/default) >= 2.0.0 with crate(thiserror/default) < 3.0.0~) (crate(tower-service/default) >= 0.3.0 with crate(tower-service/default) < 0.4.0~) cargo rust-astral-reqwest-middleware+default-devel (rpmlib, GLIBC filtered): cargo crate(astral-reqwest-middleware) rust-astral-reqwest-middleware+charset-devel (rpmlib, GLIBC filtered): (crate(reqwest/charset) >= 0.12.0 with crate(reqwest/charset) < 0.13.0~) cargo crate(astral-reqwest-middleware) rust-astral-reqwest-middleware+http2-devel (rpmlib, GLIBC filtered): (crate(reqwest/http2) >= 0.12.0 with crate(reqwest/http2) < 0.13.0~) cargo crate(astral-reqwest-middleware) rust-astral-reqwest-middleware+json-devel (rpmlib, GLIBC filtered): (crate(reqwest/json) >= 0.12.0 with crate(reqwest/json) < 0.13.0~) cargo crate(astral-reqwest-middleware) rust-astral-reqwest-middleware+multipart-devel (rpmlib, GLIBC filtered): (crate(reqwest/multipart) >= 0.12.0 with crate(reqwest/multipart) < 0.13.0~) cargo crate(astral-reqwest-middleware) rust-astral-reqwest-middleware+rustls-tls-devel (rpmlib, GLIBC filtered): (crate(reqwest/rustls-tls) >= 0.12.0 with crate(reqwest/rustls-tls) < 0.13.0~) cargo crate(astral-reqwest-middleware) Provides -------- rust-astral-reqwest-middleware-devel: crate(astral-reqwest-middleware) rust-astral-reqwest-middleware-devel rust-astral-reqwest-middleware+default-devel: crate(astral-reqwest-middleware/default) rust-astral-reqwest-middleware+default-devel rust-astral-reqwest-middleware+charset-devel: crate(astral-reqwest-middleware/charset) rust-astral-reqwest-middleware+charset-devel rust-astral-reqwest-middleware+http2-devel: crate(astral-reqwest-middleware/http2) rust-astral-reqwest-middleware+http2-devel rust-astral-reqwest-middleware+json-devel: crate(astral-reqwest-middleware/json) rust-astral-reqwest-middleware+json-devel rust-astral-reqwest-middleware+multipart-devel: crate(astral-reqwest-middleware/multipart) rust-astral-reqwest-middleware+multipart-devel rust-astral-reqwest-middleware+rustls-tls-devel: crate(astral-reqwest-middleware/rustls-tls) rust-astral-reqwest-middleware+rustls-tls-devel Summary ========= all good, package is APPROVED.
Thank you for yet another very helpful review! https://release-monitoring.org/project/387240/
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-astral-reqwest-middleware
FEDORA-2025-59b885061d (rust-astral-reqwest-middleware-0.4.2-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2025-59b885061d
FEDORA-2025-59b885061d (rust-astral-reqwest-middleware-0.4.2-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.