Spec URL: http://folk.ntnu.no/sindrb/packages/telepathy-mission-control.spec SRPM URL: http://folk.ntnu.no/sindrb/packages/telepathy-mission-control-4.22-1.fc7.src.rpm Description: Mission Control, or MC, is a Telepathy component providing a way for "end-user" applications to abstract some of the details of connection managers, to provide a simple way to manipulate a bunch of connection managers at once, and to remove the need to have in each program the account definitions and credentials.
*** Bug 241791 has been marked as a duplicate of this bug. ***
I'd be happy to review this and empathy. Mock's grabbing some build roots now; and I'll post a full review shortly. Thanks.
The spec looks quite sane, but I can't get it to build in mock (development/x86_64): generating symbol list for `libmissioncontrol-config.la' /usr/bin/nm -B .libs/libmissioncontrol_config_la-mc.o .libs/libmissioncontrol_config_la-mc-manager.o .libs/libmissioncontrol_config_la-mc-protocol.o .libs/libmissioncontrol_config_la-mc-profile.o .libs/libmissioncontrol_config_la-mc-account.o .libs/libmissioncontrol_config_la-mc-account-monitor.o .libs/libmissioncontrol_config_la-mc-enum-types.o | sed -n -e 's/^.*[ ]\([ABCDGIRSTW][ABCDGIRSTW]*\)[ ][ ]*\([_A-Za-z][_A-Za-z0-9]*\)$/\1 \2 \2/p' | /bin/sed 's/.* //' | sort | uniq > .libs/libmissioncontrol-config.exp /bin/grep -E -e "^mc_" ".libs/libmissioncontrol-config.exp" > ".libs/libmissioncontrol-config.expT" mv -f ".libs/libmissioncontrol-config.expT" ".libs/libmissioncontrol-config.exp" echo "{ global:" > .libs/libmissioncontrol-config.ver cat .libs/libmissioncontrol-config.exp | sed -e "s/\(.*\)/\1;/" >> .libs/libmissioncontrol-config.ver echo "local: *; };" >> .libs/libmissioncontrol-config.ver gcc -shared .libs/libmissioncontrol_config_la-mc.o .libs/libmissioncontrol_config_la-mc-manager.o .libs/libmissioncontrol_config_la-mc-protocol.o .libs/libmissioncontrol_config_la-mc-profile.o .libs/libmissioncontrol_config_la-mc-account.o .libs/libmissioncontrol_config_la-mc-account-monitor.o .libs/libmissioncontrol_config_la-mc-enum-types.o -lgconf-2 -lORBit-2 -lgthread-2.0 -lrt -L/lib64 -ldbus-glib-1 -ldbus-1 -lgobject-2.0 -lglib-2.0 -pthread -m64 -mtune=generic -pthread -Wl,-soname -Wl,libmissioncontrol-config.so.0 -Wl,-version-script -Wl,.libs/libmissioncontrol-config.ver -o .libs/libmissioncontrol-config.so.0.0.0 /usr/bin/ld: cannot find -lgthread-2.0 collect2: ld returned 1 exit status make[3]: *** [libmissioncontrol-config.la] Error 1 make[3]: Leaving directory `/builddir/build/BUILD/telepathy-mission-control-4.22/libmissioncontrol' make[2]: *** [all] Error 2 make[2]: Leaving directory `/builddir/build/BUILD/telepathy-mission-control-4.22/libmissioncontrol' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/builddir/build/BUILD/telepathy-mission-control-4.22' make: *** [all] Error 2 error: Bad exit status from /var/tmp/rpm-tmp.99829 (%build) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.99829 (%build) Error building package from telepathy-mission-control-4.22-1.fc8.src.rpm, See build log ending At first it looked like a simply missing library dependency, so I tried adding gib2-devel to the BuildRequires but it still gives me the same error. (Odd though - it works through a non-chrooted rpmbuild invocation...)
MD5Sums: aa8a8264c596c666f886f85356b56e09 telepathy-mission-control-4.22.tar.gz Good: * Source URL is canonical * Upstream source tarball verified * Package name conforms to the Fedora Naming Guidelines * Group Tag is from the official list * Buildroot has all required elements * All paths begin with macros * All necessary BuildRequires listed. * All desired features are enabled * Make succeeds even when %{_smp_mflags} is defined * Files have appropriate permissions and owners * Builds fine in mock for devel-i386. see attached build log. * rpmlint produces no errors. * package installs cleanly on F7. Bad: * Missing requires on libtelepathy-devel, dbus-devel, and dbus-glib-devel for the -devel subpackage. To help finding requires necessary for the -devel subpackage in the future try doing something like this: LANG=C grep 'include ' `rpm -ql telepathy-mission-control-devel` | grep -v Binary | sed -e 's|^.*:||' | sed -e 's|^[ \t][ \t]*||' | sort | uniq or this: rpm -ql telepathy-mission-control-devel | grep '/usr/lib/pkgconfig/.*.pc' | xargs cat | grep Requires +1 APPROVED, fix the requires on the -devel package before importing into CVS.
Created attachment 155984 [details] Mock build log for telepathy-mission-control
New Package CVS Request ======================= Package Name: telepathy-mission-control Short Description: Central control for Telepathy connection manager Owners: foolish Branches: F-7 FC-6 InitialCC: david
cvs done
Package Change Request ====================== Package Name: telepathy-mission-control New Branches: EL-6 Owners: pbrobinson sdz
cvs done.