SRPM URL: http://home.comcast.net/~ckweyl/perl-HTML-Tidy-1.08-1.fc6.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-HTML-Tidy.spec Description: HTML::Tidy is an HTML checker in a handy dandy object. It's meant as a replacement for HTML::Lint. If you're currently an HTML::Lint user looking to migrate, see the section "Converting from HTML::Lint".
Not assigning to myself because I (still) think that including the test suite code in the main package is not a good idea, but here's some notes: make test fails at least in a devel x86_64 mach buildroot, and apparently for someone else too: http://rt.cpan.org/Public/Bug/Display.html?id=26875 "validation" is misleading in Summary; tidy is not a validator. "checking" and/or "cleanup" would be more accurate. Cosmetic: could use perl in %prep for all in-place edits - now there's one sed.
I get 403: Forbidden when trying to fetch the package, and there's been no reply to the existing commentary. Setting NEEDINFO.
So it seems that Chris is back. Chris, did you want to move forward with this package as well?
Ok, updated packages posted: http://fedora.biggerontheinside.net/review/perl-HTML-Tidy.spec http://fedora.biggerontheinside.net/review/perl-HTML-Tidy-1.08-2.fc8.src.rpm These packages build cleanly against the updated libtidy (yes, it was updated a while ago :)) and in F-8 mock.
Hi Chris, The package looks good to me, the only thing is that the webtidy script needs a dependency on LWP::Simple. Checklist: * source matches upstream: 7912a2a739c6e2cfb6b409fb30b5047e18285dad HTML-Tidy-1.08.tar.gz * package is properly named according to the naming guidelines * specfile is properly named, is cleanly written and uses macros consistently. * summaries are OK. * descriptions are OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds fine in mock * package installs properly * rpmlint has no complaints. * final provides and requires are sane: [ruben@odin SPECS]$ rpm -q --provides perl-HTML-Tidy Tidy.so perl(HTML::Tidy) = 1.08 perl(HTML::Tidy::Message) perl-HTML-Tidy = 1.08-2.fc8 [ruben@odin SPECS]$ rpm -q --requires perl-HTML-Tidy /usr/bin/perl libc.so.6 libc.so.6(GLIBC_2.1.3) libtidy-0.99.so.0 perl >= 0:5.006001 perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Getopt::Long) perl(HTML::Tidy) perl(HTML::Tidy::Message) perl(XSLoader) perl(base) perl(constant) perl(strict) perl(warnings) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies) <= 3.0.3-1 rtld(GNU_HASH) * %check is present and succeeds * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * documentation is small, so no -doc subpackage is necessary. APPROVED
Thanks for the review! I'll add the dep on LWP::Simple prior to building.
New Package CVS Request ======================= Package Name: perl-HTML-Tidy Short Description: (X)HTML cleanup in a Perl object Owners: cweyl Branches: F-7, F-8, devel InitialCC: perl-sig
cvs done.
Chris, can you please import the package?
*blush* Imported and building for rawhide.
Package Change Request ====================== Package Name: dspam Short Description: (X)HTML cleanup in a Perl object New Branches: EL-5 Owners: gnat InitialCC: perl-sig
Branch request acked and approved. Enjoy! :)
Did you mean perl-HTML-Tidy here?
ah yes sorry. totally meant perl-HTML-Tidy