Spec URL: https://download.copr.fedorainfracloud.org/results/r0x0d/rust-cliclack/fedora-rawhide-x86_64/09824575-rust-cliclack/rust-cliclack.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/r0x0d/rust-cliclack/fedora-rawhide-x86_64/09824575-rust-cliclack/rust-cliclack-0.3.6-1.20251121130003991996.main.fc44.src.rpm Description: Beautiful, minimal, opinionated CLI prompts inspired by the Clack NPM package. Fedora Account System Username: r0x0d
Copr build: https://copr.fedorainfracloud.org/coprs/build/9826892 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2416340-rust-cliclack/fedora-rawhide-x86_64/09826892-rust-cliclack/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Why is Release set to such strange value?
Hm. That's a good point, @terjeros. I don't remember if this one I did by running copr build locally, or if I used the packit automation. In any case, let me do it again.
Ah, that's it! @terjeros! Packit is modifying the release bit like this. Let me see if I can disable that behavior.
Spec URL: https://download.copr.fedorainfracloud.org/results/r0x0d/rust-cliclack/fedora-rawhide-x86_64/09835813-rust-cliclack/rust-cliclack.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/r0x0d/rust-cliclack/fedora-rawhide-x86_64/09835813-rust-cliclack/rust-cliclack-0.3.6-1.fc44.src.rpm
Created attachment 2116167 [details] The .spec file difference from Copr build 9826892 to 9835822
Copr build: https://copr.fedorainfracloud.org/coprs/build/9835822 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2416340-rust-cliclack/fedora-rawhide-x86_64/09835822-rust-cliclack/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> Source: cliclack-0.3.6.crate Should be Source: %{crates_source} > %autosetup -n cliclack-0.3.6 -p1 Should be: %autosetup -n %{crate}-%{version} -p1
@terjeros, I see packit[1] is causing more trouble than helping in this review. The original specfile can be found here https://raw.githubusercontent.com/r0x0d/rust-cliclack/refs/heads/main/rust-cliclack.spec, in that, you can see that it has the points you mention. I think packit expands the macros in the specfile when it submits to COPR and that's why you are seeing it without the macros. I'm so sorry that it feels confusing at this point. [1]: https://packit.dev/
Ok, I see, better to use links to pre generated spec file then.
In general: Don't use packit for Rust crates. The way packit works (without doing a bunch of custom configuration) is incompatible with Rust crate packages.
The URLs are now returning HTTP 404 errors. Did the COPR builds expire? Please reupload the .spec and SRPM files in a more stable location.
Hi, Fabio! Sure. I think the builds expired. I will retake this work in a couple of days, still finishing other priority work first. Thanks for the feedback.
Spec URL: https://download.copr.fedorainfracloud.org/results/r0x0d/rust-cliclack/fedora-43-x86_64/10034777-rust-cliclack/rust-cliclack.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/r0x0d/rust-cliclack/fedora-rawhide-x86_64/10034777-rust-cliclack/rust-cliclack-0.3.7-1.fc44.src.rpm Up to date specfile/srpm build.
Ugh. This is the specfile for the rawhide build https://download.copr.fedorainfracloud.org/results/r0x0d/rust-cliclack/fedora-rawhide-x86_64/10034777-rust-cliclack/rust-cliclack.spec. :facepalm:
Copr build: https://copr.fedorainfracloud.org/coprs/build/10035987 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2416340-rust-cliclack/fedora-rawhide-x86_64/10035987-rust-cliclack/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Looks mostly OK, two minor issues: 1) Contains media files in media/* that looks like images that are embedded in README when rendered to HTML. It would make sense to exclude those from the built packages (and possibly even upstream, from published crates). 2) You must use "rust2rpm -p" to edit the contents of Cargo.toml. The final contents of Cargo.toml must be known to generate correct .spec files, so edits *cannot* be made manually with tools like sed or tomcli (unless you *really really* know what you're doing).
Spec URL: https://download.copr.fedorainfracloud.org/results/r0x0d/rust-cliclack/fedora-43-x86_64/10047386-rust-cliclack/rust-cliclack.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/r0x0d/rust-cliclack/fedora-43-x86_64/10047386-rust-cliclack/rust-cliclack-0.3.7-1.fc43.src.rpm For some reason, COPR haven't uploaded my rawhide specfile/srpm ¯\_(ツ)_/¯ but the builds passed for both: https://copr.fedorainfracloud.org/coprs/r0x0d/rust-cliclack/build/10047386/.
Created attachment 2123251 [details] The .spec file difference from Copr build 10035987 to 10047397
Copr build: https://copr.fedorainfracloud.org/coprs/build/10047397 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2416340-rust-cliclack/fedora-rawhide-x86_64/10047397-rust-cliclack/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://download.copr.fedorainfracloud.org/results/r0x0d/rust-cliclack/fedora-rawhide-x86_64/10072139-rust-cliclack/rust-cliclack.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/r0x0d/rust-cliclack/fedora-rawhide-x86_64/10072139-rust-cliclack/rust-cliclack-0.3.8-1.fc44.src.rpm Notable updates: * Bumped to version 0.3.8 as upstream removed the media folder from the final crate * Relaxed the dependency for console
Created attachment 2126259 [details] The .spec file difference from Copr build 10047397 to 10073536
Copr build: https://copr.fedorainfracloud.org/coprs/build/10073536 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2416340-rust-cliclack/fedora-rawhide-x86_64/10073536-rust-cliclack/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Looks good to me now. Thank you! It would be great if the update from console 0.15.8 to 0.16 happened upstream too at some point so we don't need to carry this as a downstream patch forever, but that's not a blocker for this review. === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ patches are reasonable and justified (not upstreamed yet) ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional)
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cliclack
FEDORA-2026-ab8cd13fee (rust-cliclack-0.3.8-1.fc45) has been submitted as an update to Fedora 45. https://bodhi.fedoraproject.org/updates/FEDORA-2026-ab8cd13fee
FEDORA-2026-ab8cd13fee (rust-cliclack-0.3.8-1.fc45) has been pushed to the Fedora 45 stable repository. If problem still persists, please make note of it in this bug report.