Spec URL: http://www.volny.cz/jhrozek/ipcalc/ipcalc.spec SRPM URL: http://www.volny.cz/jhrozek/ipcalc/ipcalc-0.41-1.fc7.src.rpm Description: ipcalc takes an IP address and netmask and calculates the resulting broadcast, network, Cisco wildcard mask, and host range. By giving a second netmask, you can design subnets and supernets. It is also intended to be a teaching tool and presents the subnetting results as easy-to-understand binary values.
Fedora already includes an ipcalc utility (in initscripts). Trying to install another application with the very same name (and location, /bin/ipcalc) will lead to confusions and conflicts.
Ouch, you are right, I was not aware of the initscripts ipcalc.. One minor thing, this ipcalc installs its binary into /usr/bin/ipcalc, not /bin/ipcalc, so these two would not slap on one another, but one would have to invoke the binary with full path, which is quite ugly.. Would renaming of the package/binary be allowed? If not, I'm OK with withdrawing this package.
Sure, renaming is fine
Renamed: http://www.volny.cz/jhrozek/ipcalc/ipcalculator.spec http://www.volny.cz/jhrozek/ipcalc/ipcalculator-0.41-2.fc7.src.rpm
Package doesn't follow guidelines : -http://fedoraproject.org/wiki/Packaging/Guidelines#head-5d1681fa7cf3714ad490fbf7c095a0cfe16da27f
* Sat Jun 1 2007 Jakub Hrozek <jhrozek> - 0.41-3 -move the cgi script outside /var/www http://www.volny.cz/jhrozek/ipcalc/ipcalculator.spec http://www.volny.cz/jhrozek/ipcalc/ipcalculator-0.41-3.fc8.src.rpm
The sed substitution may also be along: sed -i 's:/usr/local/bin/ipcalc/:%{_bindir}/ipcalculator:' \ $RPM_BUILD_ROOT%{_datadir}/%{name}/ipcalculator.cgi Regarding the package name, this deviation is accepted in the guidelines since it adds a best judgement clause. And in that case indeed there could be confusion with the other ipcalc. You should own the %{_datadir}/%{name}/ directory. You should also patch the program to use ipcalculator instead of ipcalc in help message. Unless I am wrong it could also be achieved by sed -e 's/ipcalc /%{name} /' I know it is a small package, but you may want to split the cgi part and the main script anyway since they correspond with very different uses in my opinion. Also, especially in case you have a -cgi subpackage, you may consider shipping a config file for apache, as doc or in /etc/httpd/conf.d such that the cgi works more easily out of the box. Having a config file for httpd already installed has advantages (works out of the box) and inconvenients (may create security issues if it isn't required to change something manually by the local admin). All that is optional and left to your best judgement.
Something similar to the below lines should do for /etc/httpd/conf.d/ipcalculator.conf (beware: not tested) ScriptAlias /ipcalculator/ /usr/share/ipcalculator/ <Directory /usr/share/ipcalculator/> DirectoryIndex ipcalculator.cgi Options ExecCGI order deny,allow deny from all allow from 127.0.0.1 </Directory>
Patrice, Manuel, Thanks for the valuable suggestions. I'll fix the issues pointed out in comment #7, also the split seems like a good idea, thanks for proposing the httpd config file. But it might take a few days as I'm currently swamped with other things (a.k.a it's exam time on universities :) ), please don't take it as I'm abandoning the review and/or ignoring your suggestions.
* Sat Jun 16 2007 Jakub Hrozek <jhrozek> - 0.41-4 - split the CGI wrapper into its own -cgi subpackage - nicer sed substitution in the CGI module - own the /usr/share/ipcalculator directory - add a config file for httpd (written by Manuel Wolfshant) - mention ipcalculator, not ipcalc in usage and help messages http://hrozkovi.homelinux.org/ipcalculator/ipcalculator.spec http://hrozkovi.homelinux.org/ipcalculator/ipcalculator-0.41-4.fc8.src.rpm One question - is it necessary to have some docs in the -cgi subpackage even though it requires the ipcalculator package which contains the necessary docs? (rpmlint gripes about that)
(In reply to comment #10) > One question - is it necessary to have some docs in the -cgi subpackage even > though it requires the ipcalculator package which contains the necessary docs? > (rpmlint gripes about that) You don't have to worry about that rpmlint warning. In general rpmlint errors and warnings may be ignored when they are pointless, as it is the case here.
I cannot access the srpm... I can't remember why I didn't finished that review...
srpm re-uploaded. Thanks for your time taking a look at my package!
The perl(CGI) requires seems to be only for -cgi, and autodetected. Similarly the perl requires is autodetected. Shouldn't the cgi subpackage depend on httpd? GPL isn't a valid license anymore, it is GPL+, GPLv2, GPLv2+... The source archive timestamp isn't kept: -rw-rw-r-- 1 dumas dumas 21599 jui 27 2006 ipcalc-0.41.tar.gz -rw-rw-r-- 1 dumas dumas 21599 mai 29 2007 ../SOURCES/ipcalc-0.41.tar.gz You can use wget -N, spectool -g and the corresponding curl option. There are issues with the package as I tested. First the images are considered as scripts with the conf file Manuel proposed. I propose the following: Alias /ipcalculator/ /usr/share/ipcalculator/ <Directory /usr/share/ipcalculator/> DirectoryIndex ipcalculator.cgi Options ExecCGI AddHandler cgi-script cgi order deny,allow deny from all allow from 127.0.0.1 </Directory> The images should be owned by the -cgi subpackage. There is a missing image files, bg.gif. ipcalc.gif should be renamed ipcal03.gif. <a href="ipcalc.png">Screenshot</a> (ipcalc works also at the prompt)<br> should be changed to <a href="http://jodies.de/ipcalc.png">Screenshot</a> (ipcalc works also at the prompt)<br> Similar with <a href="ipcalc-archive">Archive</a><br> <a href="ipcalc-faq/win32.html">How to run this under windows</a><br> Suggestion: use %{version} in Source0: http://jodies.de/ipcalc-archive/ipcalc-%{version}.tar.gz
Any progress on here?
Thanks for poking me, Mamoru! I totally forgot about this one.. http://hrozkovi.cz/ipcalculator.spec http://hrozkovi.cz/ipcalculator-0.41-5.fc7.src.rpm The bg.gif image is still not included, as I'd like to use the one at the upstream page, so I queried the author about including it.
The sed is wrong: sed -i 's:/usr/local/bin/ipcalc/:%{_bindir}/ipcalculator:' ipcalc.cgi should be sed -i 's:/usr/local/bin/ipcalc:%{_bindir}/ipcalculator:' ipcalc.cgi
http://hrozkovi.cz/ipcalculator.spec http://hrozkovi.cz/ipcalculator-0.41-6.fc7.src.rpm * Wed Dec 26 2007 Jakub Hrozek <jhrozek> - 0.41-6 - fix a typo in the sed substitution - add the background image from the project page
Jakub, All ok for me. APPROVED.
Looks good to me too.
New Package CVS Request ======================= Package Name: ipcalculator Short Description: A utility for computing broadcast, network, mask, and host ranges Owners: jhrozek Branches: F-7 F-8 InitialCC: none Cvsextras Commits: yes
cvs done.
Built for rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=418486 Patrice, Manuel, Marek - thanks for the work done on this review!