Spec URL: https://jjames.fedorapeople.org/python-iplotx/python-iplotx.spec SRPM URL: https://jjames.fedorapeople.org/python-iplotx/python-iplotx-1.6.0-1.fc44.src.rpm Fedora Account System Username: jjames Description: Visualize networks and trees in Python, with style. Supports: - networks - networkx - igraph - graph-tool - zero-dependency - trees: - ETE4 - cogent3 - Biopython - scikit-bio - dendropy - zero-dependency In addition to the above, any network or tree analysis library can register an entry point to gain compatibility with iplotx with no intervention from our side. I am willing to swap reviews.
Copr build: https://copr.fedorainfracloud.org/coprs/build/9834351 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2416887-python-iplotx/fedora-rawhide-x86_64/09834351-python-iplotx/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains BR: python2-devel or python3-devel ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License". 272 files have unknown license. Detailed output of licensecheck in /home/fedora-packaging/reviews/python- iplotx/2416887-python-iplotx/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.14/site- packages, /usr/lib/python3.14 [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 3790 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-iplotx , python3-iplotx+igraph , python3-iplotx+networkx [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-iplotx-1.6.0-1.fc44.noarch.rpm python3-iplotx+igraph-1.6.0-1.fc44.noarch.rpm python3-iplotx+networkx-1.6.0-1.fc44.noarch.rpm python-iplotx-1.6.0-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpoqhoe8yd')] checks: 32, packages: 4 python-iplotx.src: E: spelling-error ('networkx', '%description -l en_US networkx -> network, networks, network x') python-iplotx.src: E: spelling-error ('igraph', '%description -l en_US igraph -> graph, digraph, i graph') python-iplotx.src: E: spelling-error ('scikit', '%description -l en_US scikit -> sci kit, sci-kit, kitsch') python-iplotx.src: E: spelling-error ('dendropy', '%description -l en_US dendropy -> dewdrop') python3-iplotx.noarch: E: spelling-error ('networkx', '%description -l en_US networkx -> network, networks, network x') python3-iplotx.noarch: E: spelling-error ('igraph', '%description -l en_US igraph -> graph, digraph, i graph') python3-iplotx.noarch: E: spelling-error ('scikit', '%description -l en_US scikit -> sci kit, sci-kit, kitsch') python3-iplotx.noarch: E: spelling-error ('dendropy', '%description -l en_US dendropy -> dewdrop') 4 packages and 0 specfiles checked; 8 errors, 0 warnings, 25 filtered, 8 badness; has taken 1.2 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 python3-iplotx.noarch: E: spelling-error ('networkx', '%description -l en_US networkx -> network, networks, network x') python3-iplotx.noarch: E: spelling-error ('igraph', '%description -l en_US igraph -> graph, digraph, i graph') python3-iplotx.noarch: E: spelling-error ('scikit', '%description -l en_US scikit -> sci kit, sci-kit, kitsch') python3-iplotx.noarch: E: spelling-error ('dendropy', '%description -l en_US dendropy -> dewdrop') 3 packages and 0 specfiles checked; 4 errors, 0 warnings, 21 filtered, 4 badness; has taken 0.4 s Source checksums ---------------- https://github.com/fabilab/iplotx/archive/1.6.0/iplotx-1.6.0.tar.gz : CHECKSUM(SHA256) this package : f955db0fe88dfcb118ec86634bf30ca093ea54df975339a188f63d7ec84f81c0 CHECKSUM(SHA256) upstream package : f955db0fe88dfcb118ec86634bf30ca093ea54df975339a188f63d7ec84f81c0 Requires -------- python3-iplotx (rpmlib, GLIBC filtered): python(abi) python3.14dist(matplotlib) python3.14dist(numpy) python3.14dist(pandas) python3-iplotx+igraph (rpmlib, GLIBC filtered): python(abi) python3-iplotx python3.14dist(igraph) python3-iplotx+networkx (rpmlib, GLIBC filtered): python(abi) python3-iplotx python3.14dist(networkx) Provides -------- python3-iplotx: python-iplotx python3-iplotx python3.14-iplotx python3.14dist(iplotx) python3dist(iplotx) python3-iplotx+igraph: python-iplotx+igraph python3-iplotx+igraph python3.14-iplotx+igraph python3.14dist(iplotx[igraph]) python3dist(iplotx[igraph]) python3-iplotx+networkx: python-iplotx+networkx python3-iplotx+networkx python3.14-iplotx+networkx python3.14dist(iplotx[networkx]) python3dist(iplotx[networkx]) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2416887 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Python, Shell-api Disabled plugins: Perl, PHP, Haskell, fonts, C/C++, Ocaml, R, Java, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=139369169 b) The test line is very long: %pytest -v -k 'not test_complex and not test_curved_waypoints and not test_directed_graph and not test_display_shortest_path and not test_leaf_labels and not test_labels and not test_leafedges and not test_show_support and not test_vertex_labels' Consider using k="${k-}${k+ and }not (test_complex)" k="${k-}${k+ and }not (test_curved_waypoints)" k="${k-}${k+ and }not (test_directed_graph)" k="${k-}${k+ and }not (test_display_shortest_path)" k="${k-}${k+ and }not (test_leaf_labels)" k="${k-}${k+ and }not (test_labels)" k="${k-}${k+ and }not (test_leafedges)" k="${k-}${k+ and }not (test_show_support)" k="${k-}${k+ and }not (test_vertex_labels)" %pytest -v -k "${k-}" c) dendropy and cogent3 are the missing dependencies for documentation. Dendropy seems possible to add to Fedora. Cogent3 depends on numba which may take some time before it can be shipped in Fedora: https://github.com/numba/numba/issues/9881 Consider updating the comment for not building the documentation to indicate what is actually missing. d) Consider adding Requires: python3-libs to ensure all directories are owned, or at least prevent the warning. e) Provisional Python packaging macros ar used, so a BR on Python3-devel is not needed. f) Approved. g) Review of: https://bugzilla.redhat.com/show_bug.cgi?id=2402467 would be appreciated if time and expertise allow.
Thank you for the review, Benson! I will review bug 2402467 today. I'll split up the test line as recommended, and comment on the missing documentation dependencies Adding "Requires: python3-libs" won't accomplish anything. The automatically generated Requires already include "python(abi)", which is provided by the python3 package, which itself requires python3-libs. I don't see anything in https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ that suggests that anything more than the automatically generated Requires are needed.
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-iplotx
FEDORA-2025-123361d422 (python-iplotx-1.6.0-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-123361d422
FEDORA-2025-123361d422 has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-123361d422 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-123361d422 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-123361d422 (python-iplotx-1.6.0-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.