Spec URL: https://raw.githubusercontent.com/dorindabassey/rust-mesa3d_util-copr/refs/heads/main/rust-mesa3d_util.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/dorinda/mesa3d_util/fedora-rawhide-x86_64/09835593-rust-mesa3d_util/rust-mesa3d_util-0.1.75-1.fc44.src.rpm Description: Utility crate part of Mesa3D project Fedora Account System Username: dorinda
Cannot find any valid SRPM URL for this ticket. Common causes are: - You didn't specify `SRPM URL: ...` in the ticket description or any of your comments - The URL schema isn't HTTP or HTTPS - The SRPM package linked in your URL doesn't match the package name specified in the ticket summary --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://raw.githubusercontent.com/dorindabassey/rust-mesa3d_util-copr/refs/heads/main/rust-mesa3d_util.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/dorinda/mesa3d_util/fedora-43-x86_64/09835593-rust-mesa3d_util/rust-mesa3d_util-0.1.75-1.fc43.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/9837155 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2417040-rust-mesa3d_util/fedora-rawhide-x86_64/09837155-rust-mesa3d_util/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Hi @decathorpe please do you have sometime to help review this package? It's a new dependency that's needed for rust-rutabaga_gfx Thanks!
Hi @marcandre.lureau would you be able to review this package? I'm Looking for a Rust reviewer. Thanks!
No issues found; the package is APPROVED. The package is straight rust2rpm 27 ---- Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) ---- Package Review ============== This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/mesa3d_util-0.1.75/LICENSE-MIT See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* MIT License", "MIT License". 3 files have unknown license. Detailed output of licensecheck in /home/elmarco/pkg/2417040-rust- mesa3d_util/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- mesa3d_util-devel , rust-mesa3d_util+default-devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rust-mesa3d_util-devel-0.1.75-1.fc44.noarch.rpm rust-mesa3d_util+default-devel-0.1.75-1.fc44.noarch.rpm rust-mesa3d_util-0.1.75-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp7typkk4r')] checks: 32, packages: 3 rust-mesa3d_util-devel.noarch: W: no-documentation rust-mesa3d_util-devel.noarch: W: cross-directory-hard-link /usr/share/cargo/registry/mesa3d_util-0.1.75/sys/stub/mod.rs /usr/share/cargo/registry/mesa3d_util-0.1.75/sys/linux/mod.rs rust-mesa3d_util-devel.noarch: W: cross-directory-hard-link /usr/share/cargo/registry/mesa3d_util-0.1.75/sys/windows/event.rs /usr/share/cargo/registry/mesa3d_util-0.1.75/sys/stub/event.rs rust-mesa3d_util-devel.noarch: W: cross-directory-hard-link /usr/share/cargo/registry/mesa3d_util-0.1.75/sys/windows/mod.rs /usr/share/cargo/registry/mesa3d_util-0.1.75/sys/linux/mod.rs rust-mesa3d_util-devel.noarch: W: cross-directory-hard-link /usr/share/cargo/registry/mesa3d_util-0.1.75/sys/windows/mod.rs /usr/share/cargo/registry/mesa3d_util-0.1.75/sys/stub/mod.rs rust-mesa3d_util-devel.noarch: W: cross-directory-hard-link /usr/share/cargo/registry/mesa3d_util-0.1.75/sys/windows/pipe.rs /usr/share/cargo/registry/mesa3d_util-0.1.75/sys/stub/pipe.rs rust-mesa3d_util-devel.noarch: W: cross-directory-hard-link /usr/share/cargo/registry/mesa3d_util-0.1.75/sys/windows/tube.rs /usr/share/cargo/registry/mesa3d_util-0.1.75/sys/stub/tube.rs rust-mesa3d_util-devel.noarch: W: cross-directory-hard-link /usr/share/cargo/registry/mesa3d_util-0.1.75/sys/windows/wait_context.rs /usr/share/cargo/registry/mesa3d_util-0.1.75/sys/stub/wait_context.rs 3 packages and 0 specfiles checked; 0 errors, 8 warnings, 13 filtered, 0 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 rust-mesa3d_util-devel.noarch: W: no-documentation rust-mesa3d_util-devel.noarch: W: cross-directory-hard-link /usr/share/cargo/registry/mesa3d_util-0.1.75/sys/stub/mod.rs /usr/share/cargo/registry/mesa3d_util-0.1.75/sys/linux/mod.rs rust-mesa3d_util-devel.noarch: W: cross-directory-hard-link /usr/share/cargo/registry/mesa3d_util-0.1.75/sys/windows/event.rs /usr/share/cargo/registry/mesa3d_util-0.1.75/sys/stub/event.rs rust-mesa3d_util-devel.noarch: W: cross-directory-hard-link /usr/share/cargo/registry/mesa3d_util-0.1.75/sys/windows/mod.rs /usr/share/cargo/registry/mesa3d_util-0.1.75/sys/linux/mod.rs rust-mesa3d_util-devel.noarch: W: cross-directory-hard-link /usr/share/cargo/registry/mesa3d_util-0.1.75/sys/windows/mod.rs /usr/share/cargo/registry/mesa3d_util-0.1.75/sys/stub/mod.rs rust-mesa3d_util-devel.noarch: W: cross-directory-hard-link /usr/share/cargo/registry/mesa3d_util-0.1.75/sys/windows/pipe.rs /usr/share/cargo/registry/mesa3d_util-0.1.75/sys/stub/pipe.rs rust-mesa3d_util-devel.noarch: W: cross-directory-hard-link /usr/share/cargo/registry/mesa3d_util-0.1.75/sys/windows/tube.rs /usr/share/cargo/registry/mesa3d_util-0.1.75/sys/stub/tube.rs rust-mesa3d_util-devel.noarch: W: cross-directory-hard-link /usr/share/cargo/registry/mesa3d_util-0.1.75/sys/windows/wait_context.rs /usr/share/cargo/registry/mesa3d_util-0.1.75/sys/stub/wait_context.rs 2 packages and 0 specfiles checked; 0 errors, 8 warnings, 9 filtered, 0 badness; has taken 0.1 s Source checksums ---------------- https://crates.io/api/v1/crates/mesa3d_util/0.1.75/download#/mesa3d_util-0.1.75.crate : CHECKSUM(SHA256) this package : 61c76e90ba0bde4c5eb7c1b23d9b0b87333ce3e3db9a3f5fd44b2caae3c99358 CHECKSUM(SHA256) upstream package : 61c76e90ba0bde4c5eb7c1b23d9b0b87333ce3e3db9a3f5fd44b2caae3c99358 Requires -------- rust-mesa3d_util-devel (rpmlib, GLIBC filtered): (crate(cfg-if/default) >= 1.0.0 with crate(cfg-if/default) < 2.0.0~) (crate(libc/default) >= 0.2.116 with crate(libc/default) < 0.3.0~) (crate(log/default) >= 0.4.0 with crate(log/default) < 0.5.0~) (crate(remain/default) >= 0.2.0 with crate(remain/default) < 0.3.0~) (crate(rustix/default) >= 1.0.7 with crate(rustix/default) < 2.0.0~) (crate(rustix/event) >= 1.0.7 with crate(rustix/event) < 2.0.0~) (crate(rustix/fs) >= 1.0.7 with crate(rustix/fs) < 2.0.0~) (crate(rustix/libc_errno) >= 1.0.7 with crate(rustix/libc_errno) < 2.0.0~) (crate(rustix/mm) >= 1.0.7 with crate(rustix/mm) < 2.0.0~) (crate(rustix/net) >= 1.0.7 with crate(rustix/net) < 2.0.0~) (crate(rustix/param) >= 1.0.7 with crate(rustix/param) < 2.0.0~) (crate(rustix/pipe) >= 1.0.7 with crate(rustix/pipe) < 2.0.0~) (crate(rustix/use-libc) >= 1.0.7 with crate(rustix/use-libc) < 2.0.0~) (crate(rustix/use-libc-auxv) >= 1.0.7 with crate(rustix/use-libc-auxv) < 2.0.0~) (crate(thiserror/default) >= 1.0.23 with crate(thiserror/default) < 2.0.0~) (crate(zerocopy/default) >= 0.8.13 with crate(zerocopy/default) < 0.9.0~) (crate(zerocopy/derive) >= 0.8.13 with crate(zerocopy/derive) < 0.9.0~) cargo rust-mesa3d_util+default-devel (rpmlib, GLIBC filtered): cargo crate(mesa3d_util) Provides -------- rust-mesa3d_util-devel: crate(mesa3d_util) rust-mesa3d_util-devel rust-mesa3d_util+default-devel: crate(mesa3d_util/default) rust-mesa3d_util+default-devel Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2417040 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Ocaml, SugarActivity, PHP, fonts, Perl, R, C/C++, Python, Java, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Thank you for the quick response and review MarcAndre!
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-mesa3d_util