Bug 2417176 - Review Request: orocos-kdl - A framework for modeling and computation of kinematic chains
Summary: Review Request: orocos-kdl - A framework for modeling and computation of kine...
Keywords:
Status: CLOSED COMPLETED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Scott K Logan
QA Contact: Fedora Extras Quality Assurance
URL: http://www.orocos.org/kdl.html
Whiteboard:
Depends On:
Blocks: 1225692
TreeView+ depends on / blocked
 
Reported: 2025-11-26 00:47 UTC by Leonardo Rossetti
Modified: 2026-07-30 17:10 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2026-07-30 17:10:38 UTC
Type: ---
Embargoed:
logans: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 10016067 to 10047275 (5.12 KB, patch)
2026-01-22 10:54 UTC, Fedora Review Service
no flags Details | Diff
The .spec file difference from Copr build 10047275 to 10457431 (12.02 KB, patch)
2026-05-14 00:04 UTC, Fedora Review Service
no flags Details | Diff
The .spec file difference from Copr build 10457431 to 10457470 (1000 bytes, patch)
2026-05-14 01:02 UTC, Fedora Review Service
no flags Details | Diff

Description Leonardo Rossetti 2025-11-26 00:47:55 UTC
Spec URL: https://src.fedoraproject.org/fork/lrossett/rpms/orocos-kdl/raw/rawhide/f/orocos-kdl.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/lrossett/orocos-kdl/fedora-rawhide-x86_64/09838241-orocos-kdl/orocos-kdl-1.5.3-1.fc44.src.rpm
Description: The package has been orphaned for more then 6 weeks and needs to be reviewed again
Fedora Account System Username: lrossett

Comment 1 Fedora Review Service 2025-11-26 00:58:29 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9838252
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2417176-orocos-kdl/fedora-rawhide-x86_64/09838252-orocos-kdl/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/orocos-kdl
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Leonardo Rossetti 2026-01-15 11:59:57 UTC
[fedora-review-service-build]

Comment 4 Fedora Review Service 2026-01-15 20:33:51 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10016067
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2417176-orocos-kdl/fedora-rawhide-x86_64/10016067-orocos-kdl/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/orocos-kdl
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Fedora Review Service 2026-01-15 20:34:09 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10016065
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2417176-orocos-kdl/fedora-rawhide-x86_64/10016065-orocos-kdl/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/orocos-kdl
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Sayan 2026-01-16 16:12:37 UTC
λ rpmlint -i orocos-kdl
=============================================================================================================== rpmlint session starts ===============================================================================================================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

orocos-kdl.x86_64: E: incorrect-fsf-address /usr/share/licenses/orocos-kdl/COPYING
========================================================================= 1 packages and 0 specfiles checked; 1 errors, 0 warnings, 12 filtered, 1 badness; has taken 0.2 s ==========================================================================
[~/fedpkg_review]$
λ rpmlint -i orocos-kdl-devel
=============================================================================================================== rpmlint session starts ===============================================================================================================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

orocos-kdl-devel.x86_64: W: no-documentation
orocos-kdl-devel.x86_64: E: incorrect-fsf-address /usr/include/kdl/chainjnttojacdotsolver.hpp
orocos-kdl-devel.x86_64: W: files-duplicate /usr/lib64/pkgconfig/orocos_kdl.pc /usr/lib64/pkgconfig/orocos-kdl.pc
========================================================================== 1 packages and 0 specfiles checked; 1 errors, 2 warnings, 6 filtered, 1 badness; has taken 0.2 s ==========================================================================
[~/fedpkg_review]$
λ rpmlint -i orocos-kdl-doc
=============================================================================================================== rpmlint session starts ===============================================================================================================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1ChainFkSolverAcc__inherit__graph.map /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1ChainFkSolverAcc__coll__graph.map
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1ChainFkSolverAcc__inherit__graph.md5 /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1ChainFkSolverAcc__coll__graph.md5
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1ChainFkSolverAcc__inherit__graph.png /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1ChainFkSolverAcc__coll__graph.png
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1ChainIkSolverAcc__inherit__graph.map /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1ChainIkSolverAcc__coll__graph.map
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1ChainIkSolverAcc__inherit__graph.md5 /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1ChainIkSolverAcc__coll__graph.md5
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1ChainIkSolverAcc__inherit__graph.png /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1ChainIkSolverAcc__coll__graph.png
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1Joint_1_1joint__type__exception__inherit__graph.map /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1Joint_1_1joint__type__exception__coll__graph.map
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1Joint_1_1joint__type__exception__inherit__graph.md5 /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1Joint_1_1joint__type__exception__coll__graph.md5
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1Joint_1_1joint__type__exception__inherit__graph.png /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1Joint_1_1joint__type__exception__coll__graph.png
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Dirac__inherit__graph.map /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Dirac__coll__graph.map
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Dirac__inherit__graph.md5 /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Dirac__coll__graph.md5
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Dirac__inherit__graph.png /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Dirac__coll__graph.png
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Rectangular__inherit__graph.map /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Rectangular__coll__graph.map
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Rectangular__inherit__graph.md5 /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Rectangular__coll__graph.md5
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Rectangular__inherit__graph.png /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Rectangular__coll__graph.png
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Spline__inherit__graph.map /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Spline__coll__graph.map
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Spline__inherit__graph.md5 /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Spline__coll__graph.md5
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Spline__inherit__graph.png /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Spline__coll__graph.png
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__TrapHalf__inherit__graph.map /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__TrapHalf__coll__graph.map
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__TrapHalf__inherit__graph.md5 /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__TrapHalf__coll__graph.md5
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__TrapHalf__inherit__graph.png /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__TrapHalf__coll__graph.png
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Trap__inherit__graph.map /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Trap__coll__graph.map
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Trap__inherit__graph.md5 /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Trap__coll__graph.md5
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Trap__inherit__graph.png /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Trap__coll__graph.png
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/search/pages_0.js /usr/share/doc/orocos-kdl-doc/html/search/all_0.js
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/search/pages_1.js /usr/share/doc/orocos-kdl-doc/html/search/all_1.js
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/search/functions_15.js /usr/share/doc/orocos-kdl-doc/html/search/all_1c.js
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/search/functions_17.js /usr/share/doc/orocos-kdl-doc/html/search/all_1e.js
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/search/pages_2.js /usr/share/doc/orocos-kdl-doc/html/search/all_2.js
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/search/pages_3.js /usr/share/doc/orocos-kdl-doc/html/search/all_3.js
========================================================================= 1 packages and 0 specfiles checked; 0 errors, 30 warnings, 4 filtered, 0 badness; has taken 1.1 s ==========================================================================

Comment 7 Sayan 2026-01-16 16:17:04 UTC
use of generic globs:

%{_includedir}/*
%{_datadir}/orocos_kdl
%{_libdir}/*.so
%{_libdir}/pkgconfig/*


specifically the includedir can be:

%{_includedir}/kdl/

Comment 8 Sayan 2026-01-16 16:17:26 UTC
use of generic globs:

%{_includedir}/*
%{_datadir}/orocos_kdl
%{_libdir}/*.so
%{_libdir}/pkgconfig/*


specifically the includedir can be:

%{_includedir}/kdl/

Comment 9 Leonardo Rossetti 2026-01-22 10:42:46 UTC
I've fixed the wildcard usage:

Spec URL: https://src.fedoraproject.org/fork/lrossett/rpms/orocos-kdl/raw/rawhide/f/orocos-kdl.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/lrossett/orocos-kdl/fedora-rawhide-x86_64/10047251-orocos-kdl/orocos-kdl-1.5.3-1.fc44.src.rpm

The missing docs one is expected since there is a sub package dedicated to docs.

Comment 10 Fedora Review Service 2026-01-22 10:54:26 UTC
Created attachment 2123248 [details]
The .spec file difference from Copr build 10016067 to 10047275

Comment 11 Fedora Review Service 2026-01-22 10:54:28 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10047275
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2417176-orocos-kdl/fedora-rawhide-x86_64/10047275-orocos-kdl/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/orocos-kdl
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 12 Sayan 2026-01-29 03:07:58 UTC
LGTM

I think instead of listing all the files individually the includes can be globed till kdl dir : %{_includedir}/kdl/* it will look cleaner.
My first comment was on the glob as it was more generalized :  %{_includedir}/*

Comment 13 Scott K Logan 2026-03-23 19:28:31 UTC
Some early thoughts taking a look at the spec:
1. The %{_includedir}/kdl/ directory should be listed directly in the spec. In addition to the cleaner spec Sayan mentioned, this package needs to "own" the directory or it will be left on disk when the package is uninstalled. Same for %{_datadir}/orocos_kdl/.
2. The doc package should either depend on the base package or include its own copy of the license.
3. Consider replacing `ExcludeArch: i386` with `ExcludeArch: %{ix86}`
4. I don't think the `*.debug` file should be explicitly listed - shouldn't that be part of the automatic debuginfo package?

Comment 14 Leonardo Rossetti 2026-03-27 13:12:49 UTC
spec file updated.

Comment 15 Scott K Logan 2026-04-02 01:01:19 UTC
Thanks, it looks like there is a flaky test and my scratch builds appear to be failing randomly. Do you see the same?

Comment 16 Leonardo Rossetti 2026-04-09 15:10:02 UTC
I didn't see it in copr, but I saw one in koji now. Taking a look.

Comment 17 Leonardo Rossetti 2026-04-09 17:56:45 UTC
Also, it looks like it's only Arm builds.

Comment 18 Leonardo Rossetti 2026-05-14 00:00:47 UTC
Updated spec file to skip solvertest usage in aarch64 due to unstable behavior:

Spec URL: https://src.fedoraproject.org/fork/lrossett/rpms/orocos-kdl/raw/rawhide/f/orocos-kdl.spec
SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/164/145440164/orocos-kdl-1.5.3-19.fc43.src.rpm

Comment 19 Fedora Review Service 2026-05-14 00:04:33 UTC
Created attachment 2141142 [details]
The .spec file difference from Copr build 10047275 to 10457431

Comment 20 Fedora Review Service 2026-05-14 00:04:36 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10457431
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2417176-orocos-kdl/fedora-rawhide-x86_64/10457431-orocos-kdl/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 22 Fedora Review Service 2026-05-14 01:02:17 UTC
Created attachment 2141145 [details]
The .spec file difference from Copr build 10457431 to 10457470

Comment 23 Fedora Review Service 2026-05-14 01:02:20 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10457470
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2417176-orocos-kdl/fedora-rawhide-x86_64/10457470-orocos-kdl/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/orocos-kdl
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 24 Leonardo Rossetti 2026-05-14 01:07:09 UTC
removed solvertest from all archs as it failed in rawhide x86_64.

Comment 25 Scott K Logan 2026-05-14 17:51:25 UTC
APPROVED.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
=======
- Suggest using consistent indentation in preamble tags
- We should follow up about the Eigen dependency at runtime, which doesn't make a lot of sense to me. Maybe it should be on orocos-kdl-devel.
- I'm surprised %{py3_test_envvars} doesn't set LD_LIBRARY_PATH. No action here, just a note.


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
     Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "GNU Lesser General Public License,
     Version 2.1", "BSD 2-Clause License", "*No copyright* GNU Lesser
     General Public License v2.1 or later", "GNU Lesser General Public
     License v2.1 or later [obsolete FSF postal address (Temple Place)]",
     "GNU Lesser General Public License v2.1 or later". 114 files have
     unknown license. Detailed output of licensecheck in /var/lib/copr-
     rpmbuild/results/orocos-kdl/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib64/python3.14,
     /usr/lib64/python3.14/site-packages
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries or specifies bundled libraries
     with Provides: bundled(<libname>) if unbundling is not possible.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
     Excluding ix86 leaf packages is explicitly allowed
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 981 bytes in 1 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
     i686 is explicitly disabled per policy
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define autorelease(e:s:pb:n)
     %{?-p:0.}%{lua:
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.


Rpmlint
-------
Checking: orocos-kdl-1.5.3-20.fc45.x86_64.rpm
          orocos-kdl-devel-1.5.3-20.fc45.x86_64.rpm
          orocos-kdl-doc-1.5.3-20.fc45.noarch.rpm
          python3-pykdl-1.5.3-20.fc45.x86_64.rpm
          orocos-kdl-1.5.3-20.fc45.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpkm4az92v')]
checks: 32, packages: 5

python3-pykdl.x86_64: E: spelling-error ('orocos', 'Summary(en_US) orocos -> siroccos, rococo')
python3-pykdl.x86_64: E: spelling-error ('orocos', '%description -l en_US orocos -> siroccos, rococo')
orocos-kdl-devel.x86_64: W: no-documentation
python3-pykdl.x86_64: W: no-documentation
orocos-kdl.x86_64: E: incorrect-fsf-address /usr/share/licenses/orocos-kdl/COPYING
orocos-kdl-devel.x86_64: E: incorrect-fsf-address /usr/include/kdl/chainjnttojacdotsolver.hpp
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1ChainFkSolverAcc__inherit__graph.map /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1ChainFkSolverAcc__coll__graph.map
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1ChainFkSolverAcc__inherit__graph.md5 /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1ChainFkSolverAcc__coll__graph.md5
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1ChainFkSolverAcc__inherit__graph.png /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1ChainFkSolverAcc__coll__graph.png
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1ChainIkSolverAcc__inherit__graph.map /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1ChainIkSolverAcc__coll__graph.map
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1ChainIkSolverAcc__inherit__graph.md5 /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1ChainIkSolverAcc__coll__graph.md5
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1ChainIkSolverAcc__inherit__graph.png /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1ChainIkSolverAcc__coll__graph.png
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1Joint_1_1joint__type__exception__inherit__graph.map /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1Joint_1_1joint__type__exception__coll__graph.map
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1Joint_1_1joint__type__exception__inherit__graph.md5 /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1Joint_1_1joint__type__exception__coll__graph.md5
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1Joint_1_1joint__type__exception__inherit__graph.png /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1Joint_1_1joint__type__exception__coll__graph.png
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Dirac__inherit__graph.map /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Dirac__coll__graph.map
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Dirac__inherit__graph.md5 /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Dirac__coll__graph.md5
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Dirac__inherit__graph.png /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Dirac__coll__graph.png
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Rectangular__inherit__graph.map /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Rectangular__coll__graph.map
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Rectangular__inherit__graph.md5 /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Rectangular__coll__graph.md5
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Rectangular__inherit__graph.png /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Rectangular__coll__graph.png
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Spline__inherit__graph.map /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Spline__coll__graph.map
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Spline__inherit__graph.md5 /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Spline__coll__graph.md5
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Spline__inherit__graph.png /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Spline__coll__graph.png
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__TrapHalf__inherit__graph.map /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__TrapHalf__coll__graph.map
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__TrapHalf__inherit__graph.md5 /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__TrapHalf__coll__graph.md5
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__TrapHalf__inherit__graph.png /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__TrapHalf__coll__graph.png
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Trap__inherit__graph.map /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Trap__coll__graph.map
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Trap__inherit__graph.md5 /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Trap__coll__graph.md5
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Trap__inherit__graph.png /usr/share/doc/orocos-kdl-doc/html/classKDL_1_1VelocityProfile__Trap__coll__graph.png
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/search/pages_0.js /usr/share/doc/orocos-kdl-doc/html/search/all_0.js
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/search/pages_1.js /usr/share/doc/orocos-kdl-doc/html/search/all_1.js
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/search/functions_15.js /usr/share/doc/orocos-kdl-doc/html/search/all_1c.js
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/search/functions_17.js /usr/share/doc/orocos-kdl-doc/html/search/all_1e.js
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/search/pages_2.js /usr/share/doc/orocos-kdl-doc/html/search/all_2.js
orocos-kdl-doc.noarch: W: files-duplicate /usr/share/doc/orocos-kdl-doc/html/search/pages_3.js /usr/share/doc/orocos-kdl-doc/html/search/all_3.js
 5 packages and 0 specfiles checked; 4 errors, 32 warnings, 30 filtered, 4 badness; has taken 1.3 s 




Rpmlint (debuginfo)
-------------------
Checking: orocos-kdl-debuginfo-1.5.3-20.fc45.x86_64.rpm
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp21drjr9v')]
checks: 32, packages: 1

 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.8 s 





Rpmlint (installed packages)
----------------------------
(none): E: there is no installed rpm "orocos-kdl-devel".
(none): E: there is no installed rpm "orocos-kdl".
(none): E: there is no installed rpm "orocos-kdl-doc".
(none): E: there is no installed rpm "python3-pykdl".
============================ rpmlint session starts ============================
rpmlint: 2.9.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 5

 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s 
(none): E: there is no installed rpm "orocos-kdl-debuginfo".
There are no files to process nor additional arguments.
Nothing to do, aborting.



Unversioned so-files
--------------------
python3-pykdl: /usr/lib64/python3.14/site-packages/PyKDL.cpython-314-x86_64-linux-gnu.so

Source checksums
----------------
https://github.com/orocos/orocos_kinematics_dynamics/archive/refs/tags/1.5.3.tar.gz :
  CHECKSUM(SHA256) this package     : 3895eed1b51a6803c79e7ac4acd6a2243d621b887ac26a1a6b82a86a1131c3b6
  CHECKSUM(SHA256) upstream package : 3895eed1b51a6803c79e7ac4acd6a2243d621b887ac26a1a6b82a86a1131c3b6


Requires
--------
orocos-kdl (rpmlib, GLIBC filtered):
    eigen3
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libm.so.6()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    rtld(GNU_HASH)

orocos-kdl-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    liborocos-kdl.so.1.5()(64bit)
    orocos-kdl(x86-64)

orocos-kdl-doc (rpmlib, GLIBC filtered):
    orocos-kdl

python3-pykdl (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libm.so.6()(64bit)
    liborocos-kdl.so.1.5()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.11)(64bit)
    libstdc++.so.6(CXXABI_1.3.13)(64bit)
    libstdc++.so.6(CXXABI_1.3.15)(64bit)
    libstdc++.so.6(CXXABI_1.3.2)(64bit)
    libstdc++.so.6(CXXABI_1.3.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.5)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    orocos-kdl(x86-64)
    python(abi)
    rtld(GNU_HASH)



Provides
--------
orocos-kdl:
    liborocos-kdl.so.1.5()(64bit)
    orocos-kdl
    orocos-kdl(x86-64)

orocos-kdl-devel:
    orocos-kdl-devel
    orocos-kdl-devel(x86-64)
    pkgconfig(orocos-kdl)
    pkgconfig(orocos_kdl)

orocos-kdl-doc:
    orocos-kdl-doc

python3-pykdl:
    python-pykdl
    python3-pykdl
    python3-pykdl(x86-64)
    python3.14-pykdl



Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29
Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name orocos-kdl --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Generic, C/C++
Disabled plugins: PHP, Ocaml, Perl, Haskell, SugarActivity, fonts, R, Python, Java
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH


Note You need to log in before you can comment on or make changes to this bug.