Copr build:
https://copr.fedorainfracloud.org/coprs/build/9847533
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2417719-automoc/fedora-rawhide-x86_64/09847533-automoc/fedora-review/review.txt

Found issues:

- Not a valid SPDX expression 'LicenseRef-Callaway-BSD'.
  Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1
- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/automoc
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

> - Not a valid SPDX expression 'LicenseRef-Callaway-BSD'.
>  Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1

i tried use use license-fedora2spdx to convert to SPDX license, sadly it does not work.

>- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/automoc
>  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

It's false positive because automoc package was retired 8+ weeks ago from rawhide. We need to add this package back
in order to build some old qt/kde stuff

Hi Kevin,

I am not sure how i can find a reviewer in short time. You are my favorite. It would be great if you could review it.
Thank you!

it seems the BSD-2-Clause-pkgconf-disclaimer license is correct licence for automoc

 https://spdx.org/licenses/BSD-2-Clause-pkgconf-disclaimer.html

Looking through the specfile, this is compliant to the current packaging guidelines (SPDX License, no legacy %patchN syntax (using %autosetup, so there is no %patch macros to worry about at all), CMake snippets that will work with current CMake macros). Hence, approving this rereview.

That said, you may want to make the following changes (but they are not currently required):
* %cmake_build is recommended over %make_build nowadays. This will be required with CMake switching to Ninja by default, unless you explicitly set the target to "Unix Makefiles". The change https://fedoraproject.org/wiki/Changes/CMake_ninja_default is supposed to be implemented for Fedora 44, but does not seem to have implemented in Rawhide yet, since your Copr build succeeded.
* Likewise, you will want to use %cmake_install instead of "make install". (If you really want to hardcode make, you can use "make install/fast", but see above.)

>* %cmake_build is recommended over %make_build nowadays. This will be required with CMake switching to Ninja by default, unless you explicitly set the target to >"Unix Makefiles". The change https://fedoraproject.org/wiki/Changes/CMake_ninja_default is supposed to be implemented for Fedora 44, but does not seem to have >implemented in Rawhide yet, since your Copr build succeeded.
>* Likewise, you will want to use %cmake_install instead of "make install". (If you really want to hardcode make, you can use "make install/fast", but see above.)

Hi Kevin,
Both are not currently required, we can fix it later after automoc is readded to rawhide.

Thank you for quick review :-)

Kevin, Could you please assign it to you as reviever?

Thanks

The Pagure repository was created at https://src.fedoraproject.org/rpms/automoc

Hi Keven,

do you why i cannot commit the change in rawhide, I still get error:
 git push
Enumerating objects: 39, done.
Counting objects: 100% (39/39), done.
Delta compression using up to 16 threads
Compressing objects: 100% (33/33), done.
Writing objects: 100% (38/38), 30.36 KiB | 30.36 MiB/s, done.
Total 38 (delta 4), reused 33 (delta 4), pack-reused 0 (from 0)
remote: Branch refs/heads/rawhide is unsupported. Cannot push to a disabled branch (maybe eol?).
remote: Denied push for ref 'refs/heads/rawhide' for user 'than'
remote: All changes have been rejected
To ssh://pkgs.fedoraproject.org/rpms/automoc
 ! [remote rejected] rawhide -> rawhide (pre-receive hook declined)
error: failed to push some refs to 'ssh://pkgs.fedoraproject.org/rpms/automoc'

It seems the branch is still disable. Do you konw how i can enable it?

Thank you

The Pagure repository was created at https://src.fedoraproject.org/rpms/automoc

The Pagure repository was created at https://src.fedoraproject.org/rpms/automoc

I think you need to wait some time for the permissions to sync.

The Pagure repository was created at https://src.fedoraproject.org/rpms/automoc

The Pagure repository was created at https://src.fedoraproject.org/rpms/automoc

it's now available in rawhide https://bodhi.fedoraproject.org/updates/FEDORA-2025-a7ec98c94f