Spec URL: https://download.copr.fedorainfracloud.org/results/ahaupt/lesspipe/epel-9-x86_64/09847020-lesspipe/lesspipe.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ahaupt/lesspipe/epel-9-x86_64/09847020-lesspipe/lesspipe-2.21-1.el9.src.rpm Description: lesspipe.sh is an input filter for the pager less. It is able to process a wide variety of file formats. It enables users to deeply inspect archives and to display the contents of files in archives without having to unpack them before. That means file contents can be properly interpreted even if the files are compressed and contained in a hierarchy of archives (often found in RPM or DEB archives containing source tarballs). The filter is easily extensible for new formats. The input filter is a bash script, but works as well as a zsh script. For zsh and bash tab completion mechanisms for archive contents are provided. Fedora Account System Username: ahaupt Successful build in COPR: https://copr.fedorainfracloud.org/coprs/ahaupt/lesspipe/build/9847020/ That's my very first package in Fedora. Following the advise at https://docs.fedoraproject.org/en-US/package-maintainers/New_Package_Process_for_New_Contributors/ I'm asking for a sponsor. I'm in close contact to the main author of the package, Wolfgang Friebel.
Copr build: https://copr.fedorainfracloud.org/coprs/build/9849530 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2417806-lesspipe/fedora-rawhide-x86_64/09849530-lesspipe/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> %{bindir}/lesspipe.sh This will cause conflict, as file are shipped in less package already: $ rpm -qf /usr/bin/lesspipe.sh less-590-6.el9.x86_64 and a package in EPEL9 can't conflict nor replace files in the base distribution.
(In reply to Terje Rosten from comment #2) > > %{bindir}/lesspipe.sh > > This will cause conflict, as file are shipped in less package already: > > $ rpm -qf /usr/bin/lesspipe.sh > less-590-6.el9.x86_64 > > and a package in EPEL9 can't conflict nor replace files in the base > distribution. No, it won't conflict as bindir is defined as: %define bindir %{_prefix}/libexec/%{name} I can rename the macro if this is confusing or breaks other assumptions.
Ok, make convert those %define to %global and move them to the top of file.
(In reply to Terje Rosten from comment #4) > Ok, make convert those %define to %global and move them to the top of file. Next try, %defines are %global now: spec: https://download.copr.fedorainfracloud.org/results/ahaupt/lesspipe/epel-9-x86_64/09849759-lesspipe/lesspipe.spec srpm: https://download.copr.fedorainfracloud.org/results/ahaupt/lesspipe/epel-9-x86_64/09849759-lesspipe/lesspipe-2.21-2.el9.src.rpm
Created attachment 2116646 [details] The .spec file difference from Copr build 9849530 to 9849767
Copr build: https://copr.fedorainfracloud.org/coprs/build/9849767 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2417806-lesspipe/fedora-rawhide-x86_64/09849767-lesspipe/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.