Spec URL: https://rathann.fedorapeople.org/review/perl-Chemistry-Canonicalize/perl-Chemistry-Canonicalize.spec SRPM URL: https://rathann.fedorapeople.org/review/perl-Chemistry-Canonicalize/perl-Chemistry-Canonicalize-0.11-1.fc44.src.rpm Description: This module provides functions for "canonicalizing" a molecular structure; that is, to number the atoms in a unique way regardless of the input order. The canonicalization algorithm is based on: Weininger, et. al., J. Chem. Inf. Comp. Sci. 29[2], 97-101 (1989) This module is part of the PerlMol project. Fedora Account System Username: rathann
Copr build: https://copr.fedorainfracloud.org/coprs/build/9849999 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2417811-perl-chemistry-canonicalize/fedora-rawhide-x86_64/09849999-perl-Chemistry-Canonicalize/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/perl5/vendor_perl/Chemistry(perl-Chemistry-Mol) [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 816 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [ ]: Package contains the mandatory BuildRequires and Requires. [ ]: CPAN urls should be non-versioned. ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: perl-Chemistry-Canonicalize-0.11-1.fc44.noarch.rpm perl-Chemistry-Canonicalize-0.11-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp8k1vv9i7')] checks: 32, packages: 2 perl-Chemistry-Canonicalize.noarch: W: spurious-executable-perm /usr/share/doc/perl-Chemistry-Canonicalize/README perl-Chemistry-Canonicalize.noarch: E: spelling-error ('canonicalizing', '%description -l en_US canonicalizing -> cannibalizing, canalizing, canonizing') perl-Chemistry-Canonicalize.noarch: E: spelling-error ('canonicalization', '%description -l en_US canonicalization -> cannibalization, canalization, canonization') perl-Chemistry-Canonicalize.noarch: E: spelling-error ('Weininger', '%description -l en_US Weininger -> Wining, Veining, Weaning') perl-Chemistry-Canonicalize.noarch: E: spelling-error ('et', '%description -l en_US et -> ET, ETA, eat') perl-Chemistry-Canonicalize.src: E: spelling-error ('canonicalizing', '%description -l en_US canonicalizing -> cannibalizing, canalizing, canonizing') perl-Chemistry-Canonicalize.src: E: spelling-error ('canonicalization', '%description -l en_US canonicalization -> cannibalization, canalization, canonization') perl-Chemistry-Canonicalize.src: E: spelling-error ('Weininger', '%description -l en_US Weininger -> Wining, Veining, Weaning') perl-Chemistry-Canonicalize.src: E: spelling-error ('et', '%description -l en_US et -> ET, ETA, eat') perl-Chemistry-Canonicalize.noarch: E: executable-docs /usr/share/doc/perl-Chemistry-Canonicalize/README 2 packages and 0 specfiles checked; 9 errors, 1 warnings, 7 filtered, 9 badness; has taken 0.2 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 perl-Chemistry-Canonicalize.noarch: W: spurious-executable-perm /usr/share/doc/perl-Chemistry-Canonicalize/README perl-Chemistry-Canonicalize.noarch: E: spelling-error ('canonicalizing', '%description -l en_US canonicalizing -> cannibalizing, scandalizing, nonclinical') perl-Chemistry-Canonicalize.noarch: E: spelling-error ('canonicalization', '%description -l en_US canonicalization -> cannibalization, canonization, radicalization') perl-Chemistry-Canonicalize.noarch: E: spelling-error ('Weininger', '%description -l en_US Weininger -> Weinberg, Wringer, Whinger') perl-Chemistry-Canonicalize.noarch: E: spelling-error ('et', '%description -l en_US et -> ET, wt, rt') perl-Chemistry-Canonicalize.noarch: E: executable-docs /usr/share/doc/perl-Chemistry-Canonicalize/README 1 packages and 0 specfiles checked; 5 errors, 1 warnings, 3 filtered, 5 badness; has taken 0.1 s Source checksums ---------------- https://cpan.metacpan.org/authors/id/I/IT/ITUB/Chemistry-Canonicalize-0.11.tar.gz : CHECKSUM(SHA256) this package : 535d854eed040d4fe96c93bb78454b22a96436a761ab9ea799590a2d3462ad08 CHECKSUM(SHA256) upstream package : 535d854eed040d4fe96c93bb78454b22a96436a761ab9ea799590a2d3462ad08 Requires -------- perl-Chemistry-Canonicalize (rpmlib, GLIBC filtered): perl(Carp) perl(Exporter) perl(Math::BigInt) perl(base) perl(strict) perl(warnings) perl-libs Provides -------- perl-Chemistry-Canonicalize: perl(Chemistry::Canonicalize) perl-Chemistry-Canonicalize Summary: -------- - check dir: /usr/share/perl5/vendor_perl/Chemistry(perl-Chemistry-Mol) the rest is fine package is APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Chemistry-Canonicalize
Thanks for the review! (In reply to Terje Rosten from comment #2) > Summary: > -------- > - check dir: > /usr/share/perl5/vendor_perl/Chemistry(perl-Chemistry-Mol) > the rest is fine This package does not have a dependency on perl-Chemistry-Mol, so I think shared ownership is justified as it installs its module in /usr/share/perl5/vendor_perl/Chemistry, too. I fixed the spurious executable permission on README, too.
FEDORA-2025-03b9a8dea5 (perl-Chemistry-Canonicalize-0.11-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2025-03b9a8dea5
FEDORA-2025-03b9a8dea5 (perl-Chemistry-Canonicalize-0.11-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.