Created attachment 2116772 [details] Configuration file for rust2rpm Spec URL: https://music.fedorapeople.org/rust-qlog.spec SRPM URL: https://music.fedorapeople.org/rust-qlog-0.15.2-1.fc43.src.rpm Description: Qlog data model for QUIC and HTTP/3. Fedora Account System Username: music
Copr build: https://copr.fedorainfracloud.org/coprs/build/9851414 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2417863-rust-qlog/fedora-rawhide-x86_64/09851414-rust-qlog/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/9851415 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2417863-rust-qlog/fedora-rawhide-x86_64/09851415-rust-qlog/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/qlog-0.15.2/COPYING See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files - Harmless ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rust-qlog-devel-0.15.2-1.fc44.noarch.rpm rust-qlog+default-devel-0.15.2-1.fc44.noarch.rpm rust-qlog-0.15.2-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmprgeqcfuc')] checks: 32, packages: 3 3 packages and 0 specfiles checked; 0 errors, 0 warnings, 13 filtered, 0 badness; has taken 0.2 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 9 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://crates.io/api/v1/crates/qlog/0.15.2/download#/qlog-0.15.2.crate : CHECKSUM(SHA256) this package : 0f15b83c59e6b945f2261c95a1dd9faf239187f32ff0a96af1d1d28c4557f919 CHECKSUM(SHA256) upstream package : 0f15b83c59e6b945f2261c95a1dd9faf239187f32ff0a96af1d1d28c4557f919 https://github.com/cloudflare/quiche/raw/refs/tags/qlog-0.15.2/COPYING : CHECKSUM(SHA256) this package : 2ef4b5abfce387a83933bda738e72467a79d15c1c17679143ec55011dae66b84 CHECKSUM(SHA256) upstream package : 2ef4b5abfce387a83933bda738e72467a79d15c1c17679143ec55011dae66b84 Requires -------- rust-qlog-devel (rpmlib, GLIBC filtered): (crate(serde/default) >= 1.0.0 with crate(serde/default) < 2.0.0~) (crate(serde/derive) >= 1.0.0 with crate(serde/derive) < 2.0.0~) (crate(serde_json/default) >= 1.0.0 with crate(serde_json/default) < 2.0.0~) (crate(serde_json/preserve_order) >= 1.0.0 with crate(serde_json/preserve_order) < 2.0.0~) (crate(serde_with) >= 3.3.0 with crate(serde_with) < 4.0.0~) (crate(serde_with/macros) >= 3.3.0 with crate(serde_with/macros) < 4.0.0~) (crate(smallvec) >= 1.10.0 with crate(smallvec) < 2.0.0~) (crate(smallvec/serde) >= 1.10.0 with crate(smallvec/serde) < 2.0.0~) cargo rust-qlog+default-devel (rpmlib, GLIBC filtered): cargo crate(qlog) Provides -------- rust-qlog-devel: crate(qlog) rust-qlog-devel rust-qlog+default-devel: crate(qlog/default) rust-qlog+default-devel Summary: --------- - All good, package is APPROVED
Looks like you used rust2rpm <28 to generate the spec file - please regenerate with v28 before importing. It should fix the Summary that is currently wrongly truncated.
> --- A 2025-11-30 17:48:54.666730564 +0100 > +++ rust-qlog.spec 2025-11-30 17:51:39.566159620 +0100 > @@ -1,4 +1,4 @@ > -# Generated by rust2rpm 27 > +# Generated by rust2rpm 28 > %bcond check 1 > %global debug_package %{nil} > @@ -7,7 +7,7 @@ > Name: rust-qlog > Version: 0.15.2 > Release: %autorelease >-Summary: Data model for QUIC and HTTP/3 >+Summary: Qlog data model for QUIC and HTTP/3 Is this really more correct? There is a rule not to repeat name of package in Summary I think, not a big issue either way.
The rust2rpm 28 version probably is more correct in this particular case, because Qlog in the Summary semantically refers to the qlog logging format, https://github.com/quicwg/qlog, rather than being a simple reiteration of the crate name. In either case, I don’t think it’s terribly important, so I won’t be overriding the summary in rust2rpm.toml. Therefore I might as well go ahead and re-generate with rust2rpm 28, since that’s what I’ll get the next time I touch the spec file anyway. Thank you for the review! https://release-monitoring.org/project/387435/
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-qlog
FEDORA-2025-4042e42747 (rust-qlog-0.15.2-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2025-4042e42747
FEDORA-2025-4042e42747 (rust-qlog-0.15.2-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.