Spec URL: https://rathann.fedorapeople.org/review/perl-Chemistry-File-VRML/perl-Chemistry-File-VRML.spec SRPM URL: https://rathann.fedorapeople.org/review/perl-Chemistry-File-VRML/perl-Chemistry-File-VRML-0.10-1.fc44.src.rpm Description: This module generates a VRML (Virtual Reality Modeling Language) representation of a molecule, which can then be visualized with any VRML viewer. This is a PerlMol file I/O plugin, and registers the 'vrml' format with Chemistry::Mol. Note however that this file plugin is write-only; there's no way of reading a VRML file back into a molecule. This module is a modification of PDB2VRML by Horst Vollhardt, adapted to the Chemistry::File interface. Fedora Account System Username: rathann
Copr build: https://copr.fedorainfracloud.org/coprs/build/9863298 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2418594-perl-chemistry-file-vrml/fedora-rawhide-x86_64/09863298-perl-Chemistry-File-VRML/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Dear Dominik, thanks for trying to bring this into Fedora! The review ticket is quite old meanwhile, but I guess you're still interested, right? There are also some similar tickets for perl-Chemistry-* packages in the pipeline - partly blocking each other. I'd do them later, if nobody else steps in. This will be my first official package review, just as a warning ... I haven't found any blocker, just one thing: as the package does not include a license file, I'm supposed to ask you if you already tried to make upstream aware of this: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Otherwise package is fine.
OK, some missing things: The %{_fixperms} macro only works with: BuildRequires: coreutils As tests are run during build the package Requires should be in BuildRequires as well (in the %if %{with check} block): [host] ~/FedoraReview/2418594-perl-Chemistry-File-VRML/results % rpm -qpR perl-Chemistry-File-VRML-0.10-1.fc45.noarch.rpm perl(Chemistry::File) perl(Chemistry::Mol) perl(POSIX) perl(base) perl(strict) perl(warnings)
Thanks for reviewing this Andreas.