Bug 2419749 - keychain.sh profile file is broken: no key gets loaded
Summary: keychain.sh profile file is broken: no key gets loaded
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: keychain
Version: 43
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Till Maas
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2025-12-07 11:01 UTC by Mathieu
Modified: 2026-03-23 01:07 UTC (History)
5 users (show)

Fixed In Version: keychain-2.9.8-4.fc44 keychain-2.9.8-4.fc42 keychain-2.9.8-4.fc43
Clone Of:
Environment:
Last Closed: 2026-03-23 00:16:07 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Mathieu 2025-12-07 11:01:53 UTC
Hello,

Change to /etc/profile.d/keychain.sh broke loading of ssh keys. Commit is https://src.fedoraproject.org/rpms/keychain/c/99593db08d9bcbb45851b0053f03a179686f000f?branch=f43

The change in question:
-    [ -n "$SSHKEYS" ] || SSHKEYS=`grep -s -l -e '[DRS]S[AH] PRIVATE KEY' \
-                                                          $HOME/.ssh/*`
+    [ -n "$SSHKEYS" ] || SSHKEYS=$(grep -s -l -e '[DRS]S[AH] PRIVATE KEY' \
+                                   "$HOME/.ssh/*")

By introducing quotes around $HOME/.ssh/*, the shell doesn't do globbing. As a result SSHKEYS is always empty and no key is ever added to the keychain.

Reproducible: Always

Comment 1 Fedora Update System 2026-03-14 21:04:48 UTC
FEDORA-2026-1f3bf667c9 (keychain-2.9.8-4.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-1f3bf667c9

Comment 2 Fedora Update System 2026-03-14 21:04:49 UTC
FEDORA-2026-bc7d86311d (keychain-2.9.8-4.fc44) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-bc7d86311d

Comment 3 Fedora Update System 2026-03-14 21:04:49 UTC
FEDORA-2026-7f09c8f23a (keychain-2.9.8-4.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-7f09c8f23a

Comment 4 Fedora Update System 2026-03-15 01:31:37 UTC
FEDORA-2026-bc7d86311d has been pushed to the Fedora 44 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-bc7d86311d`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-bc7d86311d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 5 Fedora Update System 2026-03-15 01:55:34 UTC
FEDORA-2026-1f3bf667c9 has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-1f3bf667c9`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-1f3bf667c9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2026-03-15 02:16:23 UTC
FEDORA-2026-7f09c8f23a has been pushed to the Fedora 43 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-7f09c8f23a`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-7f09c8f23a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2026-03-23 00:16:07 UTC
FEDORA-2026-bc7d86311d (keychain-2.9.8-4.fc44) has been pushed to the Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2026-03-23 00:54:36 UTC
FEDORA-2026-1f3bf667c9 (keychain-2.9.8-4.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2026-03-23 01:07:38 UTC
FEDORA-2026-7f09c8f23a (keychain-2.9.8-4.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.