SPEC: https://pbrobinson.fedorapeople.org/rust-crc32-v2.spec SRPM: https://pbrobinson.fedorapeople.org/rust-crc32-v2-0.0.5-1.fc43.src.rpm Description: Port of the CRC-32 algorithm to Rust FAS: pbrobinson koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=139808691 Fails with s390x Reproducible: Always
> Fails with s390x Tests fail with s390x
Copr build: https://copr.fedorainfracloud.org/coprs/build/9883774 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2419808-rust-crc32-v2/fedora-rawhide-x86_64/09883774-rust-crc32-v2/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> Tests fail with s390x Can you report this upstream please? Alternatively: I am wondering why binwalk even uses this crate. There's no trail in the commit log for *why* it was chosen, it's just added in the initial import of the Rust rewrite. The crc32fast crate has almost 1000x (!) more downloads from crates.io. Maybe binwalk can switch to that one?
> Alternatively: I am wondering why binwalk even uses this crate. There's no > trail in the commit log for *why* it was chosen, it's just added in the > initial import of the Rust rewrite. y I'm not really involved in the upstream so I'm not able to answer that. I took on the Fedora maintainership as it's something I use in the IoT ecosystem in Fedora. > The crc32fast crate has almost 1000x (!) more downloads from crates.io. > Maybe binwalk can switch to that one? Again being a consumer of binwalk I am not the person to make that arguement upstream, would appreciate if you took that discussion upstream as you're by far the expert in the details.
You are the binwalk package maintainer, you are better positioned to approach the upstream project than I am. I made the suggestion to possibly switch to crc32fast because it would be *less work* to ask binwalk upstream about this than dealing with the test/build failures in a library that is not very widely used and not yet packaged for Fedora. If you want to continue with this review, then you will still need to make sure that it builds (and to investigate / report / fix test failures - within reason). I can't approve a package that doesn't build.