Bug 2420488 - Review Request: gst-thumbnailers - GStreamer Thumbnailers
Summary: Review Request: gst-thumbnailers - GStreamer Thumbnailers
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL: https://gitlab.gnome.org/sophie-h/gst...
Whiteboard:
Depends On: 2420487
Blocks:
TreeView+ depends on / blocked
 
Reported: 2025-12-09 11:42 UTC by Fabio Valentini
Modified: 2025-12-11 14:23 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-12-11 14:23:33 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2025-12-09 11:42:00 UTC
Spec URL: https://decathorpe.fedorapeople.org/gst-thumbnailers.spec
SRPM URL: https://decathorpe.fedorapeople.org/gst-thumbnailers-1.0~alpha.1-1.fc43.src.rpm
Upstream URL: https://gitlab.gnome.org/sophie-h/gst-thumbnailers

Description:
GStreamer Thumbnailers.

Fedora Account System Username: decathorpe

Comment 1 Fedora Review Service 2025-12-09 11:44:19 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9889675
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2420488-gst-thumbnailers/fedora-rawhide-x86_64/09889675-gst-thumbnailers/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2025-12-09 11:46:36 UTC
Note that there are some test audio / video files in tests/*.{webm,mkv,mp3,flac}.

At least at first glance, they don't appear to contain any copyrighted / copyrightable material and are really just minimal test cases that appear to have been generated specifically for this purpose.

Comment 3 Neal Gompa 2025-12-10 08:15:37 UTC
Package review notes:

- Packaging follows Fedora packaging guidelines
- Packaging uses correct Rust macros for building and capturing licenses
- Package licensing is correct and license data is installed
- Package builds and installs (with local chain)
- No serious issues from rpmlint

PACKAGE APPROVED.

Suggestions for improving packaging before import:

- Split %meson into %conf stage
- Add a the typical GNOME package macro for translating Version to tarball versions and drop %tag macro

%global tarball_version %%(echo %{version} | tr '~' '.')

Comment 4 Fedora Admin user for bugzilla script actions 2025-12-11 13:24:05 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/gst-thumbnailers

Comment 5 Fedora Update System 2025-12-11 14:20:15 UTC
FEDORA-2025-13fcb268af (gst-thumbnailers-1.0~alpha.1-1.fc44, rust-libglycin-rebind-0.0.1-1.fc44, and 1 more) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-13fcb268af

Comment 6 Fedora Update System 2025-12-11 14:23:33 UTC
FEDORA-2025-13fcb268af (gst-thumbnailers-1.0~alpha.1-1.fc44, rust-libglycin-rebind-0.0.1-1.fc44, and 1 more) has been pushed to the Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.