Spec URL: https://farchord.fedorapeople.org/reviews/keepsecret/keepsecret.spec SRPM URL: https://farchord.fedorapeople.org/reviews/keepsecret/keepsecret-1.0.0-1.fc43.src.rpm Description: KeepSecret is a Password manager GUI intended to be a client for a Secret Service compatible provider. Fedora Account System Username: farchord
Both the code (src/main.cpp) and the .desktop file use the `kwalletmanager` icon. Technically that means this needs to `Requires: kwalletmanager5` to provide the icon, but personally this seems like some sort of shortcut which they took in early development that they missed and they should just get their own icon instead. Could you please raise this upstream? URL should be https://apps.kde.org/keepsecret/ (no /fr/). Otherwise, the spec is straight-forward and per guidelines, and it builds and seems to work fine (tried it in a local flatpak build).
Spec URL: https://farchord.fedorapeople.org/reviews/keepsecret/keepsecret.spec SRPM URL: https://farchord.fedorapeople.org/reviews/keepsecret/keepsecret-1.0.0-1.fc43.src.rpm Updated with reviewer notes
Copr build: https://copr.fedorainfracloud.org/coprs/build/9915059 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2421695-keepsecret/fedora-rawhide-x86_64/09915059-keepsecret/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://farchord.fedorapeople.org/reviews/keepsecret/keepsecret.spec SRPM URL: https://farchord.fedorapeople.org/reviews/keepsecret/keepsecret-1.0.0-1.fc43.src.rpm Fixed icon using upstream PR
Created attachment 2118945 [details] The .spec file difference from Copr build 9915059 to 9915219
Copr build: https://copr.fedorainfracloud.org/coprs/build/9915219 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2421695-keepsecret/fedora-rawhide-x86_64/09915219-keepsecret/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I believe the patch is missing a change to the code; left a comment in the upstream MR. However, while it should be fixed, that is not a blocker to inclusion in Fedora. There are no other issues according to the review criteria. PACKAGE APPROVED. Please remember to add permissions for kde-sig once the repo is created.
The Pagure repository was created at https://src.fedoraproject.org/rpms/keepsecret