Bug 2421941 - [patch] Add config.h to include files of devel package
Summary: [patch] Add config.h to include files of devel package
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: wireshark
Version: 43
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Michal Ruprich
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2025-12-12 23:18 UTC by Bas Mevissen
Modified: 2026-03-26 02:29 UTC (History)
5 users (show)

Fixed In Version: wireshark-4.6.4-2.fc44
Clone Of:
Environment:
Last Closed: 2026-03-26 02:29:54 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Add config.h to devel package (1.09 KB, patch)
2025-12-12 23:19 UTC, Bas Mevissen
no flags Details | Diff
Add config.h to devel package (1.09 KB, patch)
2025-12-13 13:46 UTC, Bas Mevissen
no flags Details | Diff

Description Bas Mevissen 2025-12-12 23:18:47 UTC
To compile wireshark dissectors and plugins out of tree, the config.h used to build the wireshark package is needed. This file is missing from the -devel package.

The attached patch fixes this.


Reproducible: Always

Steps to Reproduce:
Try to build a dissector following directions at https://gitlab.com/cw-wireshark-dissectors/opc-ua-pubsub-uadp-dissector#alternative-approach
Preperation on Fedora:
sudo dnf install wireshark-devel
sudo dnf builddep wireshark

Actual Results:
Build failing due to missing config.h

Expected Results:
Build failing due to dissector not yet compatible with wireshark-4.6.x :-)


Additional Information:
Including the config.h in the development package was inspired by the libwireshark-dev from Ubuntu.

Comment 1 Bas Mevissen 2025-12-12 23:19:55 UTC
Created attachment 2118534 [details]
Add config.h to devel package

Comment 2 Bas Mevissen 2025-12-13 13:46:28 UTC
Created attachment 2118574 [details]
Add config.h to devel package

Comment 3 Bas Mevissen 2025-12-13 13:49:04 UTC
Patch updated to enclose macro in braces.

Comment 4 Bas Mevissen 2025-12-13 22:25:26 UTC
When looking into the Debian and RPM packaging files of wireshark upstream, I noticed a few more tools that are installed by the respecive dev or devel packages:

The tool idl2wrs with backend scripts wireshark_be.py and wireshark_gen.py, the plugin.c creator script make-plugin-reg.py and the asn2wrs.py tool seems to be good candidates.
The idl2wrs tool is actually documented in the currently included readme at /usr/share/doc/wireshark-devel/README.idl2wrs.

Personally, I only used make-plugin-reg.py to regenerate the plugin.c file of a dissector mentioned.

Any thoughts on including these files?

Comment 5 Michal Ruprich 2026-03-04 12:41:43 UTC
Thanks Ben,

sure I'll take a look at the other tools as well. I am doing a rebase now anyway.

Regards,
Michal Ruprich

Comment 6 Michal Ruprich 2026-03-09 11:36:25 UTC
Ok the build is almost ready, do you have a chance to test the tools? I only did a basic sanity tests that nothing is missing and the tool runs but I don't have any real examples to test there:

https://koji.fedoraproject.org/koji/taskinfo?taskID=143160182

I placed the tools under /usr/libexec/wireshark/pytools

Regards,
Michal

Comment 7 Bas Mevissen 2026-03-09 15:17:20 UTC
Hi Michal,

I don't have Rawhide running, but I extracted the tools from the wireshark-devel package, tested the plugin generator and checked for the config.h presence. Seems all fine to me. Thanks!

Comment 8 Bas Mevissen 2026-03-15 21:24:14 UTC
Hi Michal,

Would it be possible to start a Fedora 44 build of this updated package?

Comment 9 Michal Ruprich 2026-03-17 12:01:32 UTC
Hi,

sure - https://src.fedoraproject.org/rpms/wireshark/pull-request/119 

Regards,
Michal

Comment 10 Fedora Update System 2026-03-17 14:19:53 UTC
FEDORA-2026-71154797a5 (wireshark-4.6.4-2.fc44) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-71154797a5

Comment 11 Fedora Update System 2026-03-18 01:29:39 UTC
FEDORA-2026-71154797a5 has been pushed to the Fedora 44 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-71154797a5`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-71154797a5

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Bas Mevissen 2026-03-19 13:46:06 UTC
Works fine for me on Fedora 44, thanks!

Comment 13 Fedora Update System 2026-03-26 02:29:54 UTC
FEDORA-2026-71154797a5 (wireshark-4.6.4-2.fc44) has been pushed to the Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.