Spec URL: https://www.flyn.org/SRPMS/python-sounddevice.spec SRPM URL: https://www.flyn.org/SRPMS/python-sounddevice-0.5.3-1.fc43.src.rpm Description: Play and record sound with Python Fedora Account System Username: mikep
This is required for some of the functionality provided by our python3-pocketsphinx package.
Copr build: https://copr.fedorainfracloud.org/coprs/build/9909063 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2422137-python-sounddevice/fedora-rawhide-x86_64/09909063-python-sounddevice/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://www.flyn.org/SRPMS/python-sounddevice.spec SRPM URL: https://www.flyn.org/SRPMS/python-sounddevice-0.5.3-1.fc43.src.rpm Description: Play and record sound with Python Fedora Account System Username: mikep - Add BuildRequires for portaudio
Created attachment 2118750 [details] The .spec file difference from Copr build 9909063 to 9909885
Copr build: https://copr.fedorainfracloud.org/coprs/build/9909885 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2422137-python-sounddevice/fedora-rawhide-x86_64/09909885-python-sounddevice/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.14/site- packages, /usr/lib/python3.14, /usr/lib/python3.14/site- packages/__pycache__ [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [!]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 622 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: https://github.com/spatialaudio/python- sounddevice/archive/v0.5.3/python-sounddevice-0.5.3.tar.gz See: https://docs.fedoraproject.org/en-US/packaging- guidelines/SourceURL/ [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Nitpick - you may consider using Python declarative buildsystem. See bottom of the page https://src.fedoraproject.org/rpms/pyproject-rpm-macros/blob/rawhide/f/README.md This is up to your preference and I do not require this for the review. In the changelog, you have * Sun Dec 14 2025 W. Michael Petullo <mike> - 2:5.0.4-3 The number 2: will be interpreted as epoch. And you do not use it (and that is good). Please remove this part ("2:) Source0 could not be downloaded. This is blocker for the review. The macro resolves to https://github.com/spatialaudio/python-sounddevice/archive/v0.5.3/python-sounddevice-0.5.3.tar.gz and this does not exist.
Spec URL: https://www.flyn.org/SRPMS/python-sounddevice.spec SRPM URL: https://www.flyn.org/SRPMS/python-sounddevice-0.5.3-1.fc43.src.rpm Description: Play and record sound with Python Fedora Account System Username: mikep - Fixed changlog - Fixed Source0
Created attachment 2120705 [details] The .spec file difference from Copr build 9909885 to 9968423
Copr build: https://copr.fedorainfracloud.org/coprs/build/9968423 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2422137-python-sounddevice/fedora-rawhide-x86_64/09968423-python-sounddevice/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
All comments were addressed. So... APPROVED
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-sounddevice
FEDORA-2026-737acfd525 (python-sounddevice-0.5.3-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2026-737acfd525
FEDORA-2026-737acfd525 (python-sounddevice-0.5.3-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.