Red Hat Bugzilla – Bug 242421
please add support for cryptsetup-luks UUIDs
Last modified: 2007-11-30 17:12:06 EST
Description of problem:
libblkid currently can't detect luks UUIDs. If we'd like to support encrypted
filesystems (dm-crypt) without having to rely on hardcoded device names, a patch
like the attached one is required.
This patch has been sent to the upstream maintainer and has been posted at
without getting any response yet.
Created attachment 156054 [details]
+ blkid_set_tag(probe->dev, "SEC_TYPE", "crypt_LUKS", sizeof("luks"));
I assume that should be sizeof("crypt_LUKS") right... and should bim_type in
type_array still be just "luks" not "crypt_LUKS?"
Also, what do you think about not specifying the luks magic twice, but instead
using it from the passed-in id, i.e:
static int probe_luks(struct blkid_probe *probe,
struct blkid_magic *id,
unsigned char *buf)
const char *luks_magic = id->bim_magic;
I'd rather have that magic string in once central place.
You're right, the 'luks' string is a relict from the first patch where I've used
this and didn't change it everywhere to 'crypt_LUKS' like Karel suggested.
No objection to having the magic string in one central place, that's much cleaner.
What's the status here ?
I've sent a new patch upstream with all the comments/suggestions from the FS
Sorry, forgot to update the bug. I put that lateste patch into FC devel yesterday.
I'll probably leave the bug open 'til I see the actual same patch get upstream.
Tytso added it upstream today, he did only some whitespace changes.
Closing since the patch went in upstream. Thanks!
Karsten, will you need this in FC6 or 7?
Quite unlikely, but thanks for asking ;-)