Spec URL: https://asn.fedorapeople.org/rust-enum-ordinalize-derive.spec SRPM URL: https://asn.fedorapeople.org/rust-enum-ordinalize-derive-4.3.2-1.fc44.src.rpm Upstream URL: https://crates.io/crates/enum-ordinalize-derive Description: This crate provides a procedural macro that enables enums to not only obtain the ordinal values of their variants but also allows for the construction of enums from an ordinal value. Fedora Account System Username: asn
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=140268510
rust2rpm.toml [package] summary = "Enums can get and construct from ordinal values with a procedural macro" The package is required to update rust-educe to version 0.6. It is a new dependency.
Copr build: https://copr.fedorainfracloud.org/coprs/build/9940663 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2424264-rust-enum-ordinalize-derive/fedora-rawhide-x86_64/09940663-rust-enum-ordinalize-derive/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
The package is APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) === Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated The spec file is generated by rust2rpm, greatly simplifying the review. The only customization is that the Summary is shortened to fit within 80 characters. This is correct and necessary, and the chosen text is reasonable. If you have not already done so, you can add this to a rust2rpm.toml file: [package] summary = "Enums can get and construct from ordinal values with a procedural macro" Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/enum- ordinalize-derive-4.3.2/LICENSE See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files OK: this is harmless and is due to a reasonable design decision in rust2rpm. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License". 10 files have unknown license. Detailed output of licensecheck in /home/ben/fedora/review/2424264-rust-enum-ordinalize- derive/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- enum-ordinalize-derive-devel , rust-enum-ordinalize-derive+default- devel , rust-enum-ordinalize-derive+traits-devel [?]: Package functions as described. Tests are properly compiled and executed, but the crate does not currently actually include any usable tests. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. https://koji.fedoraproject.org/koji/taskinfo?taskID=140501997 [x]: %check is present and all tests pass. Tests are properly compiled and executed, but the crate does not currently actually include any usable tests. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) OK: differences are solely due to rpmautospec macro expansion [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: rust-enum-ordinalize-derive-devel-4.3.2-1.fc44.noarch.rpm rust-enum-ordinalize-derive+default-devel-4.3.2-1.fc44.noarch.rpm rust-enum-ordinalize-derive+traits-devel-4.3.2-1.fc44.noarch.rpm rust-enum-ordinalize-derive-4.3.2-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp5520go1m')] checks: 32, packages: 4 rust-enum-ordinalize-derive+default-devel.noarch: E: spelling-error ('Enums', 'Summary(en_US) Enums -> Menus, Plenums') rust-enum-ordinalize-derive+default-devel.noarch: E: spelling-error ('enums', '%description -l en_US enums -> menus, plenums') rust-enum-ordinalize-derive+traits-devel.noarch: E: spelling-error ('Enums', 'Summary(en_US) Enums -> Menus, Plenums') rust-enum-ordinalize-derive+traits-devel.noarch: E: spelling-error ('enums', '%description -l en_US enums -> menus, plenums') rust-enum-ordinalize-derive.src: E: spelling-error ('Enums', 'Summary(en_US) Enums -> Menus, Plenums') rust-enum-ordinalize-derive.src: E: spelling-error ('enums', '%description -l en_US enums -> menus, plenums') rust-enum-ordinalize-derive-devel.noarch: E: spelling-error ('Enums', 'Summary(en_US) Enums -> Menus, Plenums') rust-enum-ordinalize-derive-devel.noarch: E: spelling-error ('enums', '%description -l en_US enums -> menus, plenums') 4 packages and 0 specfiles checked; 8 errors, 0 warnings, 19 filtered, 8 badness; has taken 0.2 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 rust-enum-ordinalize-derive-devel.noarch: E: spelling-error ('Enums', 'Summary(en_US) Enums -> Menus, Plenums') rust-enum-ordinalize-derive-devel.noarch: E: spelling-error ('enums', '%description -l en_US enums -> menus, plenums') rust-enum-ordinalize-derive+traits-devel.noarch: E: spelling-error ('Enums', 'Summary(en_US) Enums -> Menus, Plenums') rust-enum-ordinalize-derive+traits-devel.noarch: E: spelling-error ('enums', '%description -l en_US enums -> menus, plenums') rust-enum-ordinalize-derive+default-devel.noarch: E: spelling-error ('Enums', 'Summary(en_US) Enums -> Menus, Plenums') rust-enum-ordinalize-derive+default-devel.noarch: E: spelling-error ('enums', '%description -l en_US enums -> menus, plenums') 3 packages and 0 specfiles checked; 6 errors, 0 warnings, 15 filtered, 6 badness; has taken 0.1 s Source checksums ---------------- https://crates.io/api/v1/crates/enum-ordinalize-derive/4.3.2/download#/enum-ordinalize-derive-4.3.2.crate : CHECKSUM(SHA256) this package : 8ca9601fb2d62598ee17836250842873a413586e5d7ed88b356e38ddbb0ec631 CHECKSUM(SHA256) upstream package : 8ca9601fb2d62598ee17836250842873a413586e5d7ed88b356e38ddbb0ec631 Requires -------- rust-enum-ordinalize-derive-devel (rpmlib, GLIBC filtered): (crate(proc-macro2/default) >= 1.0.0 with crate(proc-macro2/default) < 2.0.0~) (crate(quote/default) >= 1.0.0 with crate(quote/default) < 2.0.0~) (crate(syn/default) >= 2.0.0 with crate(syn/default) < 3.0.0~) cargo rust rust-enum-ordinalize-derive+default-devel (rpmlib, GLIBC filtered): cargo crate(enum-ordinalize-derive) rust-enum-ordinalize-derive+traits-devel (rpmlib, GLIBC filtered): cargo crate(enum-ordinalize-derive) Provides -------- rust-enum-ordinalize-derive-devel: crate(enum-ordinalize-derive) rust-enum-ordinalize-derive-devel rust-enum-ordinalize-derive+default-devel: crate(enum-ordinalize-derive/default) rust-enum-ordinalize-derive+default-devel rust-enum-ordinalize-derive+traits-devel: crate(enum-ordinalize-derive/traits) rust-enum-ordinalize-derive+traits-devel Diff spec file in url and in SRPM --------------------------------- --- /home/ben/fedora/review/2424264-rust-enum-ordinalize-derive/srpm/rust-enum-ordinalize-derive.spec 2025-12-30 00:47:41.512942541 +0000 +++ /home/ben/fedora/review/2424264-rust-enum-ordinalize-derive/srpm-unpacked/rust-enum-ordinalize-derive.spec 2025-12-22 00:00:00.000000000 +0000 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.8.3) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + # Generated by rust2rpm 27 %bcond check 1 @@ -80,3 +90,6 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Mon Dec 22 2025 Andreas Schneider <asn> - 4.3.2-1 +- Initial package version 4.3.2 +## END: Generated by rpmautospec Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -b 2424264 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: R, C/C++, SugarActivity, Perl, Java, Haskell, fonts, Ocaml, PHP, Python Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-enum-ordinalize-derive