Spec URL: https://mtasaka.fedorapeople.org/Review_request/gem-related/rubygem-minitest-mock.spec SRPM URL: https://mtasaka.fedorapeople.org/Review_request/gem-related/rubygem-minitest-mock-5.27.0-1.fc44.src.rpm Description: minitest/mock, by Steven Baker, is a beautifully tiny mock (and stub) object framework. The minitest-mock gem is an extraction of minitest/mock.rb from minitest in order to make it easier to maintain independent of minitest. Fedora Account System Username: mtasaka
Copr build: https://copr.fedorainfracloud.org/coprs/build/9941234 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2424295-rubygem-minitest-mock/fedora-rawhide-x86_64/09941234-rubygem-minitest-mock/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Taking for a review. This will be needed by Ruby on Rails and other components for Minitest 6 compatibility.
# rpmlint "summary-too-long" The summary should likely be shorten. # Dependency on `rubygem(hoe)` I don't see that `hoe` would be needed to build the package. Am I missing something? # The disable `assert` would deserve better reference If I understand correctly, this change is the reason for the test failure: https://github.com/minitest/minitest/commit/2572c78420af73dbe9b202d535a1474405a32173 I would not mind if the reference was there. # Removal of tests, etc I would not mind if the tests / Rakefile / etc were kept as part of the -doc subpackage.
Above, there is a few remarks listed by priority. Please consider fixing those. However nothing serious, therefore => APPROVED.
Thank you for review! Actually BR: rubygem(hoe) is not needed, I will remove this. Also I will take a look at the above commit.
The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-minitest-mock
FEDORA-2025-849c8baa10 (rubygem-minitest-mock-5.27.0-2.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2025-849c8baa10
FEDORA-2025-849c8baa10 (rubygem-minitest-mock-5.27.0-2.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.