Bug 242459 - Wrong init script
Summary: Wrong init script
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: iptables
Version: rawhide
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Thomas Woerner
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 242457
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-06-04 12:26 UTC by Michal Marciniszyn
Modified: 2014-02-10 23:02 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2007-08-29 14:51:52 UTC


Attachments (Terms of Use)

Description Michal Marciniszyn 2007-06-04 12:26:33 UTC
+++ This bug was initially created as a clone of Bug #242457 +++

Description of problem:
ip6tables and iptables init scripts contain several bugs. Both of them wrongly
return error codes and also call of status code is not correct. For example
if lsmod 2>/dev/null | grep -q ipchains ; then
    echo -n $"ipchains and $IPTABLES can not be used together."; warning; echo
    exit 0
fi
should not return exit code 0. Also status shoud be run always (irrespectible
whether the service could be successfully started).

Version-Release number of selected component (if applicable):
all

How reproducible:
always

Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
When fixing this bug, please obbey our init script guidelines and be sure that
status command is run correctly.
Our guidelines are on following two pages:
http://intranet.corp.redhat.com/ic/intranet/InitscriptsSpec.html
http://intranet.corp.redhat.com/ic/intranet/InitscriptGuidelines.html

For an example of the script that returns the error codes correctly and always
runs status see:
http://devserv.devel.redhat.com/~mmarcini/amd

This bug is tracked by 237789.

Comment 1 Thomas Woerner 2007-08-23 09:42:24 UTC
What exactly do you mean with "Also status shoud be run always (irrespectible
whether the service could be successfully started)." ?


Comment 2 Michal Marciniszyn 2007-08-23 10:26:54 UTC
Yes, exactly, irrespectible of that. Harald had created excellent guidelines for
fedora (keeping in mind LSB header and other stuff needed for parallel boot and
several other improvements and also some corner cases):

http://fedoraproject.org/wiki/FCNewInit/

if you would be so kind and make initscript following these, it would be excellent.

Comment 3 Thomas Woerner 2007-08-29 14:51:52 UTC
Fixed in rawhide in package iptables-1.3.8-2.fc8.


Note You need to log in before you can comment on or make changes to this bug.