spec: https://fed500.fedorapeople.org/libredwg.spec srpm: https://fed500.fedorapeople.org/libredwg-0.13.3-1.fc43.src.rpm description: GNU LibreDWG is a free C library to handle DWG files. LibreDWG is in beta development stage. Not all planned features are yet completed, but the API should stay mostly stable. At the moment our decoder (i.e. reader) is done, just some very advanced R2010+ entities fail to read and are skipped over. The writer is good enough for R1.1 - R2000. Among the example applications we wrote using LibreDWG is a reader (from dwg, dxf, json), a writer (convert from dwg, dxf, json or add from scratch), a rewriter (i.e. saveas), an initial SVG and Postscript conversion, converters from and to DXF and JSON, dwggrep to search for text, and dwglayer to print the list of layers. fas: fed500 Reproducible: Always
Hello, As part of my Fedora packager sponsorship process, this is my mock review using the original .spec and .src.rpm files submitted in this Bugzilla. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - The license file should be present in all sub-packages that don't depends on the main package - %{_includedir} should be used for line "ln -s /usr/include/jsmn/jsmn.h jsmn/jsmn.h" - Why libasan and libubsan are required? - autoreconf should be put in the %prep section because it prepare the files for configure - "All patches in Fedora spec files SHOULD have a comment above them about their upstream status" - Enumerates patches, use Patch0:, Patch1:, ... instead of Patch: - load_dwg.py should be moved in the python3-LibreDWG? - if bindings are useful why use conditional build for them and not enabled them by default? - to avoid changing every time the %{_libdir}/libredwg.so.0.0.13 line in %{_libdir}/libredwg.so.0{,.*} - remove extra white and the end of the line 72. - %make_build check should be used instead of make check in order execute tests in parallel - pcre2-devel is already specified as build dependency so there is no need to specificy also pcre2 ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [!]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [!]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [-]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1187840 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Package should not use obsolete m4 macros [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: libredwg-0.13.3-1.fc45.x86_64.rpm libredwg-devel-0.13.3-1.fc45.x86_64.rpm libredwg-0.13.3-1.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpqloanllo')] checks: 32, packages: 3 libredwg.src: E: spelling-error ('dxf', '%description -l en_US dxf -> def') libredwg.src: E: spelling-error ('json', '%description -l en_US json -> son, j son, soon') libredwg.src: E: spelling-error ('rewriter', '%description -l en_US rewriter -> rewrite, rewrites, re writer') libredwg.src: E: spelling-error ('saveas', "%description -l en_US saveas -> saves, savers, save's") libredwg.src: E: spelling-error ('dwggrep', '%description -l en_US dwggrep -> grepped') libredwg.src: E: spelling-error ('dwglayer', '%description -l en_US dwglayer -> waylayer') libredwg.x86_64: E: spelling-error ('dxf', '%description -l en_US dxf -> def') libredwg.x86_64: E: spelling-error ('json', '%description -l en_US json -> son, j son, soon') libredwg.x86_64: E: spelling-error ('rewriter', '%description -l en_US rewriter -> rewrite, rewrites, re writer') libredwg.x86_64: E: spelling-error ('saveas', "%description -l en_US saveas -> saves, savers, save's") libredwg.x86_64: E: spelling-error ('dwglayer', '%description -l en_US dwglayer -> waylayer') libredwg.x86_64: E: non-executable-script /usr/share/libredwg/load_dwg.py 644 /usr/bin/env python3 3 packages and 0 specfiles checked; 12 errors, 0 warnings, 60 filtered, 12 badness; has taken 1.8 s Rpmlint (debuginfo) ------------------- Checking: libredwg-debuginfo-0.13.3-1.fc45.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp6h18zyj5')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 33 filtered, 0 badness; has taken 2.4 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 libredwg.x86_64: E: spelling-error ('dxf', '%description -l en_US dxf -> def') libredwg.x86_64: E: spelling-error ('json', '%description -l en_US json -> son, j son, soon') libredwg.x86_64: E: spelling-error ('rewriter', '%description -l en_US rewriter -> rewrite, rewrites, re writer') libredwg.x86_64: E: spelling-error ('saveas', "%description -l en_US saveas -> saves, savers, save's") libredwg.x86_64: E: spelling-error ('dwglayer', '%description -l en_US dwglayer -> waylayer') libredwg.x86_64: E: non-executable-script /usr/share/libredwg/load_dwg.py 644 /usr/bin/env python3 3 packages and 0 specfiles checked; 6 errors, 0 warnings, 101 filtered, 6 badness; has taken 3.1 s Source checksums ---------------- https://ftp.gnu.org/gnu/libredwg/libredwg-0.13.3.tar.xz : CHECKSUM(SHA256) this package : 83f1f6e78a744777a481ff4520e4cef3f8ac4b2c1c25671077ca12fe81e8816e CHECKSUM(SHA256) upstream package : 83f1f6e78a744777a481ff4520e4cef3f8ac4b2c1c25671077ca12fe81e8816e https://ftp.gnu.org/gnu/libredwg/libredwg-0.13.3.tar.xz.sig : CHECKSUM(SHA256) this package : 64f6a5a30f47c830399a6ab860d2b59d9b322bbb5aec794710864ea290ddac09 CHECKSUM(SHA256) upstream package : 64f6a5a30f47c830399a6ab860d2b59d9b322bbb5aec794710864ea290ddac09 Using local file /home/fabio/fedora/libredwg/2895a881d34270fabfe8f747b4f63339e65d6414.asc as upstream file:///home/fabio/fedora/libredwg/2895a881d34270fabfe8f747b4f63339e65d6414.asc : CHECKSUM(SHA256) this package : 65e5679b1860449b4aad0a4ec26a3225454c591db77d966f4a67ede9c423360f CHECKSUM(SHA256) upstream package : 65e5679b1860449b4aad0a4ec26a3225454c591db77d966f4a67ede9c423360f Requires -------- libredwg (rpmlib, GLIBC filtered): /usr/bin/sh libc.so.6()(64bit) libm.so.6()(64bit) libmimalloc.so.2()(64bit) libpcre2-16.so.0()(64bit) libpcre2-16.so.0(PCRE2_10.47)(64bit) libpcre2-8.so.0()(64bit) libpcre2-8.so.0(PCRE2_10.47)(64bit) libps.so.0()(64bit) libredwg.so.0()(64bit) rtld(GNU_HASH) libredwg-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libredwg(x86-64) libredwg.so.0()(64bit) Provides -------- libredwg: libredwg libredwg(x86-64) libredwg.so.0()(64bit) libredwg-devel: libredwg-devel libredwg-devel(x86-64) pkgconfig(libredwg) Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -b 2424814 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, C/C++, Generic Disabled plugins: PHP, Haskell, R, Python, Perl, fonts, Ocaml, Java, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH