Red Hat Bugzilla – Bug 242544
Review Request: xbiso - an ISO extraction utility for xdvdfs images
Last modified: 2007-11-30 17:12:06 EST
Spec URL: http://www.auroralinux.org/people/spot/review/xbiso.spec
SRPM URL: http://www.auroralinux.org/people/spot/review/xbiso-0.6.1-1.fc7.src.rpm
Description: xbiso is an ISO extraction utility for xdvdfs images.
Note: This is a BuildRequires for AcetoneISO (242543)
I will do a full review tomorrow, it is almost midnight here :-)
OK source files match upstream:
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK build root is correct.
OK license field matches the actual license.
OK license is open source-compatible. License text included in package.
OK latest version is being packaged.
OK BuildRequires are proper.
OK compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (i386) and FC-6 (x86_64).
OK debuginfo package looks complete.
OK rpmlint is silent.
OK final provides and requires look sane
OK no shared libraries are added to the regular linker search paths.
OK doesn't owns any new directories
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK no scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
OK not a GUI app.
Everything is good, so the package is APPROVED
Doin my own CVS, workin for the man, singin my song, cvs is done.
Package Name: xbiso
Short Description: An ISO extraction utility for xdvdfs images
Branches: FC-5 FC-6 F-7
Built and pushing forward. Thanks for the review.
xbiso-0.6.1-1.fc7 has been pushed to the Fedora 7 testing repository. If problems still persist, please make note of it in this bug report.
xbiso-0.6.1-1.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report.