Spec URL: https://farchord.fedorapeople.org/reviews/Kontainer/Kontainer.spec SRPM URL: https://farchord.fedorapeople.org/reviews/Kontainer/Kontainer-1.3.0-1.fc43.src.rpm Description: A Kirigami Distrobox GUI. Fedora Account System Username: farchord
Copr build: https://copr.fedorainfracloud.org/coprs/build/9954038 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2425662-kontainer/fedora-rawhide-x86_64/09954038-Kontainer/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Taking this review.
Spec review: > # Important Note: This is an application using KDE frameworks, > # but it is not an official KDE project This literally doesn't matter, drop it. > Name: Kontainer It's preferred that we use lowercase here. > Source0: %{url}/archive/refs/tags/%{version}.tar.gz This should use the proper SourceURL form for GitHub: "%{url}/archive/%{version}/%{name}-%{version}.tar.gz" (This works once you update to lowercase name.) > %find_lang kontainer > [...] > %files -f kontainer.lang This can use %{name} once the package name is changed to lowercase. Other spec notes: This package requires a dependency on "distrobox" as it doesn't support toolbx yet.
Spec URL: https://farchord.fedorapeople.org/reviews/kontainer/kontainer.spec SRPM URL: https://farchord.fedorapeople.org/reviews/kontainer/kontainer-1.3.0-1.fc43.src.rpm Updated spec to reflect reviewer notes
Created attachment 2120409 [details] The .spec file difference from Copr build 9954038 to 9957738
Copr build: https://copr.fedorainfracloud.org/coprs/build/9957738 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2425662-kontainer/fedora-rawhide-x86_64/09957738-kontainer/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://farchord.fedorapeople.org/reviews/kontainer/kontainer.spec SRPM URL: https://farchord.fedorapeople.org/reviews/kontainer/kontainer-1.3.0-1.fc43.src.rpm Fixed autosetup naming
Created attachment 2120410 [details] The .spec file difference from Copr build 9957738 to 9957781
Copr build: https://copr.fedorainfracloud.org/coprs/build/9957781 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2425662-kontainer/fedora-rawhide-x86_64/09957781-kontainer/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> Requires: distrobox%{?_isa} distrobox is a shell script, so it's a noarch package. Drop the "%{?_isa}".
Spec URL: https://farchord.fedorapeople.org/reviews/kontainer/kontainer.spec SRPM URL: https://farchord.fedorapeople.org/reviews/kontainer/kontainer-1.3.0-1.fc43.src.rpm Fixed distrobox
Created attachment 2120543 [details] The .spec file difference from Copr build 9957781 to 9961740
Copr build: https://copr.fedorainfracloud.org/coprs/build/9961740 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2425662-kontainer/fedora-rawhide-x86_64/09961740-kontainer/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.