Bug 2425714 - Review Request: rubygem-minitest-global_expectations - Support minitest expectation methods for all objects
Summary: Review Request: rubygem-minitest-global_expectations - Support minitest expec...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Vít Ondruch
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/jeremyevans/minite...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2025-12-29 07:56 UTC by Mamoru TASAKA
Modified: 2026-01-06 14:11 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2026-01-06 14:11:23 UTC
Type: ---
Embargoed:
vondruch: fedora-review+


Attachments (Terms of Use)

Description Mamoru TASAKA 2025-12-29 07:56:11 UTC
Spec URL: https://mtasaka.fedorapeople.org/Review_request/gem-related/rubygem-minitest-global_expectations.spec
SRPM URL: https://mtasaka.fedorapeople.org/Review_request/gem-related/rubygem-minitest-global_expectations-1.0.2-1.fc44.src.rpm
Description: 
minitest-global_expectations allows you to keep using simple code in your
minitest specs, without having to wrap every single object you are calling
an expectation method on with an underscore.

Fedora Account System Username: mtasaka

Note:
With this Minitest 6 change:

https://github.com/minitest/minitest/blob/edd37ce7240a645054485b8c470927765e65351b/History.rdoc?plain=1#L30
minitest/spec expectations is removed from ruby's "generic" Object. This package
restores previous behavior, which is widely used in rubygem-rack and its series.

Comment 1 Fedora Review Service 2025-12-29 07:59:12 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9957348
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2425714-rubygem-minitest-global_expectations/fedora-rawhide-x86_64/09957348-rubygem-minitest-global_expectations/fedora-review/review.txt

Found issues:

- License file MIT-LICENSE.html is not marked as %license
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Vít Ondruch 2026-01-06 11:34:24 UTC
Taking for a review.

Comment 3 Vít Ondruch 2026-01-06 11:51:53 UTC
This is very minimalist package and I can't see anything wrong with it => APPROVED

Comment 4 Mamoru TASAKA 2026-01-06 12:07:05 UTC
Thank you for review!

Comment 5 Fedora Admin user for bugzilla script actions 2026-01-06 12:08:54 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-minitest-global_expectations

Comment 6 Fedora Update System 2026-01-06 14:06:33 UTC
FEDORA-2026-38d8f51787 (rubygem-minitest-global_expectations-1.0.2-1.fc44) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-38d8f51787

Comment 7 Fedora Update System 2026-01-06 14:11:23 UTC
FEDORA-2026-38d8f51787 (rubygem-minitest-global_expectations-1.0.2-1.fc44) has been pushed to the Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.