Spec URL: https://topazus.fedorapeople.org/python-lmfit.spec SRPM URL: https://topazus.fedorapeople.org/python-lmfit-1.3.4-1.fc44.src.rpm Description: Non-Linear Least Squares Minimization Fedora Account System Username: topazus
koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=140548689
Copr build: https://copr.fedorainfracloud.org/coprs/build/9964769 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2426455-python-lmfit/fedora-rawhide-x86_64/09964769-python-lmfit/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I have some suggestions I hope you will consider, below, but the package is APPROVED as-is. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== Notes ===== This is not harmful or wrong, but it is not required: BuildRequires: python3-devel That’s because it is implied by: BuildSystem: pyproject Even having %pyproject_buildrequires would be an adequate substitute for an explicit BR on python3-devel. I suggest removing the explicit BR. https://src.fedoraproject.org/rpms/python-absl-py/pull-request/4#comment-211814 https://pagure.io/packaging-committee/pull-request/1379 ---- This is unnecessary, so I suggest removing it. BuildOption(prep): -n lmfit-py-%{version} The default %prep for the pyproject buildsystem looks like: %autosetup -p1 -C and thanks to the -C, we don’t have to be explicit about the name of the extraction directory. ---- Consider replacing %check %pytest with %check -a %pytest to preserve the default %pyproject_check_import “smoke test” in addition to the test suite. This by no means required, but the import check is “cheap,” and I do find that it sometimes catches problems in packages where the tests don’t import every module. (This particular test suite does look pretty thorough.) ---- Consider passing the -rs option to %pytest to ask it to print the reasons for skipped tests. This will inform you that a few more tests could be enabled by adding BuildRequires on packages like matplotlib and pandas. You might reasonably decide that these heavy (and sometimes broken in Rawhide) dependencies are not worth it just to run a few more tests, but at least it’s a conscious and informed decision. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-Clause License". 188 files have unknown license. Detailed output of licensecheck in /home/ben/fedora/review/2426455-python-lmfit/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.14, /usr/lib/python3.14/site-packages OK: spurious, since python3-libs owns these. [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. The package cites some code as taken from scipy, but I don’t see anything that looks like it needs to be indicated as bundling. The scipy license is also BSD-3-Clause, and its text is included in the main license file. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. (tests pass) [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. Scratch build forced to run on all architectures: https://koji.fedoraproject.org/koji/taskinfo?taskID=140801042 [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-lmfit-1.3.4-1.fc44.noarch.rpm python-lmfit-1.3.4-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp7a5w4lsa')] checks: 32, packages: 2 python3-lmfit.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 7 filtered, 0 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 python3-lmfit.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 3 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/lmfit/lmfit-py/archive/1.3.4/lmfit-py-1.3.4.tar.gz : CHECKSUM(SHA256) this package : f40628814051140ac6a7a7c17ee075bb33fac0b00ccd32ff8bd73eebb35e0f40 CHECKSUM(SHA256) upstream package : f40628814051140ac6a7a7c17ee075bb33fac0b00ccd32ff8bd73eebb35e0f40 Requires -------- python3-lmfit (rpmlib, GLIBC filtered): python(abi) python3.14dist(asteval) python3.14dist(dill) python3.14dist(numpy) python3.14dist(scipy) python3.14dist(uncertainties) Provides -------- python3-lmfit: python-lmfit python3-lmfit python3.14-lmfit python3.14dist(lmfit) python3dist(lmfit) Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -b 2426455 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, Python Disabled plugins: Java, Haskell, SugarActivity, R, PHP, Ocaml, Perl, C/C++, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Thanks for reviewing this package. I will adopt your suggestions when importing.
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-lmfit
FEDORA-2026-c25a897275 (python-lmfit-1.3.4-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2026-c25a897275
FEDORA-2026-c25a897275 (python-lmfit-1.3.4-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.