Spec URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/09983849-python-py-key-value/python-py-key-value.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/09983849-python-py-key-value/python-py-key-value-0.3.0-1.fc44.src.rpm Description: This library provides a pluggable interface for key-value stores with support for multiple backends, TTL handling, type safety, and extensible wrappers. Fedora Account System Username: carlwgeorge
Copr build: https://copr.fedorainfracloud.org/coprs/build/9983873 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2427769-python-py-key-value/fedora-rawhide-x86_64/09983873-python-py-key-value/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> It's much easier to just remove it from the metadata and manually specify the dependency here. Any Python tool that reads the dependency metadata will not see this. A better approach might be to use %pyproject_buildrequires -R for that package, but keep the runtime dependency.
(In reply to Miro Hrončok from comment #2) > Any Python tool that reads the dependency metadata will not see this. A > better approach might be to use %pyproject_buildrequires -R for that > package, but keep the runtime dependency. Another workable approach, which is ugly in its own way but allows you to avoid patching and still generate any other runtime dependencies, is something like this: %generate_buildrequires ( %pyproject_buildrequires […] […] # Avoid generating dependencies that are satisfied within this source package: ) | grep -vE '\bkey-value-'
Note that depending on the type of the dependency, when %pyproject_buildrequires generates it, it might restart in order ot have it installed (but it won't). I believe this does not happen with runtime dependencies, but there is no guarantee. I would not call this supported. See bz2386906 for a potentially supported way of doing this.
> Any Python tool that reads the dependency metadata will not see this. A better approach might be to use %pyproject_buildrequires -R for that package, but keep the runtime dependency. Unfortunately this causes the build to fail with an error about the -R and -x options being mutually exclusive. I've implemented Ben's suggestion instead, but look forward to being able to switch it to the new method described in the other bug if/when it is implemented. Spec URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/10002490-python-py-key-value/python-py-key-value.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/10002490-python-py-key-value/python-py-key-value-0.3.0-1.fc44.src.rpm
Created attachment 2121965 [details] The .spec file difference from Copr build 9983873 to 10002500
Copr build: https://copr.fedorainfracloud.org/coprs/build/10002500 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2427769-python-py-key-value/fedora-rawhide-x86_64/10002500-python-py-key-value/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I'll take this review.
Package is APPROVED! Please see review output below... Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "*No copyright* Apache License". 351 files have unknown license. Detailed output of licensecheck in /home/rcallico/Documents/rpms/fedora-review/2427769-python-py-key- value/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.14/site- packages, /usr/lib/python3.14 This warning is a false positive. These files are owned by python3-libs. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-py-key-value-shared , python3-py-key-value-aio , python3-py- key-value-aio+disk , python3-py-key-value-aio+elasticsearch , python3-py-key-value-aio+keyring , python3-py-key-value-aio+memory , python3-py-key-value-aio+pydantic This check is not applicable to this package and can be ignored. [-]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-py-key-value-shared-0.3.0-1.fc44.noarch.rpm python3-py-key-value-aio-0.3.0-1.fc44.noarch.rpm python3-py-key-value-aio+disk-0.3.0-1.fc44.noarch.rpm python3-py-key-value-aio+elasticsearch-0.3.0-1.fc44.noarch.rpm python3-py-key-value-aio+keyring-0.3.0-1.fc44.noarch.rpm python3-py-key-value-aio+memory-0.3.0-1.fc44.noarch.rpm python3-py-key-value-aio+pydantic-0.3.0-1.fc44.noarch.rpm python-py-key-value-0.3.0-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpmzv1i739')] checks: 32, packages: 8 python3-py-key-value-aio.noarch: W: no-documentation python3-py-key-value-shared.noarch: W: no-documentation python3-py-key-value-aio.noarch: W: cross-directory-hard-link /usr/lib/python3.14/site-packages/key_value/aio/stores/__init__.py /usr/lib/python3.14/site-packages/key_value/aio/py.typed python3-py-key-value-aio.noarch: W: cross-directory-hard-link /usr/lib/python3.14/site-packages/key_value/aio/wrappers/__init__.py /usr/lib/python3.14/site-packages/key_value/aio/py.typed python3-py-key-value-aio.noarch: W: cross-directory-hard-link /usr/lib/python3.14/site-packages/key_value/aio/wrappers/__init__.py /usr/lib/python3.14/site-packages/key_value/aio/stores/__init__.py python3-py-key-value-shared.noarch: W: cross-directory-hard-link /usr/lib/python3.14/site-packages/key_value/shared/utils/__init__.py /usr/lib/python3.14/site-packages/key_value/shared/errors/wrappers/__init__.py 8 packages and 0 specfiles checked; 0 errors, 6 warnings, 63 filtered, 0 badness; has taken 0.8 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 7 python3-py-key-value-shared.noarch: W: no-documentation python3-py-key-value-aio.noarch: W: no-documentation 7 packages and 0 specfiles checked; 0 errors, 2 warnings, 61 filtered, 0 badness; has taken 0.4 s Source checksums ---------------- https://github.com/strawgate/py-key-value/archive/0.3.0/py-key-value-0.3.0.tar.gz : CHECKSUM(SHA256) this package : 9f0fbd55b9040f9de5444c9ae7fe54ea137fd321156747e71636cefeb74ed7bd CHECKSUM(SHA256) upstream package : 9f0fbd55b9040f9de5444c9ae7fe54ea137fd321156747e71636cefeb74ed7bd Requires -------- python3-py-key-value-shared (rpmlib, GLIBC filtered): python(abi) python3.14dist(beartype) python3.14dist(typing-extensions) python3-py-key-value-aio (rpmlib, GLIBC filtered): python(abi) python3.14dist(beartype) python3.14dist(py-key-value-shared) python3-py-key-value-aio+disk (rpmlib, GLIBC filtered): python(abi) python3-py-key-value-aio python3.14dist(diskcache) python3.14dist(pathvalidate) python3-py-key-value-aio+elasticsearch (rpmlib, GLIBC filtered): python(abi) python3-py-key-value-aio python3.14dist(aiohttp) python3.14dist(elasticsearch) python3-py-key-value-aio+keyring (rpmlib, GLIBC filtered): python(abi) python3-py-key-value-aio python3.14dist(keyring) python3-py-key-value-aio+memory (rpmlib, GLIBC filtered): python(abi) python3-py-key-value-aio python3.14dist(cachetools) python3-py-key-value-aio+pydantic (rpmlib, GLIBC filtered): python(abi) python3-py-key-value-aio python3.14dist(pydantic) Provides -------- python3-py-key-value-shared: python-py-key-value-shared python3-py-key-value-shared python3.14-py-key-value-shared python3.14dist(py-key-value-shared) python3dist(py-key-value-shared) python3-py-key-value-aio: python-py-key-value-aio python3-py-key-value-aio python3.14-py-key-value-aio python3.14dist(py-key-value-aio) python3dist(py-key-value-aio) python3-py-key-value-aio+disk: python-py-key-value-aio+disk python3-py-key-value-aio+disk python3.14-py-key-value-aio+disk python3.14dist(py-key-value-aio[disk]) python3dist(py-key-value-aio[disk]) python3-py-key-value-aio+elasticsearch: python-py-key-value-aio+elasticsearch python3-py-key-value-aio+elasticsearch python3.14-py-key-value-aio+elasticsearch python3.14dist(py-key-value-aio[elasticsearch]) python3dist(py-key-value-aio[elasticsearch]) python3-py-key-value-aio+keyring: python-py-key-value-aio+keyring python3-py-key-value-aio+keyring python3.14-py-key-value-aio+keyring python3.14dist(py-key-value-aio[keyring]) python3dist(py-key-value-aio[keyring]) python3-py-key-value-aio+memory: python-py-key-value-aio+memory python3-py-key-value-aio+memory python3.14-py-key-value-aio+memory python3.14dist(py-key-value-aio[memory]) python3dist(py-key-value-aio[memory]) python3-py-key-value-aio+pydantic: python-py-key-value-aio+pydantic python3-py-key-value-aio+pydantic python3.14-py-key-value-aio+pydantic python3.14dist(py-key-value-aio[pydantic]) python3dist(py-key-value-aio[pydantic]) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2427769 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Python Disabled plugins: fonts, Perl, Ocaml, R, Haskell, C/C++, PHP, SugarActivity, Java Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-py-key-value
FEDORA-2026-1b5280f33a (python-py-key-value-0.3.0-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2026-1b5280f33a
FEDORA-2026-1b5280f33a (python-py-key-value-0.3.0-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2026-5a95a9e0ee (python-py-key-value-0.3.0-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2026-5a95a9e0ee
FEDORA-2026-5a95a9e0ee has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-5a95a9e0ee \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-5a95a9e0ee See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-5a95a9e0ee (python-py-key-value-0.3.0-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.