Bug 242828

Created attachment 156299 [details]
patch to fix overrun/underrun handling

I could not set the kernel version to 5.1, would appreciate if some one can.

David, this may not make the Beta. Will leave the final word to Mike/Tom.

Created attachment 156533 [details]
Fix data overrun/underrun handling, also set AF_ONLINE condition fix.

Basically this adds patch adds one more fix which we discovered while testing
here. The HBA needs to brought ONLINE even if the Initiator IP address is not
set.  Please note this patch also includes the fixes for overrun/underrun
handling as before.

Proposing this bugzilla for post-Beta 5.1 inclusion.

David S/QLogic - is the severity correctly set to "low"?

No it is not. It should be urgent in my opinion. I somehow could not change the
severity for some reason.

Hi David - thanks for the update.

This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

David - has this hit upstream yet?

Yes it has.

Great! Mike, do you need the upstream commits or anything else from QLogic on this?

I can grab them from kernel.org for them.

Need the code, test results and a test plan before QE can weigh in on this
exception.

Perhaps Mike can better understands your request. The code is in the patch? I am uncertain
how one would force data under runs on a target for example - but perhaps that could
be done with a software target. Verifying the on-line status without an IP address should
be possible

An un-reported data-underrun is an important to fix.

(In reply to comment #17)
> Need the code, 

Code that was sent to rh-kernel is in the patch in comment #5.

I am not sure how to make underrun happen. We would have to hack a target to
force it to happen.

Ravi, how did you guys test this?

This bugzilla has been marked POST. However I just downloaded
http://people.redhat.com/dzickus/el5/39.el5/src/kernel-2.6.18-39.el5.src.rpm 

and find that the enclosed patch in this bugzilla is not in yet. 

We really need the fix for turning AF_ONLINE bit on when the ip address is not
set on the HBA. Otherwise the SanSurfer/iscli application will not the see the
HBA. This is critical. 

A simplified version of this patch is 

diff -uarp
/usr/src/redhat/BUILD/kernel-2.6.18/linux-2.6.18.noarch/drivers/scsi/qla4xxx/ql4_init.c
./linux-2.6.18.noarch.39.el5/drivers/scsi/qla4xxx/ql4_init.c
---
/usr/src/redhat/BUILD/kernel-2.6.18/linux-2.6.18.noarch/drivers/scsi/qla4xxx/ql4_init.c
    2007-08-14 10:50:06.000000000 -0700
+++ ./linux-2.6.18.noarch.39.el5/drivers/scsi/qla4xxx/ql4_init.c       
2007-08-14 12:16:03.000000000 -0700
@@ -1181,8 +1181,10 @@ int qla4xxx_initialize_adapter(struct sc

        /* Skip device discovery if ip and subnet is zero */
        if (memcmp(ha->ip_address, ip_address, IP_ADDR_LEN) == 0 ||
-           memcmp(ha->subnet_mask, ip_address, IP_ADDR_LEN) == 0)
+           memcmp(ha->subnet_mask, ip_address, IP_ADDR_LEN) == 0) {
+               set_bit(AF_ONLINE, &ha->flags);
                return status;
+       }

        if (renew_ddb_list == PRESERVE_DDB_LIST) {
                /*

POST means it has been submited to the Red Hat kernel discussion list.
Status set to MODIFIED means it's been accepted.
I will ask about this right away...

in 2.6.18-40.el5
You can download this test kernel from http://people.redhat.com/dzickus/el5

A fix for this issue should have been included in the packages contained in the
most recent snapshot (partners.redhat.com) for RHEL5.1.  

Requested action: Please verify that your issue is fixed as soon as possible to
ensure that it is included in this update release.

After you (Red Hat Partner) have verified that this issue has been addressed,
please perform the following:
1) Change the *status* of this bug to VERIFIED.
2) Add *keyword* of PartnerVerified (leaving the existing keywords unmodified)

If this issue is not fixed, please add a comment describing the most recent
symptoms of the problem you are having and change the status of the bug to FAILS_QA.

More assistance: If you cannot access bugzilla, please reply with a message to
Issue Tracker and I will change the status for you.  If you need assistance
accessing ftp://partners.redhat.com, please contact your Partner Manager.

Mike - is this something that would be needed to be addressed in RHEL 4?

Marcus got it in his RHEL4 update already, right Marcus?

A fix for this issue should have been included in the packages contained in the
RHEL5.1-Snapshot4 on partners.redhat.com.  

Requested action: Please verify that your issue is fixed *as soon as possible*
to ensure that it is included in this update release.

After you (Red Hat Partner) have verified that this issue has been addressed,
please perform the following:
1) Change the *status* of this bug to VERIFIED.
2) Add *keyword* of PartnerVerified (leaving the existing keywords unmodified)

If this issue is not fixed, please add a comment describing the most recent
symptoms of the problem you are having and change the status of the bug to FAILS_QA.

If you cannot access bugzilla, please reply with a message to Issue Tracker and
I will change the status for you.  If you need assistance accessing
ftp://partners.redhat.com, please contact your Partner Manager.

A fix for this issue should have been included in the packages contained in the
RHEL5.1-Snapshot6 on partners.redhat.com.  

Requested action: Please verify that your issue is fixed ASAP to confirm that it
will be included in this update release.

After you (Red Hat Partner) have verified that this issue has been addressed,
please perform the following:
1) Change the *status* of this bug to VERIFIED.
2) Add *keyword* of PartnerVerified (leaving the existing keywords unmodified)

If this issue is not fixed, please add a comment describing the most recent
symptoms of the problem you are having and change the status of the bug to FAILS_QA.

If you cannot access bugzilla, please reply with a message to Issue Tracker and
I will change the status for you.  If you need assistance accessing
ftp://partners.redhat.com, please contact your Partner Manager.

Verified in kernel-2.6.18-46.el5.src.rpm

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2007-0959.html