spec: https://fed500.fedorapeople.org/rust-jid.spec srpm: https://fed500.fedorapeople.org/rust-jid-0.12.1-1.fc44.src.rpm description: A crate which provides a Jid struct for Jabber IDs. fas: fed500 Needed to update python-slixmpp Reproducible: Always
Package builds and looks mostly OK, but the subpackage associated with one optional / non-default feature fails to install: Problem: conflicting requests - nothing provides (crate(minidom/default) >= 0.18.0 with crate(minidom/default) < 0.19.0~) needed by rust-jid+minidom-devel-0.12.1-1.fc44.noarch from @commandline The "minidom" crate is packaged for Fedora, but currently at an older version. Do you need the "minidom" support in "jid" / python-slixmpp? If not, I would recommend to just drop this feature flag (either by using "rust2rpm -p" to drop "minidom" feature / dependency *or* by using a rust2rpm.toml config file, with a "features.hide" setting for "minidom").
I would also override the generated "Summary", the heuristics mangle this one into something that's not quite English.
Thanks for the feedback. Updated to drop minidom: spec: https://fed500.fedorapeople.org/rust-jid.spec srpm: https://fed500.fedorapeople.org/rust-jid-0.12.1-1.fc44.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/10050374 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2428465-rust-jid/fedora-rawhide-x86_64/10050374-rust-jid/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
It appears that you uploaded an SRPM file with the old contents? PS: If you're going with the "patch out from Cargo.toml" route for disabling minidom support, I would recommend to use a rust2rpm.toml config file like this to preserve the changes (rebasing to new versions should be mostly automatic then, even with a patch): ``` [package] cargo-toml-patch-comments = [ "remove optional support for minidom (dependency too old in Fedora)", ] ```
Sorry, linked incorrect srpm spec: https://fed500.fedorapeople.org/rust-jid.spec srpm: https://fed500.fedorapeople.org/rust-jid-0.12.1-1.fc43.src.rpm Figuring out config file
Created attachment 2123680 [details] The .spec file difference from Copr build 10050374 to 10055920
Copr build: https://copr.fedorainfracloud.org/coprs/build/10055920 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2428465-rust-jid/fedora-rawhide-x86_64/10055920-rust-jid/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> Figuring out config file Should be as straightforward as putting a file named "rust2rpm.toml" with the contents I posted above next to the .spec file. Overriding the generated Summary permanently can be done with that too, like ``` [package] summary = "foobar" cargo-toml-patch-comments = ["barbaz"] ``` Package itself looks good to me now. I recommend to come join us in the #rust:fedoraproject.org room on Matrix, usually somebody who can help you with things should be online :) === Package was generated with rust2rpm, simplifying the review. ✅ patch is documented, justified, and OK to keep downstream-only ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional)
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-jid
FEDORA-2026-7f87fec3a9 (rust-jid-0.12.1-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2026-7f87fec3a9
https://release-monitoring.org/project/388148/ Thanks for the review.
FEDORA-2026-7f87fec3a9 has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-7f87fec3a9 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-7f87fec3a9 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
> Needed to update python-slixmpp For this, I would recommend that you make the change a PR so that a member of the Python and / or Rust SIGs can help review the changes. There's also new documentation for this case at https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/#_python_project
python-slixmpp update has been done in rawhide. Need to make a sidetag in f43.
Ok, looks like you still need to update /add a License tag for the python3-%{srcname} subpackage to account for the statically linked dependencies.
FEDORA-2026-7f87fec3a9 (rust-jid-0.12.1-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.