Bug 242910 - Wrong init script
Summary: Wrong init script
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: initscripts
Version: 5.0
Hardware: All
OS: Linux
low
low
Target Milestone: ---
: ---
Assignee: initscripts Maintenance Team
QA Contact: Brock Organ
URL:
Whiteboard:
Depends On:
Blocks: 237789 242911 242912
TreeView+ depends on / blocked
 
Reported: 2007-06-06 12:40 UTC by Michal Marciniszyn
Modified: 2014-02-10 23:03 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-04-27 15:32:15 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Michal Marciniszyn 2007-06-06 12:40:27 UTC
Description of problem:
Some constructions in netfs, network and single initscripts violate our
initscript guidelines. Main problems are incorrect error codes and exiting the
script without calling status command when it is supposed to. For example of
such construction, look at these:
[ -f /etc/sysconfig/network ] || exit 0
[ "${NETWORKING}" = "no" ] && exit 0

Version-Release number of selected component (if applicable):
all

How reproducible:
always

Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
When fixing this bug, please obbey our init script guidelines and be sure that
status command is run correctly.
Our guidelines are on following two pages:
http://intranet.corp.redhat.com/ic/intranet/InitscriptsSpec.html
http://intranet.corp.redhat.com/ic/intranet/InitscriptGuidelines.html

For an example of the script that returns the error codes correctly and always
runs status see:
http://devserv.devel.redhat.com/~mmarcini/amd

This bug is tracked by 237789.

Comment 1 RHEL Program Management 2007-06-06 12:43:52 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 3 Bill Nottingham 2009-04-27 15:32:15 UTC
Changing this would change the behavior of initscripts in a update release, which is bad form.

Also, not having the network configured isn't really an error; this script is sort of a special case.


Note You need to log in before you can comment on or make changes to this bug.