Spec URL: https://raw.githubusercontent.com/eeickmeyer/gnome-shell-extension-pipewire-settings/refs/heads/main/gnome-shell-extension-pipewire-settings.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/eeickmeyer/Jam-Incoming/fedora-rawhide-x86_64/10025031-gnome-shell-extension-pipewire-settings/gnome-shell-extension-pipewire-settings-9~git20251228.41bbf18-1.fc44.src.rpm Description: A drop-down menu for GNOME Shell for configuring the PipeWire quantum and sample rate values. Setting a sample rate or buffer size will incite PipeWire to run with that fixed value. Toggling Force Settings will force the graph to run at the specified sample rate and buffer size unless set to dynamic. Toggling Persist on restart will load the current configuration on restart, however, settings can't be forced automatically on restart. Fedora Account System Username: eeickmeyer
Cannot find any valid SRPM URL for this ticket. Common causes are: - You didn't specify `SRPM URL: ...` in the ticket description or any of your comments - The URL schema isn't HTTP or HTTPS - The SRPM package linked in your URL doesn't match the package name specified in the ticket summary --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> - The SRPM package linked in your URL doesn't match the package name > specified This was the problem, fixed now.
[fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/10035998 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2430546-gnome-shell-extension-pipewire-settings/fedora-rawhide-x86_64/10035998-gnome-shell-extension-pipewire-settings/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Quick comments: I suggest using: Source0: %{url}/archive/%{commit}/%{name}-%{shortcommit}.tar.gz I'd also use the GNOME Shell extension dependency generator: BuildRequires: gnome-shell-rpm-generators and drop the manual Requires: gnome-shell See https://fedoraproject.org/wiki/Changes/GnomeShellExtensionDependencyGenerator .
(In reply to Dominik 'Rathann' Mierzejewski from comment #5) > Quick comments: > > I suggest using: > > Source0: %{url}/archive/%{commit}/%{name}-%{shortcommit}.tar.gz > > I'd also use the GNOME Shell extension dependency generator: > > BuildRequires: gnome-shell-rpm-generators > > and drop the manual > > Requires: gnome-shell > > See > https://fedoraproject.org/wiki/Changes/ > GnomeShellExtensionDependencyGenerator . Done! See https://raw.githubusercontent.com/eeickmeyer/gnome-shell-extension-pipewire-settings/refs/heads/main/gnome-shell-extension-pipewire-settings.spec
> %autosetup -C -n pipewire-settings-%{commit} Drop "-n pipewire-settings-%{commit}", it's superfluous with "-C". > %{_datadir}/gnome-shell/extensions/pipewire-settings.com Please put a trailing slash so it's known that's a directory.
(In reply to Neal Gompa from comment #7) > > %autosetup -C -n pipewire-settings-%{commit} > > Drop "-n pipewire-settings-%{commit}", it's superfluous with "-C". > > > %{_datadir}/gnome-shell/extensions/pipewire-settings.com > > Please put a trailing slash so it's known that's a directory. Done! https://raw.githubusercontent.com/eeickmeyer/gnome-shell-extension-pipewire-settings/refs/heads/main/gnome-shell-extension-pipewire-settings.spec
Why is the version 9 when the last version tagged upstream is 3? Obviously, it's a commit post-tagging, but if upstream tags v4, then you'd need an Epoch to go backwards. Snapshots should be treated as such: https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots
(In reply to Elliott Sales de Andrade from comment #9) > Why is the version 9 when the last version tagged upstream is 3? Obviously, > it's a commit post-tagging, but if upstream tags v4, then you'd need an > Epoch to go backwards. > > Snapshots should be treated as such: > https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/ > #_snapshots The versioning comes from https://extensions.gnome.org/review/67539 and coincides with the git commit in question. I have requested that the upstream do tags in the future: https://github.com/gaheldev/pipewire-settings/issues/7#issuecomment-3724926441
Spec URL: https://raw.githubusercontent.com/eeickmeyer/gnome-shell-extension-pipewire-settings/refs/heads/main/gnome-shell-extension-pipewire-settings.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/eeickmeyer/Jam-Incoming/fedora-rawhide-x86_64/10036692-gnome-shell-extension-pipewire-settings/gnome-shell-extension-pipewire-settings-9~git20251228.41bbf18-1.fc44.src.rpm
Created attachment 2123213 [details] The .spec file difference from Copr build 10035998 to 10043100
Copr build: https://copr.fedorainfracloud.org/coprs/build/10043100 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2430546-gnome-shell-extension-pipewire-settings/fedora-rawhide-x86_64/10043100-gnome-shell-extension-pipewire-settings/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Hi @dominik, Is there anything further that needs to be done? Thanks in advance!
My apologies, I was on vacation. It looks like the gnome-shell extension dependency generator doesn't work correctly, as no Requires: gnome-shell(api) = 49 is generated. Please add it manually for now. This will fix the directory ownership and missing Requires on gnome-shell. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* GNU General Public License, Version 3", "GNU General Public License v3.0 or later". 13 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/gnome-shell-extension-pipewire- settings/licensecheck.txt [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gnome- shell/extensions, /usr/share/gnome-shell [-]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [!]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1757 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: gnome-shell-extension-pipewire-settings-9~git20251228.41bbf18-1.fc44.noarch.rpm gnome-shell-extension-pipewire-settings-9~git20251228.41bbf18-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpor3g2495')] checks: 32, packages: 2 gnome-shell-extension-pipewire-settings.spec: W: no-%check-section gnome-shell-extension-pipewire-settings.noarch: W: incoherent-version-in-changelog 9~git20251228.41bbf18-1.fc43 ['9~git20251228.41bbf18-1.fc44', '9~git20251228.41bbf18-1'] 2 packages and 0 specfiles checked; 0 errors, 2 warnings, 7 filtered, 0 badness; has taken 0.1 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s (none): E: there is no installed rpm "gnome-shell-extension-pipewire-settings". There are no files to process nor additional arguments. Nothing to do, aborting. Source checksums ---------------- https://github.com/gaheldev/pipewire-settings/archive/41bbf185db8af3bd3443207510677ca87b2177de/gnome-shell-extension-pipewire-settings-41bbf18.tar.gz : CHECKSUM(SHA256) this package : 3cf2107aa9f28600711f56df513e90a03bb80996db977250cf0b7fb8d9aee7dd CHECKSUM(SHA256) upstream package : 3cf2107aa9f28600711f56df513e90a03bb80996db977250cf0b7fb8d9aee7dd Requires -------- gnome-shell-extension-pipewire-settings (rpmlib, GLIBC filtered): Provides -------- gnome-shell-extension-pipewire-settings: gnome-shell-extension-pipewire-settings Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name gnome-shell-extension-pipewire-settings --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Haskell, SugarActivity, Java, Perl, C/C++, Ocaml, R, Python, PHP, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Spec URL: https://raw.githubusercontent.com/eeickmeyer/gnome-shell-extension-pipewire-settings/refs/heads/main/gnome-shell-extension-pipewire-settings.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/eeickmeyer/Jam-Incoming/fedora-rawhide-x86_64/10094009-gnome-shell-extension-pipewire-settings/gnome-shell-extension-pipewire-settings-9~git20251228.41bbf18-1.fc44.src.rpm
Created attachment 2128186 [details] The .spec file difference from Copr build 10043100 to 10094018
Copr build: https://copr.fedorainfracloud.org/coprs/build/10094018 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2430546-gnome-shell-extension-pipewire-settings/fedora-rawhide-x86_64/10094018-gnome-shell-extension-pipewire-settings/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Hi Dominik, I fixed the issues in question. Could you give me a re-review? Thanks!
Looks good now, approved.
The Pagure repository was created at https://src.fedoraproject.org/rpms/gnome-shell-extension-pipewire-settings
FEDORA-2026-b7cfb2d046 (gnome-shell-extension-pipewire-settings-9~git20251228.41bbf18-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2026-b7cfb2d046