Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://people.redhat.com/~mhorky/rhc-fedora/rhc.spec SRPM URL: https://people.redhat.com/~mhorky/rhc-fedora/rhc-0.3.5-99.20260112git43f0a10.fc43.src.rpm Description: rhc is a client to connect to Red Hat services for Subscription Management and Red Hat Lightspeed Fedora Account System Username: mhorky
Copr build: https://copr.fedorainfracloud.org/coprs/build/10035988 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2430840-rhc/fedora-rawhide-x86_64/10035988-rhc/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://people.redhat.com/~mhorky/rhc-fedora/rhc.spec SRPM URL: https://people.redhat.com/~mhorky/rhc-fedora/rhc-0.3.5-1.fc43.src.rpm
Created attachment 2122940 [details] The .spec file difference from Copr build 10035988 to 10038922
Copr build: https://copr.fedorainfracloud.org/coprs/build/10038922 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2430840-rhc/fedora-rawhide-x86_64/10038922-rhc/fedora-review/review.txt Found issues: - Systemd service file(s) in rhc Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_scriptlets Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Looks good to me! Approved. I also ran a scratch build of the SRPM successfully. https://koji.fedoraproject.org/koji/taskinfo?taskID=141356080
The Pagure repository was created at https://src.fedoraproject.org/rpms/rhc
FEDORA-2026-28179828b0 (rhc-0.3.5-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2026-28179828b0
FEDORA-2026-28179828b0 (rhc-0.3.5-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.
> %{_mandir}/man1/* It should be %{_mandir}/man1/rhc.1* https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages > %if 0%{?fedora} > Recommends: insights-client AFAIK the package doesn't exist in Fedora, it can't be recommended. > BuildRequires: pkgconfig(bash-completion) What for? > %{_datadir}/bash-completion/completions/rhc Use: %{bash_completions_dir}/%{name} > BuildRequires: make Is it used? > BuildRequires: pkgconfig(systemd) Is it required? > BuildRequires: golang > BuildRequires: go-rpm-macros These are pulled by go macros, could be removed I see the package has been imported already, but would be great if you could fix reported issues. I'm writing here so Link also can see what was missing.
Thank you Mikel for noticing that, I've fixed everything you've mentioned. I took inspiration from an rhc spec file as it exists in RHEL and CentOS Stream, I'll clean it there as well, eventually.
This comment was flagged as spam, view the edit history to see the original text if required.
Hi Andrew, I believe you are replying to a wrong ticket, your message doesn't seem connected to the introduction of rhc into Fedora.