Spec URL: https://straylen.web.cern.ch/rpms/python-coredump_exporter/python-coredump_exporter.spec SRPM URL: https://straylen.web.cern.ch/rpms/python-coredump_exporter/python-coredump_exporter-0.2.1-1.fc42.src.rpm Description: Prometheus exporter to export metrics of systemd-coredumpctl Fedora Account System Username: stevetraylen
Copr build: https://copr.fedorainfracloud.org/coprs/build/10042254 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2431666-python-coredump_exporter/fedora-rawhide-x86_64/10042254-python-coredump_exporter/fedora-review/review.txt Found issues: - Systemd service file(s) in python3-coredump_exporter Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_scriptlets Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Thankyou robot: systemd scriptlets now correctly on the sub-package package name. Spec URL: https://straylen.web.cern.ch/rpms/python-coredump_exporter/python-coredump_exporter.spec SRPM URL: https://straylen.web.cern.ch/rpms/python-coredump_exporter/python-coredump_exporter-0.2.1-1.fc42.src.rpm
Created attachment 2123187 [details] The .spec file difference from Copr build 10042254 to 10042301
Copr build: https://copr.fedorainfracloud.org/coprs/build/10042301 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2431666-python-coredump_exporter/fedora-rawhide-x86_64/10042301-python-coredump_exporter/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
For the next iteration I will expand on why nose was sed removed from .spec file. It is only used for the flake files which is are not used at all in this build.