Spec URL: https://music.fedorapeople.org/rust-ppmd-rust.spec SRPM URL: https://music.fedorapeople.org/rust-ppmd-rust-1.4.0-1.fc43.src.rpm Description: PPMd compression / decompression. Fedora Account System Username: music Upstream has relicensed this from CC0-1.0 to (CC0-1.0 OR MIT-0), making it possible to package for Fedora. This package will allow us to stop patching PPMd support out of the default features of the zip crate, https://src.fedoraproject.org/rpms/rust-zip/blob/a611b7b40b11b910c0837a57f98c2badd33e06bb/f/rust2rpm.toml#_13. A scratch build of this package succeeded: https://koji.fedoraproject.org/koji/taskinfo?taskID=141516804
Created attachment 2123588 [details] Configuration file for rust2rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/10054108 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2432547-rust-ppmd-rust/fedora-rawhide-x86_64/10054108-rust-ppmd-rust/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Created attachment 2123589 [details] Updated configuration file for rust2rpm Fixed a text-wrapping issue
Package was generated with rust2rpm, simplifying the review. Patches / additional source files are justified and very well documented. Note that I would remove the CC0-1.0 license text from the crate ("rm" in %prep?) and drop the `%license` %files entry for it too. Removing it from the license tag / metadata but still shipping the actual license text seems to be a bit contradictory. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional)
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-ppmd-rust
Thank you for the review. > Note that I would remove the CC0-1.0 license text from the crate ("rm" in %prep?) and drop the `%license` %files entry for it too. Removing it from the license tag / metadata but still shipping the actual license text seems to be a bit contradictory. This is sensible. I will implement this suggestion on initial import.
FEDORA-2026-452dc35cd8 (rust-ppmd-rust-1.4.0-1.fc45) has been submitted as an update to Fedora 45. https://bodhi.fedoraproject.org/updates/FEDORA-2026-452dc35cd8
FEDORA-2026-191f2db5fd (rust-ppmd-rust-1.4.0-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2026-191f2db5fd
FEDORA-2026-7b1efc9c44 (rust-ppmd-rust-1.4.0-1.fc43 and rust-typed-path-0.12.3-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2026-7b1efc9c44
FEDORA-2026-2aa0b902db (rust-ppmd-rust-1.4.0-1.fc42 and rust-typed-path-0.12.3-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2026-2aa0b902db
FEDORA-EPEL-2026-809db03ed4 (rust-ppmd-rust-1.4.0-1.el10_2 and rust-typed-path-0.12.3-1.el10_2) has been submitted as an update to Fedora EPEL 10.2. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2026-809db03ed4
FEDORA-2026-452dc35cd8 (rust-ppmd-rust-1.4.0-1.fc45) has been pushed to the Fedora 45 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2026-191f2db5fd (rust-ppmd-rust-1.4.0-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2026-2aa0b902db has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-2aa0b902db \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-2aa0b902db See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2026-809db03ed4 has been pushed to the Fedora EPEL 10.2 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2026-809db03ed4 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-7b1efc9c44 has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-7b1efc9c44 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-7b1efc9c44 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2026-5fe6ceeee7 (rust-lzma-rust2-0.16.1-1.el9, rust-ppmd-rust-1.4.0-1.el9, and 2 more) has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2026-5fe6ceeee7
FEDORA-2026-2aa0b902db has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-2aa0b902db` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-2aa0b902db See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-7b1efc9c44 has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-7b1efc9c44` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-7b1efc9c44 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2026-5fe6ceeee7 has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2026-5fe6ceeee7 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-7b1efc9c44 (rust-lzma-rust2-0.16.1-1.fc43, rust-ppmd-rust-1.4.0-1.fc43, and 2 more) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2026-2aa0b902db (rust-lzma-rust2-0.16.1-1.fc42, rust-ppmd-rust-1.4.0-1.fc42, and 2 more) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2026-809db03ed4 (rust-lzma-rust2-0.16.1-1.el10_2, rust-ppmd-rust-1.4.0-1.el10_2, and 2 more) has been pushed to the Fedora EPEL 10.2 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2026-5fe6ceeee7 (rust-lzma-rust2-0.16.1-1.el9, rust-ppmd-rust-1.4.0-1.el9, and 2 more) has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report.